[vJASS] UnitAddAbility and UnitRemoveAbility

[DrizztDoUrden]

Guy, I have a problem :|
Every such piece of code doesn't add second ability...
Both abilities with such IDs exist in my map but after this code execution first ability is deleted and second isn't added.

call UnitRemoveAbility(GetSpellAbilityUnit(), 'SFiE')
call UnitAddAbility(GetSpellAbilityUnit(), 'DFiE')

I need this working to make a toggling spell.

 

[Teelo]

From what you've posted there it should work. Can you post the map.

 

[DrizztDoUrden]

Here it is.
This is in the bottom of library in "Enrage..." functions.

 

[Teelo]

I wonder that the GetSpellAbilityUnit() is changing. Could you test this by changing that function to:

  private function EnrageCast takes nothing returns nothing
       local unit caster = GetSpellAbilityUnit()
    set hPlayerHero[GetPlayerId(GetOwningPlayer(caster))].damageModifier = SCOPE_PRIVATE + "Enrage"
    call UnitRemoveAbility(caster, 'SFiE')
    call UnitAddAbility(caster, 'DFiE')
  endfunction

and let me know if anything changes. If not, when running your map, how do I test this?

 

[Troll-Brain]

Just in case, you can't add buffs with UnitAddAbility, but you can remove them with UnitRemoveAbility.

Also make sure all requirements are matched (tech requirements and such).

 

[Teelo]

He doesn't have any techtree requirements on that ability.

Also, from the description of the ability:

You will deal normal damage again and will loose no more |cff0000ffmana|r for attacks.

*twitch* *twitch*

 

[DrizztDoUrden]

LOL, it works now.
About description - changed "loose" to "spend". Sorry, eng isn't my native language

Without any providen code i'm not going to believe you (you probably don't care though)

Look this maps code.
You are free to try it.
To change class change variable in the bottom of onInit function. They are listed just before hero creation.

 

[Troll-Brain]

Actually i was talking to mckill, and this is the wrong thread

 

[DrizztDoUrden]

Actually i was talking to mckill, and this is the wrong thread

Oh, lol, forget it then

 

[Teelo]

Making it local worked? Good to hear.

 

[Troll-Brain]

Hmm interesting, check if GetSpellAbilityUnit() returns null just after you remove the ability, that could explain this bug.
I remember had already read something like that.