[JASS] Unit-Group Fun

[Tal'Rarity]

Custom script: if udg_kamegroup99[udg_kameindex99] == null then
Custom script: set udg_kamegroup99[udg_kameindex99] = CreateGroup()
Custom script: endif

Because unit-groups are bugged in GUI, wouldn't those lines of JASS fix unit-group arrays? For some reason it is bugging and also can't be destroyed. I usually just remove all data from one with loop in it then loop it to index.

 

[edo494]

you can destroy group with call DestroyGroup(groupToDestroy)

and yes that is the only way of fixing the GUI's problem with Unit Group, if you dont want to init it to like 8191 size, which I dont recommend, because that really heaviers the Main thread running when map starts to load all Blizzard's globals, call Init Functions and stuff. You may get to point that some Init Functions wont even get called

 

[Tal'Rarity]

Could you take a look at http://www.hiveworkshop.com/forums/spells-569/kamehameha-version-2-10-a-251395/ then?

I can't destroy it otherwise it just simply stops working as well the third user jumps his beam

 

[Ceday]

In that spell code you are using

Custom script: if udg_kamegroup99[udg_kameloop99] == null then
Custom script: set udg_kamegroup99[udg_kameloop99] = CreateGroup()
Custom script: endif

array index variable is wrong.

 

[Tal'Rarity]

Thanks, but that was fixed already. Anything else like the problem I was asking about?

 

[edo494]

you dont need to destroy the group necessarily, cause you actually check if it is null, and only if it is null you create new one. You are most likely better off just clearing the group

 

[Tal'Rarity]

What about the removal of units from a different index?

 

[PurgeandFire]

I didn't read the entire thread, but make sure you assign the global to null after you destroy it. For example:

• Custom script: call DestroyGroup(udg_kamegroup99[udg_kameindex99])
• Custom script: set udg_kamegroup99[udg_kameindex99] = null

If I recall correctly, destroying a global doesn't mean that it will equate with null. It'll just point to a destroyed object (which isn't the same as "null"). Here is an example:

call DestroyGroup(udg_kamegroup99[udg_kameindex99])
if udg_kamegroup99[udg_kameindex99] == null then
    call BJDebugMsg("Null")
else
    call BJDebugMsg("Not null")
endif

If memory serves me correctly, then this will display "not null".

 

[Tal'Rarity]

Sadly that doesn't work and creates the same error I have come across so often. You just can't destroy group arrays or I am doing it horribly wrong.

I attached the version I added destroy group and nulling.

 

[BPower]

PurgeandFire is right with the assumption that the reference still exists, therefore it will print out: "not null".

Group arrays can be destroyed like normal groups. For instance:

set TestGroup[1] = CreateGroup()
call DestroyGroup(TestGroup[1])
set TestGroup[1] = null

 

[Tal'Rarity]

Can you help explain to me what's going on in my spell map then?

Because if it isn't that then there is quite something wrong with indexing.

 

[deathismyfriend]

Can you help explain to me what's going on in my spell map then?

Because if it isn't that then there is quite something wrong with indexing.

Can you post the triggers ?

 

[Tal'Rarity]

Can you post the triggers ?

http://www.hiveworkshop.com/forums/spells-569/kamehameha-version-2-10-a-251395/

 

[PurgeandFire]

Here is the issue:

• Set kamegroup99[kameloop99] = kamegroup99[kameindex99]
• Custom script: call DestroyGroup(udg_kamegroup99[udg_kameindex99])
• Custom script: set udg_kamegroup99[udg_kameindex99] = null

Let "current" represent "kameloop99", "last" represent "kameindex99", "G" represent kamegroup99

You first set:
G[current] = G[last]

This is necessary, but you are basically abandoning G[current]. The next line destroys G[last]. But G[last] was never changed! It still points to the same group it did before. It doesn't point to G[current]'s old group just because you set G[current] to G[last]. They'll both end up pointing to that group. Therefore, you are destroying the "last" group. That causes issues. Here is the fixed code:

• Custom script: call DestroyGroup(udg_kamegroup99[udg_kameloop99])
• Set kamegroup99[kameloop99] = kamegroup99[kameindex99]
• Custom script: set udg_kamegroup99[udg_kameindex99] = null

That will be the proper recycling (basically, I just moved the line upward and changed kameindex99 to kameloop99), and unless I'm mistaken, it should work.

 

[Tal'Rarity]

Wow I am such an idiot, I always do this... Sorry however thank you so much guys =)

Always them little errors about placement.

 

[deathismyfriend]

Easy way to remember is to always remove / destroy before de-indexing. Then you will be fine and will not make the mistake.