Tree Disguise V 1.0.0.2

[Moderator]

9th Nov 2011
Bribe: It's weird.

Approved. Please add a better description on how to import it though.

 

[Vehster]

The only problem I can see with this is using custom value...

Otherwise I love this spell madd.
Though I suggest trying to duplicate custom value with a integer variable instead of actually using custom value.
Same goes for using the global loop... ( Integer A )

 

[maddeem]

Nothing wrong with using custom value so long as it comes from an indexer. Also, I use Integer A to save myself from creating another variable =p

 

[Magtheridon96]

Integer A can cause a lot of issues :/
It's best to create a new integer and use it.

If you disagree, you'd be saying that using one global integer as an index for iteration throughout the map is 'ok' :/

 

[maddeem]

BLARGGGGGGGG!!!!!!!!!
You know there is a problem if Magtheridon disagrees with you. I'll fix it asap. Lol.

~Fixed

 

[Bannar]

Don't you think that this spell is too simple?
(Target destructible of ability being cast) should be stored in variable.

+rep for preview picture D;

 

[Magtheridon96]

(Target destructible of ability being cast) should be stored in variable.

Almost forgot about that

You know there is a problem if Magtheridon disagrees with you. I'll fix it asap. Lol.

Actually, when BRIBE disagrees with you, you know there's a problem

 

[maddeem]

Whoops, I keep forgetting to post a trigger. There we go.

 

[Bannar]

Switch "Then" with "Else" actions and do:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • Duration[TempInteger] Less than or equal to 0.00
        • (TempUnit is dead) Equal to True

->>

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Duration[TempInteger] Greater than 0.00
    • (TempUnit is dead) Equal to False

 

[Magtheridon96]

Or you could use custom scripts

• Custom script: if udg_Duration[udg_TempInteger] <= 0. or IsUnitType(udg_TempUnit, UNIT_TYPE_DEAD) then
• // PASTE THE ACTIONS INSIDE THE IF->THEN OVER HERE
• Custom script: else
• // PASTE THE ACTIONS INSIDE THE IF->ELSE OVER HERE
• Custom script: endif

 

[Bannar]

@Maggy Or... move to jass ;>

 

[Magtheridon96]

That works too c:

 

[RakEnRoL]

This looks like in fufu Cool

 

[Orcnet]

what a really useful spell, might wait for the updates to get fix

 

[Bribe]

• For each (Integer TempInteger) from 0 to 3, do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Destructible-type of (Target destructible of ability being cast)) Equal to TreeDummyType[TempInteger]
      • Then - Actions
        • Set TreeType[(Custom value of TempUnit)] = TreeDummyType[(TempInteger + 1)]
      • Else - Actions

The "3" in "0-3" should be configurable if someone wanted to register more or fewer tree types, for example.

I am not sure why you use (TempInteger + 1) instead of TempInteger. I'm not even sure why you need this search-method in the first place instead of just doing this:

• Set TreeType[(Custom value of (Triggering unit))] = Destructable-type of (Target destructable of ability being cast)

 

[Ilike]

Reminds me of this:

Awesome spell by the way.

 

[maddeem]

• For each (Integer TempInteger) from 0 to 3, do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Destructible-type of (Target destructible of ability being cast)) Equal to TreeDummyType[TempInteger]
      • Then - Actions
        • Set TreeType[(Custom value of TempUnit)] = TreeDummyType[(TempInteger + 1)]
      • Else - Actions

The "3" in "0-3" should be configurable if someone wanted to register more or fewer tree types, for example.

I am not sure why you use (TempInteger + 1) instead of TempInteger. I'm not even sure why you need this search-method in the first place instead of just doing this:

• Set TreeType[(Custom value of (Triggering unit))] = Destructable-type of (Target destructable of ability being cast)

Because I need a dummy tree (one that has no collision so that the movement looks fluent) and I stored the tree types and stuff in the initialization of the map. You save it like this.

• Int Tree Dummies
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set TreeDummyType[0] = Summer Tree Wall
    • Set TreeDummyType[1] = Summer Tree Dummy
    • Set TreeDummyType[2] = Ashenvale Tree Wall
    • Set TreeDummyType[3] = Ashenvale Tree Dummy

There is a order, the original tree goes first then you +1 it to find the dummy tree... Hope that cleared it up. And it is configurable. Just do a 1 min search of the code and you should find it xD

 

[Bribe]

It makes more sense to have the array cap at "Int Tree Dummies" because that's the designated spot for configuration.

 

[Maker]

I don't think you need to play the destructible's animation if the unit is not moving.

• Special Effect - Destroy (Last created special effect)

^The last action in the cast trigger in both else and then branches. Make it the last action in the trigger, don't place it inside the I/T/E.

 

[maddeem]

I don't think you need to play the destructible's animation if the unit is not moving.

• Special Effect - Destroy (Last created special effect)

^The last action in the cast trigger in both else and then branches. Make it the last action in the trigger, don't place it inside the I/T/E.

Yup, you do. If you remove it and the unit stops moving then the tree will play the stump animation after a while.

 

[xIceShotx]

Reminds me of this:

Lol.......
-On Topic
Btw, i would've never thought of the spell idea

 

[Matarael]

Odd concept, I can't wait to see it *downloads*

 

[Ken-E]

Looks great, very useful for someone who's making a unit like a Mirage Tank from RA2

 

[Tank-Commander]

Just felt like pointing this out:

• Animation - Play Tree[TempInteger]'s stand animation
• Else - Actions
  • Animation - Play Tree[TempInteger]'s stand animation

May as well take the animation play outside of the whole IF block if it's going to run it regardless of outcome