Touch of Lightnings 1.01[GUI]

[Moderator]

12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.

GetForLoopIndexA() -> bj_forLoopAInded
Combine the loops.
You leak points.
Only add the ability you need, not both.

 

[.OmG.]

Hello guys!
This is my first Jass spell, please, don't estimate strictly xD
Spell is too simple...
Any suggestions are welcome!
And please, give credits if use it.

 

[pks9067]

my eye hurts..

 

[Maker]

It looks like it is converted from GUI.

*Don't use locations, use coordinates
*Get rid of BJs and useless function calls, like xxxSwapped, GetLastCreatedUnit.
*You can just return GepSpellAbilityId() == xxx, no need for if then else

 

[mckill2009]

Looks like GUI converted to Jass, the coding is very bad...
- Never use locations, use coordinates instead
- Never use functions like "Trig_some_on_jass_Func026C" and a-like, that is very bad
- Never use BJ's when coding, well except for a few good BJ's
- Use loops when creating units
- Null unit variables
- You must make an expiring timer for your dummy

and a lot more...

EDIT: Maker did some pointers...

EDIT2: And since you are using vJASS...

Here is the improved spell of yours to get some pointers...

scope TouchOfLightning initializer init

globals
    // ----
    //  SETUP PART
    // ----
    private constant integer SpellID = 'A003' //ordercode of your main ability
    private constant real zLoc=250.0   //z coordinate of chains
    private constant real offset=200   //distance beetween target loc and 4 other locations
    private constant integer dummyorder='h000' //ordercode of your dummy guy
    private constant integer dummyorderspell='A000' //ordercode of your dummy spell - chainlightning[enemy]
    private constant string orderenemystring="chainlightning" //order of enemy ability(chain lightning)
    private constant integer dummyorderspell2='A002' //ordercode of your dummy spell - healingwave[aliied]
    private constant string orderalliedstring="healingwave" //order of heal ability(ALLID)
    // ----
    //  END OF CONFIGURATIONS
    // ----
endglobals

private function CAST takes nothing returns boolean
    local unit u
    local unit target
    local unit dummy
    local integer i
    local real x
    local real y
    local integer level
    if GetSpellAbilityId()==SpellID then
        set u=GetTriggerUnit()
        set target=GetSpellTargetUnit()
        set x = GetUnitX(target)
        set y = GetUnitY(target)
        set level = GetUnitAbilityLevel(u, SpellID)
        set i = 0
        loop
            set dummy = CreateUnit(GetTriggerPlayer(), dummyorder, x, y, 0) 
            call SetUnitFlyHeight(dummy, zLoc, 0.00)
            call UnitApplyTimedLife(dummy, 'BTLF', 1.0)
            if IsUnitEnemy(target, GetTriggerPlayer()) then
                call UnitAddAbility(dummy, dummyorderspell)
                call SetUnitAbilityLevel(dummy, dummyorderspell, level)
                call IssueTargetOrder(dummy, orderenemystring, target)               
            else
                call UnitAddAbility(dummy, dummyorderspell2)
                call SetUnitAbilityLevel(dummy, dummyorderspell2, level)
                call IssueTargetOrder(dummy, orderalliedstring, target)                
            endif
            set i = i+1
            exitwhen i > 4        
        endloop
    endif
    set u = null
    set target = null
    set dummy = null
    return false
endfunction

private function init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition(t, Condition(function CAST))
    set t = null
endfunction

endscope

 

[Magtheridon96]

Or, you could do this:

library SpellToL
    globals
        // Ability Code
        private constant integer    ABIL_CODE           = 'A003'
        // Maximum Distance between lightnings
        private constant real       MAX_DISTANCE        = 200
        // The Spell Dummy
        private constant integer    DUMMY_CODE          = 'h000'
        // The Damaging Lightning Ability ID
        private constant integer    DUMMY_CAST1         = 'A000'
        // The Healing Lightning Ability ID
        private constant integer    DUMMY_CAST2         = 'A002'
        // The Healing Lightning
        private constant string     LIGHTNING_HEAL      = "healingwave"
        // The Damaging Lightning
        private constant string     LIGHTNING_CHAIN     = "chainlightning"
    endglobals

    private module Init
        private static method onInit takes nothing returns nothing
            local trigger t = CreateTrigger()
            call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
            call TriggerAddCondition(t,Condition(function thistype.cast))
            set t = null
        endmethod
    endmodule
    
    private struct Spell extends array
        static method filter takes nothing returns boolean
            local unit u = GetFilterUnit()
            if GetWidgetLife(u)>0.405 and not IsUnitType(u,UNIT_TYPE_STRUCTURE) then
                set u=null
                return true
            endif
            set u=null
            return false
        endmethod
        static method cast takes nothing returns boolean
            local unit u
            local unit t
            local unit d
            local real x
            local real y
            local player p
            local integer l
            local integer i=0
            local group g = CreateGroup()
            if GetSpellAbilityId()==ABIL_CODE then
                set u = GetTriggerUnit()
                set p = GetTriggerPlayer()
                set t = GetSpellTargetUnit()
                set l = GetUnitAbilityLevel(u,ABIL_CODE)
                loop
                    set x = GetUnitX(t)
                    set y = GetUnitY(t)
                    set d = CreateUnit(p,DUMMY_CODE,x,y,0)
                    call UnitApplyTimedLife(d,'BTLF',1.0)
                    if IsUnitEnemy(t,p) then
                        call UnitAddAbility(d,DUMMY_CAST1)
                        call SetUnitAbilityLevel(d,DUMMY_CAST1,l)
                        call IssueTargetOrder(d,LIGHTNING_CHAIN,t)               
                    else
                        call UnitAddAbility(d,DUMMY_CAST2)
                        call SetUnitAbilityLevel(d,DUMMY_CAST2,l)
                        call IssueTargetOrder(d,LIGHTNING_HEAL,t)                
                    endif
                    call GroupEnumUnitsInRange(g,x,y,MAX_DISTANCE,function thistype.filter)
                    set t=FirstOfGroup(g)
                    call GroupClear(g)
                    set i=i+1
                    exitwhen i>4
                endloop
            endif
            call DestroyGroup(g)
            set u = null
            set t = null
            set d = null
            set p = null
            set g = null
            return false
        endmethod
        implement Init
    endstruct
endlibrary

:3

edit
Fixed a bug and a compile error xD

 

[mckill2009]

frankly, offset(MAX_DISTANCE) and zLoc(ZL) is really useless...also I should suggest to pick 1 unit within range(FirstOfGroup), if the picked unit is ally then cast heal if enemy, then cast damage, now that's cool coz the light's color will change randomly...

 

[.OmG.]

Thanks guys for Improving my code, I`l update it soon.

It is very important for me, because I`m learning jass.
Tell me please, why I should not use this points? It leaks?
In advance, thanks.

Looks like GUI converted to Jass, the coding is very bad...
- Never use locations, use coordinates instead
- Never use functions like "Trig_some_on_jass_Func026C" and a-like, that is very bad
- Never use BJ's when coding, well except for a few good BJ's
- Use loops when creating units
- Null unit variables
- You must make an expiring timer for your dummy

and a lot more...

EDIT: Maker did some pointers...

EDIT2: And since you are using vJASS...

Here is the improved spell of yours to get some pointers...

scope TouchOfLightning initializer init

globals
    // ----
    //  SETUP PART
    // ----
    private constant integer SpellID = 'A003' //ordercode of your main ability
    private constant real zLoc=250.0   //z coordinate of chains
    private constant real offset=200   //distance beetween target loc and 4 other locations
    private constant integer dummyorder='h000' //ordercode of your dummy guy
    private constant integer dummyorderspell='A000' //ordercode of your dummy spell - chainlightning[enemy]
    private constant string orderenemystring="chainlightning" //order of enemy ability(chain lightning)
    private constant integer dummyorderspell2='A002' //ordercode of your dummy spell - healingwave[aliied]
    private constant string orderalliedstring="healingwave" //order of heal ability(ALLID)
    // ----
    //  END OF CONFIGURATIONS
    // ----
endglobals

private function CAST takes nothing returns boolean
    local unit u
    local unit target
    local unit dummy
    local integer i
    local real x
    local real y
    local integer level
    if GetSpellAbilityId()==SpellID then
        set u=GetTriggerUnit()
        set target=GetSpellTargetUnit()
        set x = GetUnitX(target)
        set y = GetUnitY(target)
        set level = GetUnitAbilityLevel(u, SpellID)
        set i = 0
        loop
            set dummy = CreateUnit(GetTriggerPlayer(), dummyorder, x, y, 0) 
            call SetUnitFlyHeight(dummy, zLoc, 0.00)
            call UnitApplyTimedLife(dummy, 'BTLF', 1.0)
            if IsUnitEnemy(target, GetTriggerPlayer()) then
                call UnitAddAbility(dummy, dummyorderspell)
                call SetUnitAbilityLevel(dummy, dummyorderspell, level)
                call IssueTargetOrder(dummy, orderenemystring, target)               
            else
                call UnitAddAbility(dummy, dummyorderspell2)
                call SetUnitAbilityLevel(dummy, dummyorderspell2, level)
                call IssueTargetOrder(dummy, orderalliedstring, target)                
            endif
            set i = i+1
            exitwhen i > 4        
        endloop
    endif
    set u = null
    set target = null
    set dummy = null
    return false
endfunction

private function init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition(t, Condition(function CAST))
    set t = null
endfunction

endscope

Or, you could do this:

library SpellToL
    globals
        // Ability Code
        private constant integer    ABIL_CODE           = 'A003'
        // Lightning Height
        private constant real       ZL                  = 250.0
        // Maximum Distance between lightnings
        private constant real       MAX_DISTANCE        = 200
        // The Spell Dummy
        private constant integer    DUMMY_CODE          = 'h000'
        // The Damaging Lightning Ability ID
        private constant integer    DUMMY_CAST1         = 'A000'
        // The Healing Lightning Ability ID
        private constant integer    DUMMY_CAST2         = 'A002'
        // The Healing Lightning
        private constant string     LIGHTNING_HEAL      = "healingwave"
        // The Damaging Lightning
        private constant string     LIGHTNING_CHAIN     = "chainlightning"
    endglobals

    private module Init
        private static method onInit takes nothing returns nothing
            local trigger t = CreateTrigger()
            call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
            call TriggerAddCondition(t,Condition(function thistype.cast))
            set t = null
        endmethod
    endmodule
    
    private struct Spell extends array
        static method cast takes nothing returns boolean
            local unit u
            local unit t
            local unit d
            local real x
            local real y
            local player p
            local integer l
            local integer i
            if GetSpellAbilityId()==ABIL_CODE then
                set u = GetTriggerUnit()
                set p = GetTriggerPlayer()
                set t = GetSpellTargetUnit()
                set x = GetUnitX(t)
                set y = GetUnitY(t)
                set l = GetUnitAbilityLevel(u,ABIL_CODE)
                set i = 0
                loop
                    set d = CreateUnit(p,DUMMY_CODE,x,y,0)
                    call UnitAddAbility(d,'Arav')
                    call UnitRemoveAbility(d,'Arav')
                    call SetUnitFlyHeight(d,ZL,0.00)
                    call UnitApplyTimedLife(d,'BTLF',1.0)
                    if IsUnitEnemy(t,p) then
                        call UnitAddAbility(d,DUMMY_CAST1)
                        call SetUnitAbilityLevel(d,DUMMY_CAST1,l)
                        call IssueTargetOrder(d,LIGHTNING_CHAIN,t)               
                    else
                        call UnitAddAbility(d,DUMMY_CAST2)
                        call SetUnitAbilityLevel(d,DUMMY_CAST2,l)
                        call IssueTargetOrder(d,LIGHTNING_HEAL,t)                
                    endif
                    set i=i+1
                    exitwhen i>4
                endloop
            endif
            set u = null
            set t = null
            set d = null
            set p = null
            return false
        endmethod
        implement Init
    endstruct
endlibrary

:3

edit
Fixed a bug and a compile error xD

Oo there is no any red strings. Red strings - are bad?:В

Looks like GUI converted to Jass.

Yes, Some things I converted, however, not all.




And one other thing:You posting the codes and when i copy it in my test map, it creates only one lightnning, insteed of 5.

 

[mckill2009]

points/locations always leak if not removed/cleared, while coordinates dont leak even if not removed plus it's faster and more efficient...

in JASS, you always start from scratch except if you have templates for it like my spells...

again, DO NOT USE BJ's, but use their natives...

 

[.OmG.]

Ehhm... What about single lightning insteed of 5?

 

[Magtheridon96]

Sorry about that
I fixed it.
It should work now (Check my post)

 

[.OmG.]

Bribe tell me that I`m should make it in GUI, so, I make two triggers one in GUI, and one in vJass(give credits to you).

Is it ok?