Things That Leak

[Silvenon]

I cant sort this out still... does these locations leak:

• Does locations Leak
• Events
• Someone answers this
• Conditions
• Actions
• Set Location[4] = (Center of MerchantSpot <gen>)
• Cinematic - Ping minimap for (All players) at Location[4] for 1.00 seconds, using a Flashy ping of color (30.00%, 100.00%, 100.00%)
• Unit - Create 1 Elementar Master for Neutral Passive at Location[4] facing Default building facing degrees
• Custom script: call RemoveLocation( udg_Location[4] )

.
Or do i have to use the custom script removal twice in the trigger?

I don't know why do people who are answering to these kind of threads always ignore the old question and starts answering the new one, but nvm. This won't leak, don't worry. It's important that you understand why: When you store a location in a variable, and you use that variable later, you're always using the same location.

And Lingonberryjam, please pay attention:

I don't know how forces leak. All i know is (All players) do NOT leak, and if you destroy it, sthg weird (crash or fatal error?) will happen

 

[SamNainocard]

Does

• Set Temp_TargetPosition48 = (Position of XXX)
• Set Temp_TargetPosition48 = (Temp_TargetPosition48 offset by 200.00 towards (Facing of XXX) degrees)
• Do something
• Custom script: call RemoveLocation(udg_Temp_TargetPosition48)

0 Leak or 1 leak?

oh and does

• Unit - Create 1 Footman for (Owner of XXX) at Temp_TargetPosition48 facing 0.00 degrees

at (Owner of XXX) is leak or not?

 

[Diablo-dk]

the first trigger does leak 1 location.

The other one doesn't leak.

 

[PurplePoot]

If you destroy (All Players), from then on it'll be equivelant to ForForce'ing 'null'.

Hmmm... I think destroying a unit group renders it unusable, as my spell that uses a unit group only worked once.

...which is why you only destroy the unit group when you're done with it. If you use another Get Units in blahblahblah, it should work fine again until it's destroyed again.

 

[HamzahA]

what about regions? should we remove them after setting into variable?

 

[PurplePoot]

Not if they preexist on the map. (If you initially placed it)

In general:

-IF A VARIABLE IS SET TO AN EXISTING OBJECT then it should not be destroyed
-IF A VARIABLE IS SET TO A FUNCTION then it should be destroyed.

Exceptions;

-Playable Map Area should not be destroyed.
-All Players should not be destroyed.

 

[Pyritie]

What about Entire Map? I'm guessing the same goes for that too.

 

[PurplePoot]

Nope, actually.

[jass=Explanation]native GetWorldBounds takes nothing returns rect
function GetEntireMapRect takes nothing returns rect
return GetWorldBounds()
endfunction

//vs

function GetPlayableMapRect takes nothing returns rect
return bj_mapInitialPlayableArea
endfunction[/code]

As you can see, Playable Map Area returns a global variable while Entire Map calls a function to create a rect.

 

[HamzahA]

does : "Pick every unit in region and do actions" leak?!!
*the region is an existing object

 

[Razorbrain]

the group leaks, not the region

use

• Custom Script: set bj_wantDestroyGroup = true

 

[HamzahA]

errr

OMG, LAST QUESTION, WHY DOES THIS POINT FUCK MY REGION?

• Set AnotherPoint = (Random point in RegionInPlayableMapArea <gen>)
• Hero - Instantly revive (Dying unit) at AnotherPoint, Show revival graphics
• Custom script: call RemoveLocation(udg_AnotherPoint)

RegionInPlayableMapArea is a region existing on map,
on the 2nd use of the point, ITS REMOVED FOR EVER!

edit: and if i use bj_wantdestroygroup, will it remove the unit?
like pick every unit in area and do : order unit to move there, should i use bj_want destroy group here?

 

[Pyritie]

• Custom script: set bj_wantDestroyGroup = true
• Unit group: Pick every unit in (blah) and do (actions)
  • -------- Actions go here --------

Basically, without the custom script it makes a unit variable for every unit in the region, which obviously leaks. Putting the custom script there forces it to remove the unit variable after it's done using it, which does not leak.

Remember, it's case sensitive!

 

[HINDYhat]

Actually, bj_wantDestroyGroup is just a global boolean that checks after the ForGroup() function. If it's set to true, then the looped group variable is destroyed. If it's set to false, nothing happens to the group after the loop. It's not the picked units that leak, it's the unit group. You could also create a temp_group variable, set it to Every unit in (blah), then do, Pick every unit in temp_group, and then write this as a custom script.

call DestroyGroup(udg_temp_group)

Of course, bj_wantDestroyGroup is alot easier to use, but in some cases, I prefer using temp group variables.

Py, it's impossible to generate global variables, which would leak in this case, but what it does is it gets a return from the GetEnumUnit() function, which returns the picked unit from the looping group. This enum unit is just recycled when you don't need it anymore (after the loop).

 

[Silvenon]

You need to set it every time you're using it (and destroy it in the end), so:

• Set AnotherPoint = (Random point in RegionInPlayableMapArea <gen>)
• Hero - Instantly revive (Dying unit) at AnotherPoint, Show revival graphics
• Custom script: call RemoveLocation(udg_AnotherPoint)
• ......
• Set AnotherPoint = (Random point in RegionInPlayableMapArea <gen>)
• Hero - Instantly revive (Dying unit) at AnotherPoint, Show revival graphics - I'm using AnotherPoint the second time....
• Custom script: call RemoveLocation(udg_AnotherPoint)

bj_wantDestroyGroup won't remove the unit, people often think that destroying a group means killing every unit in it, well, it's not like that. It just destroys the variable that hold the units.

EDIT: Wow, even two people were faster.....

like pick every unit in area and do : order unit to move there, should i use bj_want destroy group here?

Yeah, if you don't want any leaks. If you want to keep the group for something else, then do something like this:

• Set Group = Units in range
• Unit Group - Pick every unit in Group and do...
• .....
• Unit Group - Pick every unit in Group and do...
• Custom script: call DestroyGroup(udg_Group) - HERE you destroy it

 

[HamzahA]

forgetit, i'll make a thread titled : Some Questions
i made much less leaks on the map, but still its REMOVING some regions! check the thread : http://www.hiveworkshop.com/forums/showthread.php?p=344372#post344372

 

[blah900]

is it possible to use the remove location function on a variable with an array?

 

[Razorbrain]

i think so, atleast i use

• Actions
  • Custom script: call RemoveLocation(udg_Location[1])

but im not sure it even works, but it doesnt show up any errors when i try to save

 

[HINDYhat]

Yeah. The array index is inside brackets. Let's say you want to remove some location of a triggering player's ID:

call RemoveLocation(udg_Location[GetPlayerId(GetTriggerPlayer())+1])

 

[Razorbrain]

i just tried the leak catcher(becouse i cant find a couple of leaks, since i learned about leaks after making a lot of triggers in my map)

when i inserted a trigger with

• Custom script: call RemoveLocation (udg_Point)

it said that the Point variable wasnt removed

is it wrong with the Leak Catcher or is it the Custom scripts that shouldnt have a Space between RemoveLocation and (udg_Point)?

 

[Silvenon]

Probably you shouldn't put a space.

Why do you use Leak Catcher anyways? Any program like that suck. You'll learn eventually how to find leaks. If you inserted that in your script, it should be destroyed (well it depends on where you've put it).

 

[Razorbrain]

if you click on the link in my signature, and read the section that is Completely BOLDED you will understand why

 

[PurplePoot]

That space doesn't matter.

And leak checker isn't as reliable as some people think it is.

 

[Razorbrain]

if i understand correctly, if i dont null the variables, the variables also work as leaks, am i correct?

 

[Silvenon]

Only local handles. Null handles in the end of the function, that is the best way.

 

[Herman]

Custom Scripts

Usually with the triggers i use, i like to put it all in one big array

How would i go about removing something like
Example
PointArray(point_number100)

in custom scripts???

 

[Razorbrain]

Is (point_number100) a variable or what?

 

[Herman]

"pointnumber100" being a varying integer

(the 100 i just put in to pretend for a moment that it was set at 100 in the trigger)

 

[valkemiere]

convert to jass, then copy the variables name,
then ctrl z,
add action,
call removelocation(ctrl+v)

 

[Herman]

I don't know JASS

Just a few custom scripts

I wanted to know what the custom script would be to remove the leak for a variable that has a varying index

Such as a variable
RandomPoint(Custom Value of (Triggering Unit))

Is what it would look like in GUI

I'm wondering how i could remove the leak from a variable using that kind of index

 

[valkemiere]

have u try what i say ?

 

[Razorbrain]

when using Custom Value of Triggering unit in a custom script, you must use (GetUnitUserData(GetTriggerUnit()))

and yes, that extra () is necessary

so, here is an example

• Custom script: call RemoveLocation(udg_Point[(GetUnitUserData(GetTriggerUnit()))])

 

[Herman]

sorry valkemiere, at the time I had no idea what you ment

You actually ment "Convert Trigger to Custom Script" in the Trigg Editor
At the time you said it, it sounded like you wanted me to convert off the top of my head ><

I got a little frustrated, so I spent the past three days learning JASS

I now know how to get those GUI custom scripts now, thnx for the reply anyways

I think im gonna stop using GUI and start just using JASS, although I can work about 100x faster in GUI, I'm startin' to really get a handle on JASS, which is the only way to do real systems (such as making physics a part of your own WC map)

 

[valkemiere]

convert to jass, then copy the variables name,
then ctrl z,
add action,
call removelocation(ctrl+v)

first : cr8 variable for ex: set UnitGroup = bla2
second ; like i said before, convert to jass, then see the
"set UnitGroup = bla2", you copy it ("must be udg_bla2") by press ctrl+c,
then ctrl+z ( to back from Jass trigger to GUI trigger)
last, cr8 custom script : call DestroyGroup("ctrl+V here")

Done!!

 

[GhostWolf]

Just put [x] in harrays.

The simplest example is - "call RemoveLocation(udg_location[1]).

 

[Pyritie]

first : cr8 variable for ex: set UnitGroup = bla2
second ; like i said before, convert to jass, then see the
"set UnitGroup = bla2", you copy it ("must be udg_bla2") by press ctrl+c,
then ctrl+z ( to back from Jass trigger to GUI trigger)
last, cr8 custom script : call DestroyGroup("ctrl+V here")

Done!!

That was so hard to follow.

My eyes are burning.

 

[humpadumpa]

incase noone knew.. this will leak:

• Trigger 001
  • Events
    • Unit - A unit Gains a level
  • Conditions
  • Actions
    • Hero - Set (Leveling Hero) Hero-level to ((Level of (Leveling Hero)) + 1), Hide level-up graphics

 

[Razorbrain]

why would it leak?

it would rather create an infinite loop, but it will stop once the hero reaches the maximum level

 

[humpadumpa]

hmm.. i don't think i know what leaking is then heh

 

[Razorbrain]

look at the first page

it is explained quite well there

 

[humpadumpa]

Razorbrain, I know it works for you, it should. Leaks are not whether it's working or not, the full name is memory leaks. It's when (example) you create a special effect at the position of a unit. If that location (the position of unit) is not destroyed, it will stay there and take some memory, so when you create lots of these locations, your map will lag like hell. Imagine it like this, try putting 10000 units on a map and test it, it bet it'll lag because each unit takes some memory, and causes the game to leak. Same for Unit Groups, if you go pick every unit, then WE creates a group so he can do what you said, but if that group isn't destroyed, it will leak.

These are what don't leak: integer, real, boolean, string (in JASS code doesn't leak also)

Blizzard should have made a garbage collector for that, though I'm not sure how that works

http://world-editor-tutorials.thehelper.net/cat_usersubmit.php?view=27242

get it now good explanation.

 

[Herman]

thanks for clearing that up valkemiere

But I guess I wasn't clear enough, I ment that NOW I understand what JASS is
How to use it
How the functions and variables work

And any natives I would need to know I could get from JASScraft

 

[DrazharLn]

It's a new point every time. Points aren't stored the same way as strings/boolexprs.

Think units. If you create 2 footmen, are they the same footmen, just because you spawned them both at (Position of (Barracks)) and they have the same stats/type? No, warcraft creates both footmen, not just one.

I'm sorry but I'm a bit of a n00b at this. I have a script which goes like this in my map:

• Orphan Factory TR
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • OrphanCount[1] Less than 20
      • Then - Actions
        • Set OrphanCount[1] = (OrphanCount[1] + 1)
        • Unit - Create 1 Orphan for Neutral Hostile at (Random point in top generator <gen>) facing (Random point in (Playable map area))
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • OrphanCount[2] Less than 20
      • Then - Actions
        • Set OrphanCount[2] = (OrphanCount[2] + 1)
        • Unit - Create 1 Orphan for Neutral Hostile at (Random point in bottom generator <gen>) facing (Random point in (Playable map area))
      • Else - Actions

Will that leak [don't worry about the variable, I have another trigger that reduces the variable by 1 every time an orphan gets killed]
Or do I have to remove the point(s) every time?

Thanks in advance
DrazharLn

[note: In the map you have to kill orphans for money. Does making/playing this map make me a bad person? ]
[note2: How can you have a problem with killing virtual orphans when you probably spend a lot of time slaughtering equally hapless victims in normal maps [did those creeps do anything to you??? <---- a justification ]

 

[Silvenon]

You have to remove the point every time. Each time you use "position of", "center of", "random point in".....etc. you need to clear them.

With call RemoveLocation(udg_LocName)

 

[DrazharLn]

Thanks verily Silvenon


[edit] Another question: I've converted my trigger to JASS and find the following:

GetRandomLocInRect(gg_rct_bottom_generator)

Should I use

call RemoveLocation(udg_LocInRect)

or

call RemoveLocation(udg_LocInRect(gg_rct_bottom_generator))

I'm thinking number one because I do not need to remove [or mention] the region too.

I'm also getting

GetRandomLocInRect(GetPlayableMapRect())

should I use call RemoveLocation(LocInRect) for this too

[edit 2] how can you check for leaks btw or can you only see the symptoms?

 

[wd40bomber7]

The answer is number (1) You never need to mention anything but the location(point) itself you want to remove.

 

[Silvenon]

[edit 2] how can you check for leaks btw or can you only see the symptoms?

There are stupid leak checkers, but they are unreliable and using those you never learn how to clean leaks.

You just take some tutorials and after a while you'll get it.

 

[Pyritie]

Leak checkers are very helpful though. They serve the same purpose as editors do for authors. Even if you made it you still won't necessarily see all the faults.

 

[Maddawg101]

Heres an example of what I have in my map

Actions
Unit - Create 6 Attacker5 for Player 12 (Brown) at (Center of Center Large <gen>) facing Default building facing degrees
Unit Group - Order (Last created unit group) to Attack-Move To (Position of (Random unit from (Units in (Playable map area) matching ((Owner of (Matching unit)) Not equal to Player 12 (Brown)))))
Wait 45.00 seconds
Set UnitAInt = (UnitAInt + 1)
Trigger - Turn on Spawns2 <gen>
Trigger - Run Spawns2 <gen> (checking conditions)

So this loops around with the other spawning triggers I have in my map where the only thing really changing is the wait time and attacking unit (underlined) with the region changing occasionally (I have 5 spawn points for them)
My map has crashed at least 4 times in a row on bnet at around the same time on my custom timer (about 11 mins in) and I think leaking from
1 unit groups and 2 regions
How can I fix this specifically?

 

[Gausslander]

Toilet seats... sinks... drains... sodas... lots of things leak. You could make a trigger that can fix those from leaking.

 

[Maddawg101]

If I knew that it'd be done by now
My problem is really similar to the sticky post examples but I tried it and no luck