TasInventoryEx

[Elprede]

After testing the system for a bit, I went into some issues.

• When the first grid is filled up and I use the scroll bar to go to the next grid, I get Sammy icons until I move the scroll further.
• If the custom inventory and the default inventory are both full and I free up an item slot of the custom inventory, I can't pick up an item because the default one is full.

A suggestion: Perhaps, provide a button to display more than one row at a time. Even though there is the scroll bar and your other system sort of fills the niche here, this feature could potentially make the viewing of items more pleasant.

 

[Tasyen]

Updated Post and System to V1.1)
inventories are now made permanent, which fixes problems with morphing heroes.
Recreated Items now copy: Charges, Invul, UserData, Player, Life

A suggestion: Perhaps, provide a button to display more than one row at a time. Even though there is the scroll bar and your other system sort of fills the niche here, this feature could potentially make the viewing of items more pleasant.

Can't you just change the Rows/Cols values in the systems data? They define the amount of buttons.

When the first grid is filled up and I use the scroll bar to go to the next grid, I get Sammy icons until I move the scroll further.

Can you tell a bit more about this?

Edit: Updated to V1.2)
Items carried before getting TasInventoryEx are now added to TasInventoryEx, before they were unreachable.
Using an item checks for broken items removes them

Edit: Updated vjass to V1.2a)
optional works without table (lighter version, but takes a hashtable).
Fixed a reference leak to an item in function RemoveIndex.

Edit: Updated to V1.3)
Filters now items that are destroyed (ItemCode <= 0) inside the item gain event. Previously they were added as broken item into the inventory UI

Edit: Updated to V1.3a)
Moved the removed Item Filter to the top of the gain item function
Removed the ItemUse check and use the Drop event instead
Fixed additional Inventories after Revive, does not Include Reincarnation. Sadly the last inventory items will droped after revive, if an unit has to many items.

 

[Ericqwe]

Can you duing a ver. For warcraft 1.26

 

[Tasyen]

Can you duing a ver. For warcraft 1.26

I can not create custom UI in Warcraft 3 V1.26. Some can, but I do not.

I could make a version in which an additional unit replaces the custom UI. It would show 1 inventory Page and has abilities to navigate the current page & move item of the current page to the main inventory. A little bit clunky as one than moves selection but would not require any item specific data (which is the idea of this system works with default items).
Should work in default warcraft 3 V1.26, without any hacks/3.Party additions.


Updated to V1.3b)
Now keeps working after reincarnation.

Edit: Added the Warcraft 3 V1.26 Version, (normal jass). Instead of CustomUI there is an Unit with abilities and a preview inventory.

 

[Tasyen]

The game does something quite unexpected:
Warcraft 3 returns rubbish when using GetUnitAbilityLevel onto a inventory skill (at least in V1.26 and V1.31.1). I check for inventory (Hero) > 0, unit has inventory (unit, human) and the game says that is fine and gives the unit the inventories.
Edit: It seems to be only rubbish for the inventory(Hero) 'Ainv'.

Edit: Updated to V1.3c)
Works now only for Heroes, because the inventory Skill check is buggy.

Edit: Updated to V1.4)
Added a function ValidUnit(unit) to filter out unwanted users.
On default now units of Players that can not be real players are excluded (like Neutral Hostile, Neutral Extra..).

 

[KitsuneTailsPrower]

Nice job! I thought this was impossible. One small criticism: In the demo map the footman still has the bag icon despite not being a valid unit according to the filter. I tested it with a unit with no inventory, a phoenix, and it doesn't show the bag icon which is normal.

edit: Found another bug. If a hero dies with 18 items they lose/drop (?) 6 of them upon reviving. To reproduce, pick up items until no more can be carried,then kill the hero. I tied commenting out the reference to the 2nd inventory skill and items were still lost so I suspect it has to do with a loop.

edit2: Please test the revive hero actions more. They are very glitchy right now. I was testing on the JASS version. It seems the items are dropped at the hero's feet during revival not deleted.

 

[Tasyen]

Ty, for your feedback.
Hiding for non heroes is easy to do.

I am stuck with how I would fix the revive problem.

fixing that revive glitch is not so easy. Problem is that after revive the multiple inventory feature breaks. And hence the inventories have to be removed and readded. But here one also has to be careful because when one just readds all inventories the inventory grows, then the hero could carry 6 items more after each revive/reinc.

Currently I add items than add a skill to move them into the next page, but it seems that InventorySkill[0] somehow breaks and has 0 Size until InventorySkill[1] is regained. Which means the hero will drop 6 items after revive/reinc.

Edit: Updated to V1.4a.
The Bag Button will only show when the unit is a ValidUnit.
(vjass) Fixed a bug with reincarnation not readding inventories. Also for vjass in the V1.26 map.

 

[KitsuneTailsPrower]

The current version desynchs very easily, Please fix. If you load the map in LAN mode with 2 players and select a few different units including the heroes and the footman with the host player 2 will get disconnected.

 

[Tasyen]

Updated to V1.4b)
Should fix the mp desync.

I forgot to reserve a handleId for BlzGetOriginFrame(ORIGIN_FRAME_ITEM_BUTTON, 0) which was called in the update timer when the current local player selection was valid for TasInventoryEx.

 

[KitsuneTailsPrower]

Seems to work fine now. Thanks for the great system ( :

 

[Tasyen]

Updated to V1.5)
ShowButton can close the UI when clicked and the UI already was shown ( can be enabled/disabled async)
// showButton closes the UI when clicked while the UI is shown?
public boolean ShowButtonCloses = true

TasInventoryEx.ShowButtonCloses = false

 

[Sakata Gintoki]

It seems pauseunit can cause bug on this system

 

[Tasyen]

It seems pauseunit can cause bug on this system

Thanks for your feedback.
One has to do the same as after revive/reinc.
Right after you unpause the unit tell the system to readd the inventories and items. Otherwise the unit can only fill the main inventory with items (no more additional inventories).

vjass
call TasInventoryEx_ReAddInventories(unit)

Lua
Can't do that right now as there is no external access to ReAddInventories(unit).

Edit: It also happens when an unit uses a channel abiliy with "disable other abilities" enabled.
Edit: And even for Doom. Probably for all skills/situations that silence inventories.

 

[Izzetin]

awesome! i'd love to use it!
but its a bit weird if your Heroes Normal Inventory is full but you have space in your ''bag'' it says that you cant pick up the item because ''Inventory full'' so you have to rearrange your whole inventory - to bag - from bag - to pick up the new item

 

[Tasyen]

well the system works with a wonky sideeffect of many inventories. The inventory in the UI needs atleast one empty slot to be able to pick up more items.

 

[Droof]

Is there a way to set it so that it fills the hero inventory first, then starts to fill the "bag" when the hero's inventory is full?

 

[Tasyen]

I did not made a way.

 

[Droof]

Ok, also do you know why items are not stacking when I pick up the same stackable item type? It will create 2 copies instead of stacking and when I click on it, it will add the correct item stack to inventory but it will turn into the placeholder "sammy" icon on the bag

 

[KitsuneTailsPrower]

Ok, also do you know why items are not stacking when I pick up the same stackable item type? It will create 2 copies instead of stacking and when I click on it, it will add the correct item stack to inventory but it will turn into the placeholder "sammy" icon on the bag

Perhaps the fix for this lies in the EVENT_PLAYER_UNIT_STACK_ITEM event? edit: I meant this as a suggestion for Tasyen, not a do it yourself way to fix it.

edit2: See if this tweak fixes it. I changed the line right below the comment and enabled item stacking in gameplay constants for testing.

 

[Droof]

Yes that works, thank you!

 

[Droof]

Is there a way I can restrict certain items from going to the tasinventory?

 

[Tasyen]

Not built in. you could try: when an item is picked up, destroy it, then disable the secondary inventories and create a new clone of the item and give it to the unit.

this.AbilityFieldSize = ConvertAbilityIntegerLevelField(FourCC('inv1'))
for i, v in ipairs(this.Indexes) do
    abi = BlzGetUnitAbility(unit, this.InventorySkills[v])
    BlzSetAbilityIntegerLevelField(abi, this.AbilityFieldSize, 0, 0)
end
UnitAddItem(unit, newItem)
for i, v in ipairs(this.Indexes) do
    abi = BlzGetUnitAbility(unit, this.InventorySkills[v])               
    BlzSetAbilityIntegerLevelField(abi, this.AbilityFieldSize, 0, 6)
end

 

[KitsuneTailsPrower]

I found something useful:
Making the inventories unsilenceable via "call BlzUnitDisableAbility(u,InventorySkills[loopA],false,false)" makes them not glitch out when you are hit with certain spells. I've only tested hex so far but this is an improvement

You add the above line whenever you are adding the inventory skills via UnitAddAbility

 

[Produtor]

Is there a way to save the items in this inventory?

Where are these items, on the heroes or on dummy unit?

If it's a dummy unit, can I store it in a variable and save its inventory with Codeless Save and Load?

 

[Tasyen]

the items are inside the heros inventories, the system keeps data of them.
In the Lua version TasInventoryEx[unit][1 to x] are the items.

Jass depends if you have LIBRARY_Table in the map or not. I am not sure how this structs work in vjass.
you probably need to make the struct public and then find out how to access it.

 // Mode without Table
    private struct data extends array
        static if LIBRARY_Table then
            public static HashTable BagItem
        else
            public static hashtable Hash
        endif
    endstruct

 public function AddItem takes unit u, item i returns nothing
        local integer unitHandle = GetHandleId(u)
    static if LIBRARY_Table then    
        set data.BagItem[unitHandle].integer[0] = data.BagItem[unitHandle].integer[0] + 1
        set data.BagItem[unitHandle].item[data.BagItem[unitHandle].integer[0]] = i
    else
        call SaveInteger(data.Hash, unitHandle, 0, LoadInteger(data.Hash, unitHandle,0) + 1)
        call SaveItemHandle(data.Hash, unitHandle, LoadInteger(data.Hash, unitHandle,0), i)
    endif
    endfunction