Talent/Skill Tree 1.7

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

By default you're creating 18 hashtables, which is unacceptable.
One can "only" have 255 hashtables in a map, and if every system used that many problems would occur.
Try to use only one hashtable.
I also spotted some leaks in Talent Hover trigger.
Improve the test map, it doesn't showcase the system enough.

Old review

14:40, 19th Aug 2011
Bribe:

You code can be improved:

You use arrays like DeathPos for just two indices, should be two
variables instead. Same with the TalentPosHashtables array which
could be three variables. This cuts on array space which is obviously
important for readability, map file size and memory usage in-game.

Yes I know you use a loop for the hashtables that's what makes JASS
so good because you can use functions for this instead of copping out
for an array. If you don't want JASS there are workarounds anyway
but should not use an array.

I have no idea how to use this the documentation does not explain
what talents are nor does it explain how to customize the script. For
example why do you do "Set X = 35" in the main trigger it doesn't
have any exclusiveness. Stuff like this needs way better comments
and variable names.

 

[Pharaoh_]

Upload the triggers in the main post.

 

[Kanadaj]

Ooookay
EDIT: Done
EDIT2: Well yeah documentation needs some more specific details ^^ It still has some problems with customization since you can change the maximum rows/columns in a tree, but when I tried expending it my WE crashed

I named it X because I use it as a helper variable, and I use it in loops too so I can't name it any better

I'll change the DeathPos to a normal variable ^^

 

[Asip]

If approved Ima use it.

 

[Kanadaj]

I'm constantly updating it, extending the Documentation, fixing bugs and extending functions

 

[Asip]

Okay. Now this is normal triggers right? Not jass, or those scripting languages?

 

[Kanadaj]

Not at all
But triggers are posted so you can check it yourself

 

[maddeem]

I think i can safely say that this puts all other talent/skill tree systems to shame, including my own xD

 

[Kanadaj]

Hehe ^^ I worked with it I think a day (or two? Oo My sense of time is a bit blurry without school ). I'm waiting for a new moderation - I think now after I updated it could be approved ^^

 

[EvilCrizpy]

Hehe ^^ I worked with it I think a day (or two? Oo My sense of time is a bit blurry without school ). I'm waiting for a new moderation - I think now after I updated it could be approved ^^

Looks alot better;

Improvements

- Maybe add the description of the talent being learned
Instead of jsut the name;
- Maybe make a floating text at the bottom of the talent screen showing your talents; instead of using food; cause food could be used for something else in some maps.

 

[Kanadaj]

Well I could do that (the variable thing), thanks for the feedback, +rep ^^ And it has description implemented

Edit: how can I update the screenshot? Oo

 

[EvilCrizpy]

Well I could do that (the variable thing), thanks for the feedback, +rep ^^ And it has description implemented

Edit: how can I update the screenshot? Oo

As i mentioned not reallyy got chance to test it properly; since updates... and cheers.

when you update it says Upload Picture;
sometimes the picture takes ages to replace the old one, well i have noticed;

 

[Kanadaj]

Now it's the new one

 

[Foronisus]

Kanadaj just my suggestions make the description inside a rectangle it will be better

 

[Kanadaj]

Making a rectangle out of nothing is really hard I could generate destructables but its not easy. I'll think about it

 

[EvilCrizpy]

Here a little suggestion;
Try and revamp the whole Wow Talent System; cause from my point of view
on world of warcraft i thought it was quite ugly;

i personaly like ones that go across for example;

---------- Talent -Talent -Talent -
---------/
Talent -Talent -Talent - Talent -
---------\ Talent \ ----------------\Talent -
----------- Talent -

Yes i know that is abit messy;
but then you can create more area for the description to be shown, in a different
rectangle.

 

[Kanadaj]

Not at all, since the point is you can have 3 separate trees-that way there would be space only for 3-and making it to work as tabs would make me remake the entire thing but a lot difficultier - even it's setup would be a pain by itself. I've beeon tough about the window thing, and I may be able to make it if I can get a proper model

 

[EvilCrizpy]

Well the way you got it layered out at the moment in wc3 looks fine;
Maybe do with some improvements; cause personally i dont like the effect
that links between the talents.

 

[Kanadaj]

That would be only solvable with a custom lightning effect, only usable by custom script And I still need a white arrow thingy for that purpose

Well, I added a variable to be able to remove a great column (or even add one with correct camera settings, but for that you have to edit the init trigger's first section a bit) - even I got surprised that I didn't have to edit the code as at the moment it is dynamic enough that by changing only the integer number of the main loop makes it possible to completely ignore a column

 

[Foronisus]

yea i think it will be really good it will be like Wow one and yes can you make to choose??? lets say if he wants combat to click on it and click Asept and he can train only Combat Talents.

 

[Kanadaj]

Found a bug in adding skill points - Now I'm correcting it
Also I'm working on an add/remove skill button so that even if you have 20 of them unlocked you can still select which ones to use - but I can't use hashtable for this which makes it hard

Is there any jass way to get the string of an ability (the game ID) from a variable and to transform it back to a variable? It'd help me ^^

EDIT: Made a HUGE update, if anyone has an earlier version, please DL the new one. I fixed all the bugs so far and arranged the things so you don't need to touch any of the other triggers except the settings - the system dynamically alligns to the changes you make (well don't change the shape of the squares nor the size, that's something which I don't want to waste time on )

 

[AyeKantSpel]

Gonna use it nice job.

 

[Magnum666]

Think in Future

by the way WOW Death system is more like Projectileing the Hero Death Itself untill the Soul go back to him or Ressed by spirit healer , i aint gonna teach you how to do all of that because its pointless and verry simple im just
gonna show you what it wont be bad to be done on your next update of the System Tree ( i made it in your own Death System , its that you just missed few things ) and thats what im gonna show you now as Example
EXAMPLE :

• Unit - Create 1 (Unit-type of (Dying unit)) for Neutral Passive at DeathPos1 facing (Facing of (Dying unit)) degrees

• Set DiedTempUnit[(Player number of (Triggering player))] = (Last created unit)

• Animation - Play (Last created unit)'s death animation

• Unit - Make (Last created unit) Invulnerable

\\\====("DiedTempUnit" is:
______________________________________
|Variable Name|Variable Type |Initial Value |
| | | |
|>DiedTempUnit|> Unit Array (1) |> -none- |
--------------------------------------------
...)====///



THIS IS ONLY FOR !!ONLY!!ONE!!HERO!!PER!!PLAYER!!

• (Unit-type of (Triggering unit)) Equal to (Unit-type of DiedTempUnit[(Player number of (Triggering player))])

 

[maddeem]

Uhh it doesn't work...
Cannot learn abilities, nor do I understand you "WoW" revive system.

 

[Kanadaj]

Well the system recogizes abilities but i only added one. Death system is symple when a bero dies he gains a spirit at the nearest unit representing graveyards

 

[Magnum666]

maddeem you cannot Learn Abilitys because you need to have the hero Already in game or Otherwise sayed it should be more like!!!!!!! Set HEROES(1) = Paladin0027 !!!!!!!!!!
that is Example it could be any Unit like :
Set HEROES(2) = Dreadlord0008
the Numbers after the Name of the Unit is Declaired by WE ( Warcraft Editor ) When it was Created that Unit on the Map or you need to Upload you Pictures how to do it
and the Triggers i Posted , i Posted them for People who Already know How the System Works because the First Group of Triggers i Posted must go in "Unit Dies" - Trigger
and the Last one Must go in Conditions in "Resurrect Hero" - Trigger
thats all to Have Real WoW Revive System Because he made it When the Hero Dies to Create "TombStone" - Object Floating Overhead in the air <.< and you really want me to Believe , The Way i make it , When the Hero Dies it Automaticaly Create a Second Hero that Looks Like the First One at the Same Point of Death Which the Second One is Controlled by Neutral Forces which cannot be touched , when he is playing Animation in "Invulnerable" he cannot be attacked or Forced to do Whatever to Interrupt the Death and here it comes the Tricky part He Also Plays the Role of Animation and Object , b-cuz when your Hero Comes to him He Can Ressurect all this Here is Contained in 4 Lines of GUI Script Without any CUSTOM Scripts i Found that GUI is More Usefull then Jass But not so Correct if you dont know how to Make it

By the Way you Rock Maaan I Mostly Like how you made it with /--\Player Class - Talent Class/--\ Which i could Change at Any Time of Game Thanks for that Bro
And Keep up Da Spirit

Bro i wanna Ask you something Verry Important Can you make the System Work with Multi Specialization Example Spec1 and Spec2 to Switch Fast and if you can to show me How To Make Adding the Abilitys to Spellbook For Faster, because i will have to spend hour or two to make your System Work with the book because i dont know it Perfect so Far but i discovered already few WHOLES in your Sys , thats b-cuz im Experimenting as ussual hahahaaa

 

[Kanadaj]

by the way WOW Death system is more like Projectileing the Hero Death Itself untill the Soul go back to him or Ressed by spirit healer , i aint gonna teach you how to do all of that because its pointless and verry simple im just
gonna show you what it wont be bad to be done on your next update of the System Tree ( i made it in your own Death System , its that you just missed few things ) and thats what im gonna show you now as Example
EXAMPLE :

• Unit - Create 1 (Unit-type of (Dying unit)) for Neutral Passive at DeathPos1 facing (Facing of (Dying unit)) degrees

• Set DiedTempUnit[(Player number of (Triggering player))] = (Last created unit)

• Animation - Play (Last created unit)'s death animation

• Unit - Make (Last created unit) Invulnerable

\\\====("DiedTempUnit" is:
______________________________________
|Variable Name|Variable Type |Initial Value |
| | | |
|>DiedTempUnit|> Unit Array (1) |> -none- |
--------------------------------------------
...)====///



THIS IS ONLY FOR !!ONLY!!ONE!!HERO!!PER!!PLAYER!!

• (Unit-type of (Triggering unit)) Equal to (Unit-type of DiedTempUnit[(Player number of (Triggering player))])

For normal units it would maybe work, but for units like the Lich who has no normal dead animation it'd screw it up ^^

 

[Magnum666]

that was Example but you can always avoid it with one

IF
Lich and Dreadlord or Undead Rider
THEN
play common
ELSE
play death
(thats the lazy way)

there are many , many other things that you can use to avoid that
you know , but after all it's example b-cuz nothing is perfect

and btw please if you can, comment sirious things about my Examples, its no needed to talk something that most people know

 

[Kanadaj]

The system is still buggy, I'm working atm to fix it

 

[Deuterium]

some system this is

 

[Kanadaj]

Heh thx i updated the map so i think it works now. If u tried to implement update systemon and buttom triggers

 

[Marsal]

Such a nice stuff you got there. Finally a nice(and long O.O) talent tree written in GUI. As soon as I can touch my own map, I will use this cutie. But what if I only want 2 of the big columns? So I only want the Bloodthirst and Combat columns.

 

[Orcnet]

this is interesting and useful at the same time, in GUI version XD

 

[Kanadaj]

Such a nice stuff you got there. Finally a nice(and long O.O) talent tree written in GUI. As soon as I can touch my own map, I will use this cutie. But what if I only want 2 of the big columns? So I only want the Bloodthirst and Combat columns.

There is a variable currently set to 3, but if you set it to 2 it won't use the 3rd big column ^^ I've already prepared for questions like that ^^

 

[Marsal]

Glad to hear that ~.~

 

[fullmetal1288]

Not working

I try to open this in newgen we and says a bunch of hash tables are missing. There an extra tool you need to use this?

 

[Kanadaj]

I don't think so... It's purely GUI, so it should just paste all the hashtables... If opened it should work - it works for others I think

 

[totusieudn]

I have seen your picture in main post.but i cant see ability like it.i'm try to learn skill but the hero cant learn it

 

[Kanadaj]

The hero may not be able to learn them because I didn't implement any abilities if I remember well, maybe only the first one. So you can only learn them if you link them with the system. From that point it should handle it. Just remember to have at least the same number of levels for the ability if not more than the talent's levels

 

[totusieudn]

Sorry! Can you implement abilities like main picture and can learn abilities from talent to my hero . This is a great system and i very like it . Thank you !

 

[Deleted member 177737]

I just downloaded and tested this...

Bugs:
-When I selected a talent no points were added.


Suggestions:
-Remove the need to click on the tombstone to resurrect, there should be a check to see if the ghost is within say 50 radius of the tombstone. If the unit is within 50 then resurrect the hero.

 

[Kanadaj]

The way the tombstone works was a request, otherwise i could've just done it that way. Also, what do you mean by no talent point added?

BTW I cant edit the file right now as I cant seem to find my WC discs and I reinstalled my Windows

 

[Deleted member 177737]

Well you select the talent in the talent tree and no point is added, basically nothing happens.

 

[Kanadaj]

Did you click on the blue sign? Every talent has 4 buttons:
"blue" = add point
"green" = subtract point
"+" - teach hero (if an ability)
"-" - remove from hero
Hmm.... Maybe I should switch them?

 

[Deleted member 177737]

Did you click on the blue sign? Every talent has 4 buttons:
"blue" = add point
"green" = subtract point
"+" - teach hero (if an ability)
"-" - remove from hero
Hmm.... Maybe I should switch them?

I'd make them more noticeable, I went in that menu 4 times and never saw those.

 

[Kanadaj]

Yayoi, you are some kind of miracle, as you're the first to go over such a thing xD When I made those I didnt have the knowledge to use left/right clicking on the icons efficiently. Although now I know trackables are capable of that, I kinda stopped working with WC3. I sometimes take a look at the Idea Factory, but thats most of what I do.

 

[bhusta]

I have the same problem as Yayoi.

 

[Deleted member 177737]

=P It helps if you check out your old stuff once-in-awhile, you can always improve things.

 

[Kanadaj]

I know, but I stopped playing/modding WC3, and I don't even know where my disc is, and in fact, I'm not even sure I want to go back to WC3 at all, maybe when I've finished my matura which comes this year. I'd really appreciate if someone would be so kind to edit this map, merge the hashtables and place right/left click control instead of the current one :3