Sword Expert v1.02

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

Bribe:

Custom script: call DestroyGroup(bj_lastCreatedGroup)

This line needs to be removed as it will break a million things that depend on it. bj_lastCreatedGroup is never destroyed or re-created, and needs to be kept that way. What leak did you think you were cleaning with this?

Maker:
I think 0.05 period is too low for this, and you should turn the looping trigger initially off. Turn the looping trigger off when the group is empty.
Saving the unit's handle for itself is useless.

 

[Vehster]

Seems fine to me, I can't find anything wrong as well I dislike hashtables... should of used indexing but owell.

The only thing I can see wrong is your event that triggers everything which is when a unit is attacked, you should replace it with a unit is damaged.
Otherwise people can spam the stop command.

 

[illegalpie]

Seems okay, but It's pretty simple. Nevertheless, can be useful.

 

[Adiktuz]

You need to learn how to use a Damage Detection System as the event that you are using is abusable...

 

[Vehster]

Why do people repeat what is already said?

Well I fixed it for you as long as you don't mind, I will keep it there for you to download and read and hopefully update your spell.

 

[Vorgh]

Updated.
Now uses damage detection, thanks to Vehster.

 

[Nightmare Moon]

Now it looks a lot better! BUT you could add few variables into trigger "Sword Expert Init" as settings. Like setting maximum stat limit, how much you steal per hit, what stat to steal; well you know, make it more configurable! I love the spells that are easy to configure, as anybody else i guess.
4/5 since it's not so original!

 

[Marcos DAB]

+ Codes seems fine.

- Originality.

 

[Adiktuz]

You should find a real DDS, coz your current set-up will leak events when a unit dies, coz the event will stay...

 

[Vorgh]

Updated to 1.02.
I removed the Custom script: call DestroyGroup(bj_lastCreatedGroup) line and made a changelog in the description.

 

[aider]

Shouldnt this spell refresh every time it hits? 10 sec after the first hit, it starts draining faster than you can build up, so you never really get max stat bonus.

Maybe it should fade away fast after 10 sec out of combat?

 

[Vorgh]

Shouldnt this spell refresh every time it hits? 10 sec after the first hit, it starts draining faster than you can build up, so you never really get max stat bonus.

Maybe it should fade away fast after 10 sec out of combat?

Yeah, it's a great idea, a lot better than the current version, thanks for sharing it.
I will update it in a few days.

EDIT: Okay, I can't make it like that.