Storm's Call (v1.4)

[Moderator]

Approved

Suggested changes:

• Use only one tree checker unit throughout the game, don't kill it
• Make Integer A loop count configurable

Old reviews

Required changes:

• Set the dummy's death type to Can't raise, does not decay in object editor
• The unit group is destroyed too early by placing Custom script: set bj_wantDestroyGroup = true before Set SC_Count = (Number of units in SC_Group)
  The spell won't work. Move the bj after the number of units thing.

Suggested changes:

• You could store picked into a variable in the unit group loop, and use the variable
• The grammar in tooltip could be improved
• Make Integer A loop count configurable

12:21, 10th Jan 2013
Magtheridon96:

• You don't need the "A unit dies" trigger. You can set the death time of the dummies to 0.00 seconds. Maker and I were discussing the leakiness of this thing, and it turns out, no matter what you do, unless you remove the unit, it will remain depending on its death time. You are free to stop creating these types of triggers. Just set the death time of the dummy to 0.00 seconds. I was wrong all these months.
• Set SC_Caster = No unit <- You don't need this line.
• Inside the loop of the Cast trigger, you can cache the (Last created unit) directly after you create it to avoid repeating the function call multiple times.
• Excellent configuration you got there.
• Set SC_Count = (Number of units in SC_Group) <- You should not do this inside the Group enumeration loop. Since the number of units will remain constant through each iteration, you should do it outside the loop:
  
  Example

  Set SC_Group = (Units within SC_AoE[SC_Level] of SC_Loc matching (((Matching unit) belongs to an enemy of (Owner of SC_Caster)) Equal to True))
  Set SC_Count = (Number of units in SC_Group)
  Unit Group - Pick every unit in SC_Group and do (Actions)
  Loop
  blablabla[/trigger]

 

[Maker]

You don't need the "A unit dies" trigger. Adjust Art - Death time instead.

 

[Wrda]

Looks like a fine spell. Just looked at screenshot didn't test.

 

[Almia]

In the configuration,dont put the for each integer a,this will make the configuration harder.Just put plain variables like:

set real[1] = 0
set real[2] = 0

for much easier.

you dont need to post my system,just link it.

Create the ground sfx using for each integer loop

 

[Losam]

Thank you, I'm working on the next version to correct these errors. I hope the moderator evaluate my spell as fast as it can.

 

[Almia]

Btw,turning a global variable to null doesnt leak.

and you need a dummy removal

 

[Losam]

Btw,turning a global variable to null doesnt leak.

and you need a dummy removal

Well, I use a trigger (Storm Call A Unit Dies) to remove the Dummy (observed my codes). But the moderator (Maker) said it is not necessary.

 

[edward3500]

Excellent