Static Charge v1.3

Moderator · Jan 31, 2014

22:25, 9th Feb 2014
BPower:
Required changes made and overall good coding.
Approved.

Malhorne · Jan 31, 2014

Reserved~

I'll change the screenshot as soon as I get my computer back :s

IcemanBo · Jan 31, 2014

Yo Malhorne, nice credit list you got there! ^^

You're using MoveUnitX/Y and this causes some unwilled situations for me.

I changed test map a bit and I was able to push units over cliffs, into buildings, into water, and yes also into deep water.

Please make some kind of pathing check before you move units.

For spell itself... I really like the concept, man! I especially enjoyed the spell where you cast on a point and pushes all enemies away. This can be nice support to help nearby units which have low life, for example. :csmile:

Malhorne · Jan 31, 2014

Ah yes I think I'll include some IsTerrainPathable library in the next update

Anyway thanks for the reply and I'm glad you liked it

EDIT : Wanted to include BoundSentinel but that's not enough xD And at last I include nothing that's why ^^' My bad xD

Rheiko · Jan 31, 2014

i almost died because of reading the credit list ._.

Malhorne · Jan 31, 2014

Glad you didn't die thou

IcemanBo · Jan 31, 2014

What I forgot to say in my first post:

In my test map I created some big chickens. I tryed to push them, bud sadly it didnt work. :<

So I would also make it configurable to cast on neutrale passive, as well

Malhorne · Jan 31, 2014

See the function Filter

Change IsUnitEnemy to not IsUnitAlly

BPower · Jan 31, 2014

Great tooltips.
I don't see a benefit in the textmacros in Expulse, because you only need them once.
GetUnitDefaultPropWindow(this.targ)*bj_DEGTORAD I will test this myself later, I know you told me it works flawless.
The code itself looks good on a first impression.

Malhorne · Jan 31, 2014

There isn't a benefice but at start I used the same for every spell
But then I forgot that those spell could be separated xD

Malhorne · Feb 1, 2014

Updated !

v1.0 : Initial release

v1.1 : Added TerrainPathability

TriggerHappy · Feb 2, 2014

I haven't had a chance to test it yet but here's some comments

The screenshot needs to be fixed.
You don't need to comment the UnitAlive declaration, JassHelper handles it correctly (vexorian's at least).
The Aloc textmacros could possibly be a modules (thus being private). The name should at least be a bit more unique. Although I think I would prefer the standard allocation.
Preloading should be optional.
You should be using GroupUtils's ENUM_GROUP instead of creating 4 groups for each variation.

Malhorne · Feb 2, 2014

- Yes but I can't use my computer atm I'm truly sorry for the screenshot :/
- Vexorian's bug on UnitAlive.
- Inline is 55% faster so textmacros>modules
- What about preloading

?
- I hate using other resources and just for this ...

TriggerHappy · Feb 2, 2014

Malhorne said:
Vexorian's bug on UnitAlive.

What bug? The map optimizer works perfectly fine with UnitAlive and so does JassHelper.

Malhorne said:
Inline is 55% faster so textmacros>modules

Modules are basically text macros, why don't you compile and see.

Malhorne said:
What about preloading ?

It should be optional with static if's.

Malhorne said:
I hate using other resources and just for this ...

Static if's.

Malhorne · Feb 2, 2014

If you declare multiple times UnitAlive it throws an error.

I inline my allocation in the function whereas Alloc module is a function so calling it is slower....

I don't get why ?
It is always better for the sake of the spell that I preload :/
But if you think it is necessary why not.

I won't use other people resource as usual.

BPower · Feb 2, 2014

If you declare multiple times UnitAlive it throws an error.

Just with Cohadars JassHelper. Vexorians is totally fine with it.

Malhorne · Feb 3, 2014

Yes but some people (like me) use Cohadar's for speed

EDIT : Sorry I said Vex instead of Cohadar before :/

BPower · Feb 5, 2014

All spells share the same textmacro, hence you will do the following:

JASS:

    //! textmacro_once STATIC_FIELD_ALLOC
        if thistype(0).prev == 0 then
            set count = count + 1
            set this = count
        else
            set this = thistype(0).prev
            set thistype(0).prev = thistype(0).prev.prev
        endif
        if thistype(0).next == 0 then
            call TimerStart(period, FPS, true, function thistype.periodic)
        else
            set thistype(0).next.prev = this
        endif
        set this.next = thistype(0).next
        set thistype(0).next = this
        set this.prev = thistype(0)
    //! endtextmacro

Similar to library_once the textmacro_once allows you to declare the same textmacro name twice, it would just ignore the second declaration and avoid to add its contents instead of showing a syntax error.

- Preloading could be optional, because it consumes extra time while loading the map.
- The tooltips are horrible.
- The screenshot is horrible.
- Overall good coding.
- SpellEffectEvent could be optional.

Malhorne · Feb 5, 2014

Oh I didn't knew the trick of textmacro once thanks

Ok for preloading.
Computers at school seem to have gimp so normally the picture could be resized during the week.
Thanks.
I won't as usual xD !

EDIT :

BPower said:
Great tooltips.

Why changing your mind after xD ?

BPower · Feb 5, 2014

It was ironic. Wasn't that obvious?

Malhorne · Feb 5, 2014

Ah sorry didn't understand....
I'm still not english sorry :'(
Anyway I'm still getting stuck with any pictures software and can't have one for the moment so I'm deeply sorry for the screenshot...

Malhorne · Feb 9, 2014

Updated !

v1.0 : Initial release

v1.1 : Added TerrainPathability

v1.2 : Added textmacro_once

BPower · Feb 9, 2014

You re-named the textmacro and now it won't mess with others, also Textmacro_once is a solid solution.
GetUnitDefaultPropWindow(this.targ)*bj_DEGTORAD) --> I tested it and it seems to work.

Required

In here something is very wrong. You check Pathability for tx/ty but move to x/y.
In any case I would recommend to keep the cos/sin member. Now either use local x/y or the tx/ty struct members. You have this block in all 4 spells.

JASS:

                set this.tx = this.tx+this.x
                set this.ty = this.ty+this.y
                set x = GetUnitX(this.targ)+this.x
                set y = GetUnitY(this.targ)+this.y
                if IsTerrainWalkable(this.tx, this.ty) then
                    call MoveLightningEx(this.light, true, this.cx, this.cy, this.z, this.tx, this.ty, this.z)
                    call SetUnitX(this.targ, x)
                    call SetUnitY(this.targ, y)
                endif

The lightning should be created and move relative to the units height. Currently it's working well for ground units, but not for type flying (check with a gryphon rider)
or units which change their flyheight during the spell.

Optional

The lightning is not associated to the caster, but to a fix point --> It doesn't move with the caster.
The optimal concept is of course a personal preference, so your way is totally fine aswell.
The tooltips are lacking in all spells, you could use the blizzard standart tooltip as template.
Could use optional SpellEffectEvent (I know you won't do this one)

Malhorne · Feb 9, 2014

I'll change the pathability (added them while in class was a bad idea) now.
For the unit I'll see now too.

For the lightning I added follow through time because I wanted this spell to be channeled ^^

Updated !

v1.0 : Initial release

v1.1 : Added TerrainPathability

v1.2 : Added textmacro_once

v1.3 : Fix bug with flying height of units

Deleted member 219079 · Jul 25, 2014

Your struct handling is beautiful ! no homo !

Could use optional SpellEffectEvent (I know you won't do this one)

Lol

I have suggestion ; make the attract spell to be targeted at point with a maximum range of 800 or something like that. Then according to the dist from caster to cast point, you calc the aoe and damage. The bigger the aoe, smaller the damage. Like this:

JASS:

...
private function Pythagoras takes real x, real y returns real
    return SquareRoot(x*x + y*y)
endfunction

private struct vec2
    real x
    real y
endstruct

private function vec takes real whatX, real whatY returns vec2
    local vec2 v = vec2.create()
    set v.x = whatX
    set v.y = whatY
    return v
endfunction

private function V2V takes vec2 v1, vec2 v2 returns real
    return Pythagoras(v1.x-v2.x, v1.y-v2.y)
endfunction

private constant function minDmg takes integer lvl returns real
    return 50. + 50.*lvl
endfunction

private constant function maxDmg takes integer lvl returns real
    return 150. + 50.*lvl
endfunction

struct
    private static real aoeDmgRatio = 0.3 // how much the aoe reduces dmg
    ...
    private static method onCast
        ...
        local vec2 cPos = vec(GetUnitX(caster),GetUnitY(caster)) // castvec
        local vec2 tPos = vec(GetSpellTargetX(), GetSpellTargetY()) // targetvec
        local real dist = V2V(cPos,tPos) // dist (=aoe)
        set damage = RMaxBJ( minDmg(level) , maxDmg(level) - dist*aoeDmgRatio ) // damage relative to the aoe
        ...
    endmethod
    ...
endstruct
...

Sorry if this was a bad suggestion I'm still just your scrubby jass student lolol

And awesome spell pack +rep

Malhorne · Jul 25, 2014

Nope I wanted the spell to do dmg depending on the distant from the point for the user to make a good use of the spell, after I can do your way too. That's just point of view

Anyway thanks ;D

kakuzu · Sep 13, 2014

It works good and you are a good spell maker but how about to change the name in Gravity Collaps or Presure Damage ? Just an idea .

Malhorne · Sep 13, 2014

Those name are cool

You definitely have good ideas !!
I'll think about it and ~~maybe~~ surely change it this evening or monday

kakuzu · Sep 13, 2014

Glad you like it .What name you choose Presure Damage or Gravity Collaps ?

Malhorne · Sep 13, 2014

I still dunno ^^
Maybe both.
Presure Damage when it comes to attract or expulse to/from the caster and Gravity Collaps when it comes to attract or expulse to/from a point.

I'll think of it

aider · Mar 9, 2015

The ones that attract, attract buildings as well as spell immune units. At least for me and I've only changed the range and damage fields.
Screws the actual position of buildings as the model stay at the old spot, but the whole building is moved.

Malhorne · Mar 12, 2015

Oh strange

Which one ? The one that attracts to a point or to the caster?

aider · Mar 15, 2015

Just made the buildings with Town Hall classification and added " and not IsUnitType(targ, UNIT_TYPE_TOWNHALL) " to the spells

Malhorne · Mar 15, 2015

Oh funny didn't know townhall wasn't the same classification as building, interesting.

Static Charge v1.3

Just another Warcraft III map (Map)

Moderator

Moderator

Deleted member 219079

Deleted member 219079

Similar threads