Spear of Ragnarok 2.03

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

16:01, 8th Sep 2012
Magtheridon96:

Since you have a loop inside a loop inside a loop, I'm going to urge you to optimize it as much as possible

- Get rid of the 0.405 life check. The IsUnitType check is accurate enough, and the life check makes it less accurate because the life could be pretty much anything while a unit is dead. If it reaches 0.405 or less just once, the unit is dead and any changes to life will not make it live, so it is technically possible to have a unit with more than 0.405 HP that is dead.
- Instead of comparing something to false, change the expression from the form (expression == false) to (not expression). Apply this transformation across all your code for a nice little optimization.
- Make the damage/attack types configurable.
- Instead of (not IsUnitAlly(...)), just use IsUnitEnemy.
- In the Init function, use TriggerRegisterAnyUnitEventBJ. It's actually one of the few BJs that are good.
- Don't use the trigger global variable, use a local trigger in the Init function because the global variable is useless anyway. It's cleaner with the local trigger too ^.^

 

[gorillabull]

whats a ragnarok and what do the sfx have to do with a spear ?

 

[baassee]

Just a few things that I spotted right away.

Put all things you have in actions function into the conditions function, make an if at the top checking the spell ID and return false at the end.

WHy are you using locations? JASS is so wonderful compared to GUI that coordinates is so easily retrieved by calling simple functions. Like GetSpellTargetX/Y().

You should use GetWidgetLife(u) > 0.405 instead of GetUnitState but also add IsUnitType(u, UNIT_TYPE_DEAD).

Use a FirstofGroup loop instead of ForGroup as it's faster. And for pure temporary enumerations I suggest using a global group instead of creating/destroying.

Instead of PI*2, use 6,2831.

WEAPON_TYPE_WHOKNOWS -> null. Basically the same thing.

If you really want pure damage, you should use DAMAGE_TYPE_UNIVERSAL instead of magic which will result in normal spell damage anyway.

 

[EyeCandy]

Whatta hell!

Ok, the screeny says it all!
I was thinking of putting Odin's legendary spear (Gugnir) into my Avengers map as a legendary item. Guess this spell is whatthe spear can do.

BTW, Ragnarok is technically known as the "twilight of the gods" so unleashing it indicates the end of everything.

 

[Anachron]

I have some more feedback.
Please don't udg_ prefix and use variables in JASS. (UDG = User Defined Globals, For GUI mostly)

Also it would be great if you could improve your coding style.
(For example a == b instead of a==b, set a = a +1 instead of set a=a+1)

 

[SpectreD]

Could u atleast add it to a test map for us to see how it is :/

 

[Zeatherann]

It is in a test map, the items are in the corners by the neutral building by the start locations. I will fix the code, i didn't realize those natives existed. Also; nice way to make my group enum loop! I love that idea.

You realize ALL globals are prefixed udg_?

Updated!

 

[maddeem]

You realize ALL globals are prefixed udg_?

Derp, no.

 

[Zeatherann]

Okay, I meant excluding the game_generated ones (ie: gg_trg_trigger, gg_rct_myregion)

 

[maddeem]

errrmmm the test map is terrible, no units to test it with.
Also, the ability in the OE was poorly designed, with no description.

And as for the name, I didn't see a spear. Also, Ragnarok is a fire titan... this is more along the lines of arcane.
The code itself is fine, but you must remember this is the spells section, not a snippet section lol

 

[Zeatherann]

maddeem, the 'spell' is an item spell currently, thus there is no description. The spell itself it based off of Channel and has it's art removed. The test map is a perfect map, since my intention was to balance this in a melee setting. If you look at the icon of the item it is indeed a spear. Ragnarok may be based on fire, but the beam the spear emits is always represented as an arcane/lightning beam, I categorized it under 'Chaos' (hence the damage type) and made it more arcane because i had to use a small SFX that played nicely with animation.

Furthermore, the eyecandy of this spell is very easy to modify, change the SoR_RingSFX string and the model of the dummy unit to match your needs.