Spark of Lightning v1.1

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

16:51, 2nd Feb 2015
IcemanBo: http://www.hiveworkshop.com/forums/spells-569/spark-lightning-v1-1-a-261164/#post2648137

 

[iamdl]

~HI!

 

[JC Helas]

Ammh maybe you should not array index the Point variable

• Set SLCasterPoint[SLIndexA] = (Position of SLCaster[SLIndexA])
• Set SLTempPoint[SLIndexA] = (Target point of ability being cast)

=>

• Set SLTempLoc1 = (Position of SLCaster[SLIndexA])
• Set SLTempLoc2 = (Target point of ability being cast)

And alos this one

• Unit Group - Pick every unit in SLTargetGroup[SLIndexB] and do (Actions)
  • Loop - Actions
    • Set SLTarget[SLIndexB] = (Picked unit)
    • Set SLTargetPoint[SLIndexB] = (Position of SLTarget[SLIndexB])
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (SLTarget[SLIndexB] is A structure) Equal to False
        • (SLTarget[SLIndexB] is alive) Equal to True
        • (SLTarget[SLIndexB] belongs to an enemy of (Owner of SLCaster[SLIndexB])) Equal to True
        • (SLTarget[SLIndexB] has buff SL_BUFFS) Equal to False
        • (Distance between SLDummyPoint[SLIndexB] and SLTargetPoint[SLIndexB]) Less than or equal to SLSpellAoE[SLIndexB]
      • Then - Actions
        • Unit Group - Add SLTarget[SLIndexB] to SLDamageGroup[SLIndexB]
        • Unit - Add SL_DUMMYABLITY to SLDummy[SLIndexB]
        • Unit - Order SLDummy[SLIndexB] to Neutral Pandaren Brewmaster - Drunken Haze SLTarget[SLIndexB]
      • Else - Actions
• Custom script: call RemoveLocation (udg_SLTargetPoint[udg_SLIndexB])

=> base in my theory the group is looping too and I thing if Custom script: call RemoveLocation (udg_SLTargetPoint[udg_SLIndexB]) is outside of group then you got lot of leak, this just my opinion

• Unit Group - Pick every unit in SLTargetGroup[SLIndexB] and do (Actions)
  • Loop - Actions
    • Set SLTarget[SLIndexB] = (Picked unit)
    • Set SLTargetPoint[SLIndexB] = (Position of SLTarget[SLIndexB])
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (SLTarget[SLIndexB] is A structure) Equal to False
        • (SLTarget[SLIndexB] is alive) Equal to True
        • (SLTarget[SLIndexB] belongs to an enemy of (Owner of SLCaster[SLIndexB])) Equal to True
        • (SLTarget[SLIndexB] has buff SL_BUFFS) Equal to False
        • (Distance between SLDummyPoint[SLIndexB] and SLTargetPoint[SLIndexB]) Less than or equal to SLSpellAoE[SLIndexB]
      • Then - Actions
        • Unit Group - Add SLTarget[SLIndexB] to SLDamageGroup[SLIndexB]
        • Unit - Add SL_DUMMYABLITY to SLDummy[SLIndexB]
        • Unit - Order SLDummy[SLIndexB] to Neutral Pandaren Brewmaster - Drunken Haze SLTarget[SLIndexB]
      • Else - Actions
    • Custom script: call RemoveLocation (udg_SLTargetPoint[udg_SLIndexB])

 

[GywGod133]

SLDamageGroup[SLIndexB] forgot to remove this leak

 

[Maker]

-In the cast trigger you set dummy point but remove it right a way
-Dead units do not have buffs so no need to check if the unit is alive
-You could add the dummy ability when the spell is cast
-Make the cinematic action optional

 

[ukn0wnD3str0y3r]

This is just like DotA's Invoker EMP skills.... it have lightning ball increases size and explode, nearby unit's mana burn...

 

[iamdl]

This is just like DotA's Invoker EMP skills.... it have lightning ball increases size and explode, nearby unit's mana burn...

Its like Dota EMP skill it explode but not mana burn.


BTW.. Updated

EDIT: Any one have a questin feel free to comment :|

 

[JC Helas]

Useless Variable

• Set SLCasterPoint[SLIndexA] = (Position of SLCaster[SLIndexA])

delete this.

 

[iamdl]

Useless Variable

• Set SLCasterPoint[SLIndexA] = (Position of SLCaster[SLIndexA])

delete this.

thx ill update asap

 

[deathismyfriend]

This should be stored as it is more than likely used twice or more.

• (Owner of SLCaster[SLIndexB])

 

[IcemanBo]

Read posts in thread. There are some good points mentioned.

Additional:

• Set SLDummyMaxSize[SLIndexA] = 600.00

  Why is this needed if user sets a (constant) variable for it in config part?
• Make attack- and damage type configurable.
• onDeindex you make a unit group enumeration with a not created group.
• onDeindex you have to null group-, units-, points [maxIndex]

Awaiting update.