[JASS] Some dumb question... unit = unit[array]

[DeForce]

Hello there!

I'm kinda new to Jass.
Now i'm trying to do that when you create units they saves in array and then when one of the units kill enemy, trigger compare that unit with the array, and returns the unit index in array.

First trigger i've created, when unit's are remembered in array.

But check trigger fails...

function Kill_Actions takes nothing returns nothing
local unit un
local unit unt
    set un = GetKillingUnit()
    set unt = u[1]

When i'm trying to test map, map just won't start... but when I delete

set unt = u[1]

It starts normally...
So the question. What am I doing wrong, and what I've to do to make it work?

Thanks for response

 

[xxdingo93xx]

I suppose you mean this... (only capable for you if you use JNGP)

globals
      constant integer MAX_HANDLES = 8191 //Set the size to whatever you need but don't go over 8191
      unit array SaveUnits [MAX_HANDLES] 
endglobals

function GetUnitIndex takes unit u returns integer
    local integer i = 1
    
    loop
       exitwhen i == MAX_HANDLES
       if (u == SaveUnits [i]) then
           return i
       endif
       set i = i + 1
    endloop

    return 0
endfunction

function SaveUnit takes unit u returns nothing
    local integer i = i

    loop 
        exitwhen i == MAX_HANDLES
        if (SaveUnits [i] == null) then
            set SaveUnits [i] = u
            return
        endif
        set i = i + 1
    endloop

    call BJDebugMsg("Too many handles saved!")
endfunction

For efficiency, it would be better to nullify the units from the indexing unless you need the unit's corpse.

function Actions takes nothing returns nothing
    set SaveUnits [GetUnitIndex(GetTriggerUnit())] = null
endfunction

function InitTrig_SomeTrig takes nothing returns nothing
    local trigger tri = CreateTrigger()
   
    call TriggerRegisterAnyUnitEventBJ(tri, EVENT_PLAYER_UNIT_DEATH)
    call TriggerAddAction(tri, function Actions)
endfunction

 

[DeForce]

Thank you, but that's not exactly what i need.

Really, i thought that [array] are set as 8191 by default...

Hm... that trigger really gives the max index filled by units... But i need the exactly index of killing unit...
but that is only for me... I really don't understand the code... =(

globals
constant integer max_units = 1000
unit array u[max_units]
integer count = 0 // when unit spawns, this makes count = count + 1
endglobals


function Kill_Actions takes nothing returns integer
local integer a = 1
local unit ub
    set ub = GetKillingUnit()
    
    loop
        exitwhen a == count
        if(ub == u[a]) then
            return a
        endif
        set a = a + 1
    endloop
    call DisplayTextToPlayer(GetLocalPlayer(),0,0,"killing unit is at index : "+I2S(a))
        return 0
endfunction

/////////

function InitTrig_Kill takes nothing returns nothing
local trigger t
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( t, function Kill_Actions )
endfunction

I try to do this myself, and then compare with that you've post, if you do that.

 

[Justify]

They are. The way dingo wrote it you could add a higher number (like 40.000)... but remember that these "higher" globals are slower.

 

[Adiktuz]

I think its because u[1] is a local unit array that you made in another trigger, locals can only be used in their respective triggers.. if its a global change it to udg_u[1]....

 

[Yixx]

If its a global change it to udg_u[1]....

Bullshit.. you are too stuffed up by GUI.. If he uses a global block (vJass, which he did in his example) he wont have to use udg_
Get rid of that GUI-code-thinking..

 

[Kingz]

Change:

local unit unt

To:

local unit array unt

Then try again

EDIT:

To get the right index of a unit you could use some existing libraries, or hashtables

 

[Adiktuz]

Bullshit.. you are too stuffed up by GUI.. If he uses a global block (vJass, which he did in his example) he wont have to use udg_
Get rid of that GUI-code-thinking..

well I'm talking about his first post, there is no global block there... sorry.

 

[Justify]

Then read the entire post :O