[vJASS] Unit Indexing System

[msongyboi]

Hi all I've been trying to learn more about structs and currently trying to recreate an unit indexer for the sake of practice.
The index works just fine, but the de - index won't go through - what am I doing wrong?

scope JassUnitIndexer initializer init 

    globals
        real indexEvent = 0.00
        
        unit array units
        integer array prev
        integer array next
        integer array rn
        integer ic = 0
    endglobals
            
    private function indexUnits takes unit u returns nothing
        local integer this = rn[0]
        
        if this == 0 then
            set ic = ic + 1
            set this = ic
        else
            set rn[0] = rn[this]
        endif
        
        set next[this] = 0
        set prev[this] = prev[0]
        set next[prev[this]] = this
        set prev[0] = this
        
        set units[this] = u
        call SetUnitUserData(units[this], this)
        set indexEvent = 1.00
        set indexEvent = 0.00
        call BJDebugMsg("UNIT HAS BEEN INDEXED! UNIT " + GetUnitName(u) + " HAS BEEN INDEXED AS NUMBER " + I2S(this) + "!")
    endfunction
    
    private function initializeIndex takes nothing returns boolean
        local unit lvUnit = GetTriggerUnit()
        local integer this
        
        set this = next[0]
        loop
            if GetUnitState(units[this], UNIT_STATE_LIFE) == 0 and units[this] != null then
                call BJDebugMsg("Instance number " + I2S(this) + ", " + GetUnitName(units[this]) + " is being recycled!")
                set units[this] = null
                set prev[next[this]] = prev[this]
                set next[prev[this]] = next[this]
                set rn[this] = rn[0]
                set rn[0] = this
                set indexEvent = 2.00
                set indexEvent = 0.00
                set this = 0
            endif
            exitwhen next[this] == 0 or (GetUnitState(units[this], UNIT_STATE_LIFE) == 0 and units[this] != null)
            set this = next[this]
        endloop
        
        call indexUnits(lvUnit)
        
        set lvUnit = null
        return false 
    endfunction
    
    private function init takes nothing returns nothing
        local trigger t = CreateTrigger()
        local rect lvRect = GetWorldBounds()
        local region lvReg = CreateRegion()
        local group g = CreateGroup()
        local unit fog 
        
        call GroupEnumUnitsInRect(g, lvRect, null)
        loop
            set fog = FirstOfGroup(g)
            exitwhen fog == null
            call indexUnits(fog)
            call GroupRemoveUnit(g, fog)
        endloop
        
        call RegionAddRect(lvReg, lvRect)
        
        call TriggerRegisterEnterRegion(t, lvReg, null)
        call TriggerAddCondition(t, function initializeIndex)
        
        call DestroyGroup(g)
        set g = null
        set t = null
    endfunction
    
endscope

Okay i think its working now, but I'm not 100% sure..

 

[Almia]

So that you won't be tired of making this shit,use Nes' Unit Indexer.
http://www.hiveworkshop.com/forums/jass-resources-412/system-unit-indexer-172090/

 

[msongyboi]

it's tiring, but its really fun and I like to practice and learn

 

[Nestharus]

Ok...

        set next[this] = 0
        set prev[this] = prev[0]
        set next[prev[this]] = this
        set prev[0] = this

set this.next = 0
set this.prev = 0.prev

this.prev now points to whatever is before 0, which is the last node on the list

then this.prev.next = this

this.prev points to the last node, so

lastNode.next = this

and then 0.prev = this, meaning that the new last is this

looks perfect =)

but you could just as easily use next[prev[0]], and the literal number will be a little bit more efficient than a variable

however, using the variable is less error prone, not as easy to make mistakes =). Fine tuning like this usually leads to mistakes.

Looking good on your list ; p.


Why are you deindexing when a unit's life is 0? Shouldn't you deindex if GetUnitTypeId is 0?

Also, you should exit the loop when this == 0 or GetUnitTypeId(units[this]) != 0

 

[msongyboi]

Why are you deindexing when a unit's life is 0? Shouldn't you deindex if GetUnitTypeId is 0?

Also, you should exit the loop when this == 0 or GetUnitTypeId(units[this]) != 0

Hm.. when will this return true?

edit: NM you're right rofl - thanks for the heads up

 

[muzzel]

So that you won't be tired of making this shit,use Nes' Unit Indexer.
http://www.hiveworkshop.com/forums/jass-resources-412/system-unit-indexer-172090/

Man when do you guys start reading the topic before you answer?

 

[Almia]

Man when do you guys start reading the topic before you answer?

Im always that clumsy
Anyways,contact the staff,give me a neg rep.

 

[Kanadaj]

Im always that clumsy
Anyways,contact the staff,give me a neg rep.

Haha easy to say with 800+ rep

 

[Almia]

Im not that boasting.

 

[muzzel]

I would give u negrep, but i cant :[