[Solved] Need some help with this trigger

[MrStonefist]

• ´Upgrade Item
  • Events
    • Unit - A unit Begins research
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players matching ((Owner of (Triggering unit)) Not equal to Neutral Hostile)) and do (Actions)
      • Loop - Actions
        • Unit Group - Pick every unit in (Units owned by (Picked player) of type Troll) and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Item-type of (Item carried by (Picked unit) in slot 1)) Equal to Potion of Healing
              • Then - Actions
                • Custom script: call IssueImmediateOrderById(GetTriggerUnit(), 1378889776)
                • Wait 0.01 seconds
                • Skip remaining actions
              • Else - Actions
            • Wait 10.00 seconds
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Item-type of (Item carried by (Picked unit) in slot 1)) Equal to Ancient Figurine
              • Then - Actions
                • Item - Remove (Item carried by (Picked unit) in slot 1)
                • Wait 0.01 seconds
                • Hero - Create Ancient Figurine +6 and give it to (Picked unit)
              • Else - Actions

Can someone tell me whats wrong cause it don't work.

PS: this is not the full code the last rows is copys of the 8 last rows here.

 

[mckill2009]

why do you need pick every player when there's already pick every unit and put conditions not equal to NH?...

and you dont need skip remaining actions, just put it in the 'else' part...

 

[Bribe]

Memory leaks

(All players matching ((Owner of (Triggering unit)) Not equal to Neutral Hostile))

- That leaks a force. You need to do:

Set TempForce = (All players matching ((Owner of (Triggering unit)) Not equal to Neutral Hostile))
Pick all players in TempForce and do (Actions)
Custom script: call DestroyForce(udg_TempForce)

...

Unit Group - Pick every unit in (Units owned by (Picked player) of type Troll) and do (Actions)

Right before doing this, you need:

Custom script: set bj_wantDestroyGroup = true

 

[Hashjie]

could you also tell us what exactly is not working?
what is the deal with those wait 0.01? Can't you just remove those?

 

[Bribe]

Oh yes, I missed that, you can't use waits in "pick all..." actions. They will crash the thread (error). You have to run a separate trigger to complete the wait actions or use timers.

 

[Bribe]

Solutions have already been presented and you have yet to give feedback if they are sufficient. I deleted your other thread. Don't double-post.

 

[MrStonefist]

I removed the wait 0.01 and changed the unit pick action so it's a lot more easy and now it works, thanks guys!