Snowball Fountain v1.2a GUI

[FUJI]

The fountain of death is perfectly modified, my spells are friendly in configuration so you can modify the spell base on your flavor or style. ~Have Fun!
Currently the version is v1.0a ( minor change about the fountain angle )

 

[KILLCIDE]

Another awesome spell concept by jakeZinc. However, what is a spell submission by jakeZinc without addressing issues with his other submissions

• Please keep map demo stuff in their own folder (TreeRevival)
  
• TreeRevival was not letting me launch the map because of an "unexpected: elseif"
• When you are preloading, why have users input the strings manually when you can just directly refer to their variables?
• jakeZinc PLEEASE: set udg_SF_FrostModelCache[ udg_SF_MaxIndex ] = AddSpecialEffectTarget( udg_SF_FrostModel, udg_SF_Frost[ udg_SF_MaxIndex ], "origin" ). My heart dies inside when I see hardcoded things. This applies to all the other SpecialEffectTargets that have its attachment point hardcoded
• The "recalculating issue" as with your 2 other submission applies to here for 360. / SF_FrostPortalMissleAmount[SF_Level]
• Hmm why do multiply 1 to Cos and Sin? Also, I think they can be cached onCast as explained from your 2 other submissions
• I see no need to null global variables (unless they are timers and unit groups), but as Cokemonkey explained to me before:
  

  It's perfectly reasonable to do so.

• DummyRecycler? This will probably not make sense if you read this submission first. Just in case you do, I highly recommend it for spells / systems that have to recreate a lot of dummy units.

I do rather love the extensive configuration and nicely documented code. However, I am still confused as to why you mix a lot of Jass and GUI The use of FirstOfGroup() is fine, but it becomes really hard to read when you mix it with GUI If/Then/Else. They look like a wall of black text. This applies to your previous 2 submissions as well.

Awaiting Update for now.

 

[FUJI]

I'm glad that my current spells are finally getting a review. Thanks Killcide,

- About preloading, Ill change that. ( lol didnt notice that )
- About the tree revival, Ill just delete it instead since it gives the users some errors.
- About the model attachments, Ill add that in configuration. ( I thought origin is the only attaching point of dummy.mdx )
- About the recalculating issues, Ill try that.
- About the 1 multiplying to Cos/Sin, Ill remove that. ( I dont know either why I did that xD )
- About nulling global, I cant find anything wrong with it. ( but ill just remove it as you said. )
- About the if-nests inside the GroupEnum loop, Ill try to shorten it or change it to filter func. ( Those structure of condition configurations are wrong by the way ( my fault ), sorry for that wall of text xD )

-About the DummyRecycler, Currently I have no JNGP ( I use Vanilla Editor ) and is the reason why It is GUI.

Ill update these spells as soon as possible, after this snowball fountain gets approved Ill submit my developing spell ( a spell that gaves me the true meaning of busyness ).

EDIT: Updated to v1.1.

* Now preloads effect variables instead of manually writing it.
* Removed Tree Revival system. ( causing launching errors )
* Added a configuration of effects attachment.
* Added an init calculation on snowball angle, ( frost portal missile angle didn't work after calculating it onInit ( don't know why but It can be fixed by allocating this angle onCast and it forces me to create an array variable instead. )
* Removed the multipled itself of Cos/Sin.
* Removed nulled global variables at recycling.

 

[FUJI]

Updated to v1.2

* Added an ability max level configuration. ( for calculating purposes and etc. )
* Also preloads the ability and the dummy unit.
* Changed the array angles into non-array variable. ( allocating them is useless. )
* Initializes the calculation of both angle in initialization trigger. ( prevents recalculating issues. )
* Added a note that the amount of dummy units ( snowballs, missiles ) != 0 to prevent problems.
* Added a function that prevents leak in GroupEnumUnitsInRange func.
* Changed native unit coordinates into widget. ( faster )
* Reduced lags. ( it still depends on the modification of the user. )

 

[Flux]

-About the DummyRecycler, Currently I have no JNGP ( I use Vanilla Editor ) and is the reason why It is GUI.

Just to let you know, it also comes in JASS version so it can still work without JNGP.

 

[jhonwaa]

Nice spell but I slowly produces computer.

 

[KILLCIDE]

I only see two minor changes I would like to see changed and then it is ready for approval:

• Can SF_Frost[] move around? If so, you can store the SpellTargetX and TargetY on cast instead of recalculating per loop iteration
• The way you have your filters setup look a little freaky this is how I would do it:
  
  • Conditions
    • (SF_Temp_Unit is A flying unit) Equal to False
    • (SF_Temp_Unit is Magic Immune) Equal to False
    • (SF_Temp_Unit is alive) Equal to True
    • (SF_Temp_Unit belongs to an enemy of SF_Player[SF_CurrentIndex]) Equal to True
    • Or - Any (Conditions) are true
      • Conditions
        • (SF_Temp_Unit is A structure) Equal to False
        • SF_DamageStructures Equal to True
    • Or - Any (Conditions) are true
      • Conditions
        • (SF_Temp_Unit is Mechanical) Equal to False
        • SF_DamageMechanical Equal to True
  • Actions
    • -------- damage unit --------

Set to Awaiting Update.

 

[FUJI]

I only see two minor changes I would like to see changed and then it is ready for approval:

• Can SF_Frost[] move around? If so, you can store the SpellTargetX and TargetY on cast instead of recalculating per loop iteration
• The way you have your filters setup look a little freaky this is how I would do it:
  
  • Conditions
    • (SF_Temp_Unit is A flying unit) Equal to False
    • (SF_Temp_Unit is Magic Immune) Equal to False
    • (SF_Temp_Unit is alive) Equal to True
    • (SF_Temp_Unit belongs to an enemy of SF_Player[SF_CurrentIndex]) Equal to True
    • Or - Any (Conditions) are true
      • Conditions
        • (SF_Temp_Unit is A structure) Equal to False
        • SF_DamageStructures Equal to True
    • Or - Any (Conditions) are true
      • Conditions
        • (SF_Temp_Unit is Mechanical) Equal to False
        • SF_DamageMechanical Equal to True
  • Actions
    • -------- damage unit --------

Set to Awaiting Update.

^ Updated to v1.2a
* Frost Portal unit's coordinates stored onCast instead onLoop. ( Prevents recalculating in loop iterations )
* Fixed the if nests filtering onLoop.

Finally maybe the last update ^^.

 

[KILLCIDE]

Ahh yes, a much cleaner damage filter screw all those unneccesary If/Then/Else!

The code looks good, extensive and descriptive configuration trigger, and awesome spell effects. The only downside I see with this spell is the amount of lag it generates. The overall spell concept is also all right. I didn't take the time to look at all the variables you use in JASS, but look out for the possibility of any global variables that are only used in custom scripts. When users import this into their map, the global might not be transfered over, causing errors.

Approved with a 4/5 rating.

 

[FUJI]

Yep but I believe that custom scripted global vars are already created in recycling ^^. ( I've planned putting a variable creator to my future spells )