[Snippet] IsUnitCorpse

[Kazeon]

library IsUnitCorpse initializer onInit
    
    /*
        Simple library used to check whether a unit has become a corpse or not.
        
        How to use:
        - You must have a dummy caster at your OE
        - Copy this trigger into your map
        - Save your map, then re-open it
    */
        //! external ObjectMerger w3a Amel IRAA anam "CORPSE_CHECKER" abpy 0 auby 0 aart "" auar "" arac "other" ahky "" auhk "" aran 1 0 atar 1 "air,dead,ground,player" atp1 1 "" aub1 1 "" aut1 1 "" auu1 1 ""
    /*  
        - Delete or comment out that one line above and save again.
    */
    
    globals
        private constant integer DUMMY_ID     = 'h000'
        private constant integer SPELL_ID     = 'IRAA'
        private constant integer CONTAINER_ID = 'Sch2'
        private constant integer ORDER_ID     = 852053
        private constant player UNUSED_PLAYER = Player(15)
        private unit Dummy
    endglobals
    
    native UnitAlive takes unit id returns boolean
    
    function IsUnitCorpse takes unit u returns boolean
    
        local boolean b
        local player p
        
        if not UnitAlive(u) then
            set p = GetOwningPlayer(u)
            call SetUnitOwner(u, UNUSED_PLAYER, false)
            call SetUnitX(Dummy, GetUnitX(u) + 100)
            call SetUnitY(Dummy, GetUnitY(u) + 100)
            call IssueImmediateOrderById(Dummy, ORDER_ID)
            set b = GetUnitCurrentOrder(Dummy) == ORDER_ID
            call SetUnitPosition(Dummy, 1234567890, 1234567890)
            call SetUnitOwner(u, p, false)
        else
            return false
        endif
        
        return b
    endfunction
    
    private function onInit takes nothing returns nothing
        set Dummy = CreateUnit(UNUSED_PLAYER, DUMMY_ID, 1234567890, 1234567890, 0)
        call UnitAddAbility(Dummy, SPELL_ID)
        call UnitAddAbility(Dummy, CONTAINER_ID)
    endfunction
    
endlibrary

 

[Vinz]

Awesome usefulness.

Comment out or delete this line, then save again

Which line though? I get confused.

 

[Kazeon]

Awesome usefulness.

Which line though? I get confused.

Aren't you CakeMaster?

This line:

//! external ObjectMerger w3a Amel IRAA anam "REVIVE_CHECKER" abpy 0 auby 0 aart "" auar "" arac "other" ahky "" auhk "" aran 1 0.01 atar 1 "air,dead,ground" atp1 1 "" aub1 1 "" aut1 1 "" auu1 1 ""

Sorry for the confusion

 

[Vinz]

I see, thanks for clarifying.

 

[Bannar]

I'm fine with this although such scripts are part of UnitEvent-related resources, no need to submit them one by one.

Whatmore, if you want to know the truth, you don't need any dummy units or abilities in order to detect the "decay" event. What you do need is, an unit indexer and a constant decay timer found in game constants (or calculate it manually at the begining of the game). You won't have access to private stuff of given UI, thus it's probably better to write an extension for given indexer.

The undefend event fires more often than just once in certain cases. Thats why one usually needs proper differenciation in order to properly fire INDEX/DEINDEX event. With help of "decay constant", you can check the difference between time of death, and time of decay. If it's within range of your constant, fire "decay event".

 

[Kazeon]

Decay event is already there: EVENT_UNIT_DECAY

No need to remake it. The difference is that this library is not generating event.

time of death

I believe different unit has a different death time

 

[Bannar]

Dalvengyr >.>

But you need to catch that in order to tell if unit is decaying (IsUnitDecaying).

I believe different unit has a different death time

So what? Start the timer at the begining of the game and check the timer elapsed for given unit when it dies.
Later refer to that value when checking the difference between it and current game time.

Have you tried looking at UnitEvent and other related libraries?

 

[Nestharus]

This is no good. Every time you use it, it's going to reset remaining decay time.

Try again ^)^

 

[Kazeon]

Have you tested it? Dummy unit is ordered to stop, at least moved to another location, right after ordered to pick the corpse. Yeah, so, corpse picking is fail.

Try again ^)^

<< WILL NEVUR STOP

 

[TriggerHappy]

So does this reset the decay time or not?

If so then Bannar's solution is a good one.

 

[Kazeon]

Dalvengyr >.>

But you need to catch that in order to tell if unit is decaying (IsUnitDecaying).
So what? Start the timer at the begining of the game and check the timer elapsed for given unit when it dies.
Later refer to that value when checking the difference between it and current game time.

Have you tried looking at UnitEvent and other related libraries?

I'm sorry if I'm hardly understand. But I think I don't need any event. The function check whether a unit is currently decaying at time X, is that unit has become a corpse or not yet at that time X.

Note: DoesUnitDecay != IsUnitDecaying

Edit:
Anyway, value of 100 seems quite risky, perhaps I will reduce it to 0.1 or something...

 

[TriggerHappy]

If this resets decaying time (you still haven't answered me) then this can't be approved.

I think Bannar is saying to check when a unit decays with the native event, then set a boolean somewhere (probably using a unit indexer + array).

 

[Kazeon]

If this resets decaying time (you still haven't answered me) then this can't be approved.

Dunno. I don't understand what was Nestharus talking about :/ How on earth this snippet resets decay time? It's probably true if the dummy successfuly picks the corpse then drop it again, but it does not...

 

[Nestharus]

So what you are saying is that you don't actually revive the unit? If so, then decay time won't be reset ; )

 

[TriggerHappy]

Doesn't seem to work for me. Yes I have a dummy unit (from xe).

IUD Test Events Time - Every 1.00 seconds of game time Conditions Actions Unit - Create 1 Footman for Player 1 (Red) at (Random point in (Playable map area)) facing Default building facing degrees Unit - Kill (Last created unit) Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions) Loop - Actions Custom script: if IsUnitDecaying(GetEnumUnit()) then Game - Display to (All players) the text: ((Name of (Picked unit)) + is decaying.) Custom script: endif

^ displays nothing.

The trigger below however, fires.

Untitled Trigger 001 Events Unit - A unit Decays Conditions Actions Game - Display to (All players) the text: true

Sorry if I missed something.

 

[Kazeon]

I think I misnamed it, this library actually checks whether a unit has become a corpse or not. If you check immediately after kills, then it indeed results false, because it hasn't become a corpse yet.

So what you are saying is that you don't actually revive the unit? If so, then decay time won't be reset ; )

Nope.

Updated Now it safe even for checking two units with exact same location and exact time. But requires dummy unit with 0 acquistion range

 

[TriggerHappy]

You should rename the library then I'll probably approve it.

IsUnitDecaying doesn't reflect what the script actually does.

 

[Kazeon]

Here is an update. I have tried to use this at a spell and looks safe and works well. Now you are prohibited to have 0 acquisition range for the dummy caster instead.

 

[Nestharus]

so before TriggerHappy rushes headlong into approving this

not UnitAlive(whichUnit) and GetUnitTypeId(whichUnit) != 0

IsUnitType(whichUnit, UNIT_TYPE_DEAD)

elaborate on why your solution is better than the standard approaches that have been used for years


be sure to show differences in behavior and performance and weigh the pros/cons

 

[Xonok]

I have an alternate approach that would probably work much better - Check the current animation of unit. If it's "decay bone" or "decay flesh" then it is a corpse.
It's easier and will probably work better.

 

[Kazeon]

differences in behavior

This only returns true if the unit has actually become a corpse, that's the only difference.

performance and weigh the pros/cons

This seems slower. But can be useful for some abilities like Cannibalize where it can only consumes "real corpse" not dying unit.

I have an alternate approach that would probably work much better - Check the current animation of unit. If it's "decay bone" or "decay flesh" then it is a corpse.
It's easier and will probably work better.

Is there a way to check unit's current animation?

 

[Bannar]

I wanted to point out smthing but I hadn't realise that this is not an "event" resource..

However, there is something hidden, and I'm pretty sure none of you realised that while examining this snippet.

Unit corpse != usable unit corpse
There are few rare situations where unit might not yield usable corpse, e.g consider a case when unit dies and has reincarnation ability - body won't decay. However, if the reincarnation ability is removed as soon as unit dies, the effect persists but now, unit yields a corpse, which is unfortunatelly unusable.
This, and few other combinations are usefull when you want to create "purified" corpses e.g prevent them from Scourge' magic ^)^

Result: this still might be usefull for determining "usable corpse" or differenciate usable one from non-usable. However, as pointed above - if you just want to say whether unit is a corpse or not, there isn't much required to test that out. I'm still waiting for you to rewrite this using the timer approach : )

 

[Kazeon]

This, and few other combinations are usefull when you want to create "purified" corpses e.g prevent them from Scourge' magic ^)^

Perhaps. But then, how can we prevent it from being revived? ^)^ #Everyone_become_Nestharus_now

 

[Vinz]

Perhaps submit a custom Resurrect Snippet

 

[Bannar]

You don't. It's not desired to interfere in actions performed by user on purpose, lol.
Lol @ "everyone is Nes" statement. Everyone here is unique, and you probably know that after spending few weeks visiting hive

I've proposed different approach in one of first posts in this thread ^)^

 

[Kazeon]

I still don't understand your different approace ^)^

If what you want is using unit decay event, utilize indexer, and use a boolean array global.. Well, that doesn't look like a snippet. ^)^
This is a trick, to shorten up the code and w/o requiring any burden dependecy. ^)^

And running that macro shit wont hurt anybody... ^)^ Also everybody got dummy caster in their maps, so what's the big deal? ^)^

@NesthaHolic

 

[Vinz]

Just realized my post is weird.

Corpse Usability != Ressurect-ability

I suggest a custom corpse system that handles all corpse stuff. (Raise Dead, Resurrection, etc.)

 

[Bannar]

Dalvengyr, because I thought you wanted to extend this with "event" functionality i.e this would become more or less the "decay event" :>
UI library is not a burden ^)^

 

[Kazeon]

Dalvengyr, because I thought you wanted to extend this with "event" functionality.

Answer

 

[Bannar]

Honestly, I don't know when would you want to this snippet if it's not UnitEvent-related resource with additional functionality.
Meaby just for the very reason I've stated few posts above: differenciate usable corpse from non-usable.

 

[Kazeon]

Public Service Announcement:

I'm not adding event into this snippet. I will also stay with current approach since the other approach isn't that better.

Thank you for your patience!

 

[TriggerHappy]

Seems to work and I'm not aware of any better alternatives so approved.

'Sch2'could be a constant though.

Also is the+ 100offset necessary with SetUnitX/Y?

 

[Bribe]

Very very minor improvement:

    function IsUnitCorpse takes unit u returns boolean
    
        local boolean b = false
        local player p
        
        if not UnitAlive(u) then
            set p = GetOwningPlayer(u)
            call SetUnitOwner(u, UNUSED_PLAYER, false)
            call SetUnitX(Dummy, GetUnitX(u) + 100)
            call SetUnitY(Dummy, GetUnitY(u) + 100)
            call IssueImmediateOrderById(Dummy, ORDER_ID)
            set b = GetUnitCurrentOrder(Dummy) == ORDER_ID
            call SetUnitPosition(Dummy, 1234567890, 1234567890)
            call SetUnitOwner(u, p, false)
        endif
        
        return b
    endfunction