Small Question Regarding Leaks

[Megafyr]

set l = Location(x, y)
set l = Location(y, x)
call RemoveLocation(l)

Will l leak?

I always do it like:

set l = Location(x, y)
call RemoveLocation(l)
set l = Location(y, x)
call RemoveLocation(l)

But it seems like I am doing more than I have to. right? xD

 

[Reaper2008]

Second one is right.

 

[Super-Sheep]

I have asked this same question and I was told that first one was right. -.-

not sure thought that did I understand what you mean, cause of y,x stuff.

 

[Diablo-dk]

The second example is the right way to do it.

An easy way to understand why, is to think of locations as objects. Each time you do a Location(x, y) call, you create a new object that has to be removed later, and since you are creating 2 locations but only removing one of them in your first example, it will leak.

By the way, it is more efficient to use a single global location instead of local locations, since you always have to create and destroy them, whereas you can just do a MoveLocation() call with a global location.

 

[Reaper2008]

Best explanation possible is a small explanation of pointers.

If you have:

local location loc
set loc = Location (0, 0)
set loc = Location (1, 1)
call Remove Location(loc)

The variable points to the location, it isn't the location. And if you change it the location it pointed to before remains, but it is unreachable, and eats up memory (= leak).

 

[Megafyr]

Thank you for your answers! I understand it now.

 

[Saia_Djinn]

but you should also

null

the variable or it will still leak a lil bit after removing

 

[The Reborn Devil]

When you have local variables you must null them if they are handles with the exception of players. And the second one is right.

local location l
set l = Location(0., 0.)
call RemoveLocation(l)
set l = Location(0., 0.)
call RemoveLocation(l)
set l = null

 

[Megafyr]

I always do that.