[JASS] Simple Passive Spell...

[mckill2009]

I have this code and it works just fine...
But I have some few questions...

Hidden

function Doppel takes nothing returns nothing
    local unit Attacked = GetTriggerUnit()
    local unit Attacker = GetAttacker()
    local unit Doppelganger
    local integer randomizer = GetRandomInt(1,100) 
    local integer abilityID = 'AHab' // <<< Can be customized
    local integer abilitylevel = GetUnitAbilityLevel(Attacked, abilityID)
    local integer castok = 5 * abilitylevel 
    local string SFX = "Abilities\\Spells\\Demon\\DarkPortal\\DarkPortalTarget.mdl"
    if randomizer <= castok and GetUnitAbilityLevel(Attacked, abilityID) >= 0 and IsUnitEnemy(Attacker, GetOwningPlayer(Attacked)) and IsUnitType(Attacked, UNIT_TYPE_HERO) then
       call DisplayTextToPlayer(Player(0), 0, 0, I2S(castok))
       set Doppelganger = CreateUnit(GetOwningPlayer(Attacked), GetUnitTypeId(Attacker), GetUnitX(Attacker), GetUnitY(Attacker), 0)  
       call DestroyEffect(AddSpecialEffect(SFX, GetUnitX(Doppelganger), GetUnitY(Doppelganger)))
       call UnitApplyTimedLife(Doppelganger, 'BTLF', 15.0)
    endif
    set Attacked = null
    set Attacker = null  
    set Doppelganger = null   
endfunction
 
//==== Init Trigger Doppelganger ====
 
function InitTrig_Doppelganger takes nothing returns nothing
    local trigger t                         = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ      (t, EVENT_PLAYER_UNIT_ATTACKED)
    call TriggerAddAction                   (t, function Doppel)
    set t = null        
endfunction

1. is there any way to shorten the "If randomizer blahhh and blahhh and blahhh..."

2. Can I use "filterfunc >>> Filter>>>Condition" for this? coz I've tried and I got an error...pls show me how to do it correctly...

3. I did this before and its not functioning well, why?...

if randomizer <= castok and abilitylevel >= 0 .........

 

[chobibo]

#1 [a] Store them in variables, at the expense of consuming more memory.
#1 Setup a triggercondition for the trigger.
#2 I'm not sure but I think boolexpr's can't be used like boolean variables or functions returning boolean.
#3 Enclose them in brackets; (abilitylevel >= 0)

 

[mckill2009]

OK perhaps my question was not so clear...

1. I mean, Shorten like this...

if randomizer <= castok and
        GetUnitAbilityLevel(Attacked, abilityID) >= 0 and 
        IsUnitEnemy(Attacker, GetOwningPlayer(Attacked)) and
        IsUnitType(Attacked, UNIT_TYPE_HERO) then
endif

2. I use like this "local filterfunc cond = Filter(function sample)" but I dont
how to setup conditions to it except using triggercondition...

3. Ok I mean it also worked but it's getting the same results, castok is always 10...

 

[Maker]

if randomizer <= castok and /*
        */ GetUnitAbilityLevel(Attacked, abilityID) >= 0 and /*
        */ IsUnitEnemy(Attacker, GetOwningPlayer(Attacked)) and /*
        */ IsUnitType(Attacked, UNIT_TYPE_HERO) then
endif

 

[mckill2009]

Still error...

  if randomizer <= castok and /*
       */ GetUnitAbilityLevel(Attacked, abilityID) >= 0 and /*
       */ IsUnitEnemy(Attacker, GetOwningPlayer(Attacked)) and /*
       */ IsUnitType(Attacked, UNIT_TYPE_HERO) then
            call DisplayTextToPlayer(Player(0), 0, 0, I2S(castok))
            set Doppelganger = CreateUnit(GetOwningPlayer(Attacked), GetUnitTypeId(Attacker), GetUnitX(Attacker), GetUnitY(Attacker), 0)  
            call DestroyEffect(AddSpecialEffect(SFX, GetUnitX(Doppelganger), GetUnitY(Doppelganger)))
            call UnitApplyTimedLife(Doppelganger, 'BTLF', 15.0)        
endif

 

[chobibo]

That's a vjass syntax.

EDIT: I think I was wrong haha.

 

[Pharaoh_]

Of course you can add condition, make sure it returns "boolean" and it returns a value, e.g. return GetSpellAbilityId() == 'A000'.

 

[mckill2009]

@chobibo
yeah I've tried it in JNGP and Maker's suggestion worked, unfortunately I want it in plain JASS...

@Pharaoh_
yeah but how can I reference/call that Condition by using filters? instead of TriggerAddCondition?...

 

[baassee]

if randomizer <= castok and/*
        */ GetUnitAbilityLevel(Attacked, abilityID) >= 0 and/*
        */ IsUnitEnemy(Attacker, GetOwningPlayer(Attacked)) and/*
        */ IsUnitType(Attacked, UNIT_TYPE_HERO) then
endif

Shouldn't it be like this? Or, works for me. (In JNGP but whatever, should work with normal we too or?)

if randomizer <= castok and /*
        */GetUnitAbilityLevel(Attacked, abilityID) >= 0 and /*
        */IsUnitEnemy(Attacker, GetOwningPlayer(Attacked)) and /*
        */IsUnitType(Attacked, UNIT_TYPE_HERO) then
endif

 

[PurgeandFire]

1. You can use seperate booleans, but it is less efficient. For example:

    local boolean b1 = (randomizer <= castok)
    local boolean b2 = GetUnitAbilityLevel(Attacked, abilityID) >= 0
    local boolean b3 = IsUnitEnemy(Attacker, GetOwningPlayer(Attacked))
    local boolean b4 = IsUnitType(Attacked, UNIT_TYPE_HERO)
    if b1 and b2 and b3 and b4 then
        //...actions...
    endif

Otherwise, you can't really shorten it in plain JASS.

2. You can't evaluate boolexprs without using triggers/a group or some other variant. However, you can just create a function that returns boolean:

    function cond takes integer r, integer c, unit attk, integer id, unit attacker returns boolean
        return (r <= c) and (GetUnitAbilityLevel(attk,id) >= 0) and IsUnitEnemy(attacker,GetOwningPlayer(attk)) and IsUnitType(attk,UNIT_TYPE_HERO)
    endfunction

And then just use:

    if cond(randomizer, castok, Attacked, abilityID, Attacker) then

3. castok will always be 10 if the unit's ability level is 2.

@baassee: Comment delimiters are a vJASS feature. Also, both of those two codes should have the same result.

 

[mckill2009]

yeah baassee, I've tested it, its in vJASS...

OK Purge's suggestion finally solved all these specially #2, thanks +rep to all...sorry baassee I cant rep you coz Ive already rep you, system wont allow ...

 

[baassee]

@baassee: Comment delimiters are a vJASS feature. Also, both of those two codes should have the same result.

Oh I see. Hmm where can I be recognizing them then? C?