Simple Hint Generator GUI or JASS 0.8

Moderator · Feb 4, 2013

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

02:57, 11th Feb 2013
Maker: Setting to pending as requested by the uploader.

defskull · Feb 4, 2013

A neat trick I learned from Maker, is that you don't need to allow the user to input their maximum/total object (in this case, it is 5 - for 5 hints).

You can do this on your own - making your system more user-friendly instead letting them to put their object's size.

Actions
- Set String[1] = HELLO
- Set String[2] = THERE
- Set String[3] = HOW
- Set String[4] = ARE
- Set String[5] = YOU
- Set TempInt = 1
- For each (Integer LoopingInteger) from 1 to TempInt, do (Actions)
  - Loop - Actions
    - Custom script: if udg_String[udg_LoopingInteger] == null then
    - Set ObjectSize = (LoopingInteger - 1)
    - Custom script: else
    - Set TempInt = (TempInt + 1)
    - Custom script: endif
- Game - Display to (All players) the text: (String(ObjectSize))

By doing this way, it is more user-friendly

The idea is that, you loop until the element becomes null (never gets registered).
Then, the null index is the size of the object.

This is applied to HINT_MAX in case you're confused.

Pinzu · Feb 4, 2013

Gonna be implementing those, thanks.

Wolf_Wing · Feb 4, 2013

Why you using wait action ? ...... ?

Chaosy · Feb 4, 2013

Useful, why not put the setup varibles in its own trigger

Pinzu · Feb 4, 2013

Wolf_Wing said:
Why you using wait action ? ...... ?

How precise does it need to be?

Updated 1:
- Moved the setup to initialization.
- Added defskulls feature, or Makers? ;P
- Only displays messages to active playing, user, enabled players.

Considering:
- Moving everything to one trigger, but that might complicate for the targeted user even futher. :> (added for jassversion)
- Prevent the random hint from generating the last random genereted hint when it starts over.
- Adding a reminder displaying how to turn on hints if you havent every once in awhile. (added for jass version)
- Forgot to remove unused variables...

Also if anyone has any ideas how to keep other messages but only allow one hint message at a time you might advice me! Would like to have some thing similar for customized error-messages aswell.

Update 2: Made a jass version!
Update 3: The jass version now inclouds the command "-hint XX" and this will let you retrive the hint associated with that number. This gave me the idea that you type "-hint" and then go on from there "-next" but meh, leaving it at this for now.

Tank-Commander · Feb 4, 2013

Are the wait functions really necessary? they aren't accurate at all, would be better to set up a sort of timer 'till the next hint (not necessarily the sort of timer you get built-in on the world editor) rather than using such a wait function?

Pinzu · Feb 4, 2013

Well, it displays a hint that isn't associated to any particular event, thats why I felt no need for them to be accurate. But if you really think it is needed I'll look into it. If you really want to see something unaccurate, look at the "reminder part" XD

*Edit I'm not sure exactly how to work with timers havn't done that befor tbh, perhaps you could give a example on this matter...?

I Guess a periodic 1s trigger with a varaible turning on when its time but... meh...

Update v.0.9: The Gui version has the same features as the jass version. The jass version is now present in the test map and can be enabled for people with jassnewgenpack. Everything is now moved to one trigger. Hopefully this doesnt complicate things for the user.

~~Noticed I messed up the randomizer with the last update.~~
Seems like I misspelled matching ;p
~~I will reallow the first hint to be displayed along with the others and not just when hints are turned off.~~
Custom script: if udg_HINT_MIN_REMIND_TIME < timeSinceLastHint[i this line is missing a condition checking for active players.

Elprede · Feb 5, 2013

Will you be making any more major updates for this resource?

Magtheridon96 · Feb 5, 2013

The indentation is messed up.

edit
Also, since this is vJASS, you should probably use a vJASS initializer and wrap the vJASS code up inside a library.

(It's vJASS because you're using globals blocks and /* */ comments)

edit
Don't use TRUE and FALSE, use true and false.
The difference is that TRUE/FALSE are variables while true/false are direct values.

edit
The input strings should be configurable from the globals block.
(Same for the error strings and everything that can be changed by the user.)

edit
== TRUE and == true are the most redundant things ever.
You can remove them and nothing would happen.

Pinzu · Feb 6, 2013

Magtheridon96 said:
The indentation is messed up.

edit
Also, since this is vJASS, you should probably use a vJASS initializer and wrap the vJASS code up inside a library.

(It's vJASS because you're using globals blocks and /* */ comments)

Can't do those things my installation isnt allowing me to use those codes, and I havn't got around to reinstalling it.

Which one, the gui one or the jass one... both?

edit
Don't use TRUE and FALSE, use true and false.
The difference is that TRUE/FALSE are variables while true/false are direct values.

Okey, thanks for information.

edit
The input strings should be configurable from the globals block.
(Same for the error strings and everything that can be changed by the user.)

Hmm you sure about this? I mean it's in quotation marks, it should be straight forward. Could add a comment to make the user notice them? or I could add them in
Hint[0] is the reminder.
Hint[1] is the error message.
Hint[2] Enabled
Hint[3] disabled

Do you think that the gui version should be using normal DisplayPlayerGroup action instead of custom script so they can more easily understand what is going on? Or just add more documentation?

or as constants in the global tags but I dont find this to be needed? But if you insist upon it again I will change it.

edit
== TRUE and == true are the most redundant things ever.
You can remove them and nothing would happen.

Haha, I use them allways, didnt know this, thank you

GhostHunter123 said:
Will you be making any more major updates for this resource?

I'll remind you if I do.

Okey this is what I'm gonna add:
- randomizeOn boolean (Will merge the two options.)
- hideHint[] boolean => true hides it the next run and false puts it back in.
- If someone show me how to use timers I would use that instead of waits, oh well.
- gonna remove the TRUE/FALSE thing.
- gonna add a missing condition related to none-playing players.
- Should I add a boolean to enable/disable -hint commands and enable/disable "-hint xx" comand? or just instruct on how to remove it?

Magtheridon96 · Feb 6, 2013

Hmm you sure about this? I mean it's in quotation marks, it should be straight forward. Could add a comment to make the user notice them? or I could add them in
Hint[0] is the reminder.
Hint[1] is the error message.
Hint[2] Enabled
Hint[3] disabled

Do you think that the gui version should be using normal DisplayPlayerGroup action instead of custom script so they can more easily understand what is going on? Or just add more documentation?

or as constants in the global tags but I dont find this to be needed? But if you insist upon it again I will change it.

It's always better to keep the user away from your code and limit him to modifying only a specific part of it (In this case, the globals)

The hint string array should only be for hints.

What I was referring to is something along the lines of this:

JASS:

globals
    // A player must type this in order to enable hints.
    private constant string COMMAND_ON = "-hints on"
    // A player must type this in order to disable hints.
    private constant string COMMAND_OFF = "-hints off"
    // A player must type this followed by a number separated by a space 
    // in order to have a certain hint displayed.
    private constant string COMMAND_GET_HINT = "-hint"
    // This string is displayed sometimes to remind the player that 
    // he can disable/enable hints.
    private constant string ENABLE_DISABLE_REMINDER = "|cff995500Notice|r - You can enable/disable hints by typing '|cffffcc00-hints on|r/|cffffcc00off|r'"
    // This will be displayed if no valid hint is found when a player 
    // types -hint ##
    private constant string INVALID_HINT = "|cffff0000Error|r - No maching hint found."
    // etc....
endglobals

Pinzu · Feb 6, 2013

Magtheridon96 said:

It's always better to keep the user away from your code and limit him to modifying only a specific part of it (In this case, the globals)

The hint string array should only be for hints.

What I was referring to is something along the lines of this:

JASS:

globals
    // A player must type this in order to enable hints.
    private constant string COMMAND_ON = "-hints on"
    // A player must type this in order to disable hints.
    private constant string COMMAND_OFF = "-hints off"
    // A player must type this followed by a number separated by a space 
    // in order to have a certain hint displayed.
    private constant string COMMAND_GET_HINT = "-hint"
    // This string is displayed sometimes to remind the player that 
    // he can disable/enable hints.
    private constant string ENABLE_DISABLE_REMINDER = "|cff995500Notice|r - You can enable/disable hints by typing '|cffffcc00-hints on|r/|cffffcc00off|r'"
    // This will be displayed if no valid hint is found when a player 
    // types -hint ##
    private constant string INVALID_HINT = "|cffff0000Error|r - No maching hint found."
    // etc....
endglobals

Got it, will add it.

Almia · Feb 8, 2013

declaring globalsmakes the system not JASS but vJASS
This would be better if this includes game hints,hero(unit) hints,items hints,etc

Pinzu · Feb 8, 2013

Almia said:
declaring globalsmakes the system not JASS but vJASS
This would be better if this includes game hints,hero(unit) hints,items hints,etc

You mean I attach hints to a specific object?
hintId[Object] ="PALADIN"
hintListStart[Object]
hintListEnd[Object]
HintList[Just shuffle them after the start end of previous object]

Set currentHint[playerId] = "PALADIN"

JASS:

string array hintId
string array hintList
string array hintListEnd
string array hintListStart
string array currentHintId // Curret Hint Displayed for ( player Id )

set hintId[000] = "PALADIN"
set hintId[001] = "BLADEMASTER"
//...


set HintList[i] = "000 You have selected the Paladin, he is both a warrior and a healer, use your..."
set i = i + 1
set HintList[i] = "000 Your Holy light can also be used to damage enemy undead..."
set i = i + 1
set HintList[i] = "000 It can sometimes be useful to skill the aura..."
set i = i + 1
set HintList[i] = "001 The quickest way to dispatch enemies is through bladestorm..."
//...
/*After this i just loop through the different hints and identify their type 000 and 001 in this case link it to a start and end number.
And when I want to use i do this example: set currentHintId[GetPlayerId(GetTriggerPlayer())] = PALADIN     Thi would display hints from hintListStart[000] to hintLitEnd[000]*/

local integer previousId = -1
local integer currentId = 0
set i = 0
	loop
		set currentId = I2S(Substring(1,3, hintList[i])
			if currentId > previousId then
			set hintlistStart[currentId] = i
			set previusId = previousId + 1
				if currentId > 0 then
				set hintListEnd[currentId-1] = i - 1
				endif
			endif
	set i = i + 1
	exitwhen hintList[i] == null
	endloop

What you think?

Simple Hint Generator GUI or JASS 0.8

Hint Generator 0.9 (Map)

Moderator

Moderator

Similar threads