[JASS]Simple Hero Revival [v1.1d] -PLAIN JASS VERS

[Moderator]

11:24, 28th Feb 2011
Bribe:

A simple utility which could prove useful for GUI users.

 

[hell gate]

not bad but it would be much better in vJass (with usage of struct)
else the code looks fine for me but why do you set the counter for timers to count -1 and not +1? is better to understand

 

[D4RK_G4ND4LF]

not bad but it would be much better in vJass (with usage of struct)

https://www.hiveworkshop.com/forums/spells-569/vjass-simple-hero-revival-v1-1-gui-friendly-178809/?prev=search%3Dhero%2520revival%26d%3Dlist%26r%3D20
he even linked it in the description
anyway vjass would be worse for someone requesting a jass version wouldn't it?

imho it is a little bit overkill but it does what it's supposed to do

 

[baassee]

Hehe as G4ND4LF said the timers eh I just copied from The_Reborn_Devil

why is it overkill ?

 

[Mainy]

A bit confuse without documentation.

 

[baassee]

I think the documentation is sufficient, all you need to know is basically in the GUI example or the two functions, the one who starts it up and the finish. I didn't want to explain the little timer recycler

I'll gladly explain anything you want to know! Just ask.

 

[Bribe]

call FlushParentHashtable(udg_SHRS_Hashtable)

Breaks the system. Just don't do this.

 

[baassee]

call FlushParentHashtable(udg_SHRS_Hashtable)

Breaks the system. Just don't do this.

So it's true. Well I didn't have the experience with Hashtables though I noticed that no one ever used this even in vJASS. Oh well. You know why?

 

[Bribe]

FlushParentHashtable is to InitHashtable what DestroyTimer is to CreateTimer. It makes it unusable once called.

 

[baassee]

Ah alright. I'll fix it tomorrow.

 

[baassee]

Had totally forgotten to fix the parentflush. Now fixed.

 

[Bribe]

Looking at it further, the whole thing could use a nice optimization and bug correction, a bit of an API change because there is no reason to prefix HeroRevive and HeroReviveLoc as those are the functions, after all. If you prefix them, you may as well call it SHRS_ReviveHero and SHRS_ReviveHeroLoc.

function SHRS_Revive takes nothing returns nothing
    local integer id = GetHandleId(GetExpiredTimer()) //just for simpleness and no indexing
    //recycle the timer
    set udg_SHRS_Timers[udg_SHRS_N] = GetExpiredTimer()
    set udg_SHRS_N = udg_SHRS_N + 1
    //revive
    call ReviveHero(LoadUnitHandle(udg_SHRS_Hashtable, id, 1), LoadReal(udg_SHRS_Hashtable, id, 2), LoadReal(udg_SHRS_Hashtable, id, 3), LoadBoolean(udg_SHRS_Hashtable, id, 4))
    //flush the child keys of the id
    call FlushChildHashtable(udg_SHRS_Hashtable, id)
endfunction

function HeroRevive takes unit hero, real time, real x, real y, boolean eff returns nothing
    local timer t
    local integer id
    //the if below is just to protect the users from making mistakes
    if IsUnitType(hero, UNIT_TYPE_HERO) and IsUnitType(hero, UNIT_TYPE_DEAD) and GetUnitTypeId(hero) != 0 then
        // Simple timer recycling
        if (udg_SHRS_N == 0) then
            set t = CreateTimer()
        else
            set udg_SHRS_N = udg_SHRS_N - 1
            set t = udg_SHRS_Timers[udg_SHRS_N]
        endif
        set id = GetHandleId(t)
        // store unit
        call SaveUnitHandle(udg_SHRS_Hashtable, id, 1, hero)
        // store x coordinate
        call SaveReal(udg_SHRS_Hashtable, id, 2, x)
        // store y coordinate
        call SaveReal(udg_SHRS_Hashtable, id, 3, y)
        // store the boolean
        call SaveBoolean(udg_SHRS_Hashtable, id, 4, eff)
        // fire the timer
        call TimerStart(t, time, false, function SHRS_Revive)
        set t = null
    debug else
        // just a simple error message for those who don't understand the words dead and hero
        debug call DisplayTimedTextToPlayer(GetLocalPlayer(), 0, 0, 60, "SHRS Error - The unit is either not dead or is not a hero")
    endif
endfunction

// A location-wrapper for the above function
function HeroReviveLoc takes unit hero, real time, location loc, boolean eff returns nothing
    call SHRS_HeroRevive(hero, time, GetLocationX(loc), GetLocationY(loc), eff)
endfunction

 

[baassee]

Aight I'll fix it although why wrap loc function? One more call

 

[Bribe]

http://en.wikipedia.org/wiki/Duplicate_code

That, and it's harder to maintain different copies of the same thing. Imagine if you copied it five or six times over with minimal differences, then suddenly you need to fix a syntax error and you have to change all five or six. Just have one common function with as simple parameters as it gets, to handle all the dirty work.

For a GUI user, that one function call doesn't mean anything anyway. GUI users almost never care about BJ's, spamming the same "GetOwningPlayer(GetTriggerUnit())" over and over again. And if they did, they are probably on their way to JASS anyway.

 

[baassee]

Ah I get it. Will be fixed today.

EDIT:

Done.

 

[Bribe]

I just advise updating the triggers on this site as they still point to the old variable names, and:

Set SHRS_N = 0
Set SHRS_Timers[0] = (Last started timer)

Both are unnecessary. SHRS_Timers[0] does not need to be initialized as the script automatically does that, and SHRS_N is automatically set in GUI's InitGlobals function to 0.

 

[baassee]

It's not for initializing, it's to create the variables for GUI users. When you paste that trigger, they're automatically created.

 

[Bribe]

Did you at least disable them in the trigger itself? (sorry can only access wc3 when i'm at home so I can't check)

 

[baassee]

The trigger might be enabled yes, I have to check.

EDIT:

What do you mean with disable them in the trigger itself? You cannot disable variables or?

Anyway the best option would be to have a second trigger where those are created due to that the hashtable is created in the first create trigger.

 

[Bribe]

You can disable individual actions in a trigger by right-click on the actions and select disable from the drop-down menu.

 

[baassee]

You can disable individual actions in a trigger by right-click on the actions and select disable from the drop-down menu.

I see. Updating the new version. Also discovered another horrifying bug. Never set an event at the create trigger and the hashtable never got created.

 

[Magtheridon96]

hey! This is the system you posted at that thread for another revive system. I was using the system you gave me in that thread, but i had to change it so that it would accept x and y loc parameters. Do you really think i have to use this version? Either way, i'll update it

 

[baassee]

accept x and y loc parameters? do you know what you are talking about? I have two functions, one taking a loc and the other taking coordinates

gui example uses the loc wrapper

 

[Magtheridon96]

I was actually talking about the one you posted in that thread, not this one. Yeah i know what i'm talking about, i didn't use the x and y parameters, i used a location parameter and i set the real x = GetLocationX(loc) or wtvr that function was idk i'm a noob at JASS ... same for the real y.

 

[baassee]

oh the crappy one? this is 100 hundred times better

 

[chanckaka]

Hello, my jasshelper got a error that " Undeclared identifier 'HeroReviveLoc' ", how can I fix it? Thanks!

 

[baassee]

It may be that it isn't in a library. If you're using vJASS, use the vJASS version.