Sage's Lore [1.7]

[Moderator]

09:18, 20th Jul 2011
Maker:
Approved.
Fix the tooltips.
In the importing instructions, mention that one need to set the dummy unit type in Unit - Create dummy. You could create a variable for the dummy unit type, and set it in the init trigger.

 

[Magtheridon96]

It looks pretty good
GUI always hurts my eyes, but surprising, looking at your triggers didn't hurt at all ^^
4/5

edit
In the second trigger, for efficiency, you could save (Picked Unit) in a variable so you don't have to repeatedly call GetEnumUnit()
For the Key(Picked Unit) part, you should save the picked unit's handle in an integer variable.

 

[Vengeancekael]

Hmm so you mean like that?

Hidden

• Sages Lore Over Time
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • -------- DO NOT EDIT BELOW --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (SL_UnitGroup is empty) Equal to False
      • Then - Actions
        • Unit Group - Pick every unit in SL_UnitGroup and do (Actions)
          • Loop - Actions
            • Set SL_PickedUnit = (Picked unit)
            • Set SL_PickedUnitInt = (Key (Picked Unit))
        • Set SL_Caster = (Load 0 of SL_PickedUnitInt in SL_CasterHashtable)
        • Set SL_LoadDuration = (Load 1 of SL_PickedUnitInt from SL_CasterHashtable)
        • -------- Units that still have the Sage's Lore Buff will take damage --------
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • SL_LoadDuration Greater than 0.00
          • Then - Actions
            • Hashtable - Save (SL_LoadDuration - 1.00) as 1 of SL_PickedUnitInt in SL_CasterHashtable
            • -------- Position of unit that has buff --------
            • Set SL_Point = (Position of (Picked unit))
            • -------- Effects --------
            • Special Effect - Create a special effect at SL_Point using Abilities\Spells\Other\Silence\SilenceAreaBirth.mdl
            • Special Effect - Destroy (Last created special effect)
            • -------- Effects --------
            • -------- Damage --------
            • Set SL_DamageLoad = (Load 2 of SL_PickedUnitInt from SL_CasterHashtable)
            • Unit - Cause SL_Caster to damage (Picked unit), dealing SL_DamageLoad damage of attack type Spells and damage type Normal
            • Unit - Set mana of (Picked unit) to ((Mana of (Picked unit)) - SL_DamageLoad)
            • -------- Damage --------
            • -------- Remove Leaks --------
            • Custom script: call RemoveLocation(udg_SL_Point)
          • Else - Actions
            • Unit Group - Remove (Picked unit) from SL_UnitGroup
            • Custom script: call UnitRemoveAbility (GetEnumUnit(), udg_SL_ABILITYID)
            • Hashtable - Clear all child hashtables of child SL_PickedUnitInt in SL_CasterHashtable
      • Else - Actions
        • Trigger - Turn off (This trigger)

 

[Magtheridon96]

Sort of... But all the code that involves the picked unit should be under the loop (Pick every unit...)

edit
You shouldn't change anything at all when it comes to the structure in the current version, just create 2 new variables:
- Unit: PickU
- Integer: PickI

In the Pick every unit block, just set those variables to PickedUnit and GetHandleId(udg_PickedUnit) respectively.
Then use those variables everywhere below

 

[Vengeancekael]

Wow I didn't understand a thing you just said, but that's probably because it's 2:00 and I'm also asleep. I guess I'll have to look at the trigger tomorrow morning.

 

[Magtheridon96]

It's 3 AM here btw
If I can concentrate, then you should be able to do that too ^^
I'm guessing you're either from Greece, Romania, or Ukraine .. maybe Russia =P (possible Slovenia)

 

[Vengeancekael]

Luxembourg :/
I'm looking at it again now.

Edit

Wait so the 'GetHandleId(udg_PickedUnit)' part, is that string id or handle id, cuz I'd have to make a handle variable if it was a handle id.
Or are you saying I should use custom script

 

[Magtheridon96]

The handle id is an integer.

 

[Vengeancekael]

Could you show me the action? I'm kinda confused

 

[Magtheridon96]

PickUnitId is an integer
PickedUnit is a unit

• Custom script: set udg_PickedUnit = GetEnumUnit()
• Custom script: set udg_PickUnitId = GetHandleId(udg_PickedUnit)

Then, instead of using (Picked Unit), you would use udg_PickedUnit
and instead of Key(Picked Unit), you would use udg_PickUnitId

 

[Vengeancekael]

Oh so you did mean custom scripts lol
Edit: Updated, thanks Magtheridon

 

[Magtheridon96]

You could probably do the same thing for Key(Picked Unit) in the first trigger.
Same for (Picked Unit)
Also, instead of repeating (Triggering Unit), you could save it in a variable to increase efficiency.
Let's see ... Owner of Triggering Unit is the same as Triggering Player
In the third trigger, you should also save triggering unit in a variable

 

[Vengeancekael]

Good grief, updated.

 

[Magtheridon96]

There are some things that could be improved.
Save (Last Created Unit) in a variable in the first trigger (Do the same thing ANYWHERE if you're repeating the same "function")
Move the Set SL_Duration = 6.00 line to another trigger that will run at map initialization.

In the third trigger, in the custom script, don't use GetTriggerUnit(). Change it to udg_SLCastingUnit.
After that, this spell should be good to go

 

[mckill2009]

may I also suggest to make attack damage/damage type/AoE /duration/sfx and base damage configurables?...

 

[baassee]

Custom script: set udg_SL_PickUnits = GetEnumUnit()

No need to be custom script, there is one in GUI that is equal to this.

Unit - Order (Last created unit) to Orc Shaman - Bloodlust (Picked unit)

You forgot to cast it at your variable.

-You can of course set the last created unit into a variable as well. Will save you a few calls as it calls "GetLastCreatedUnit()" BJ which only returns a variable.

-This Set SL_CastingUnit = (Triggering unit)

Should be above this Set SL_ID = (Key (Triggering Unit))

-Doesnt use its variable

Custom script: call UnitRemoveAbility (GetTriggerUnit(), udg_SL_ABILITYID)

 

[Vengeancekael]

welp back to work
Edit: woosh

 

[mckill2009]

now that's better 5/5...

 

[Vengeancekael]

woop woop :3

 

[Magtheridon96]

Ok Vengeancekael, sorry I forgot to mention this earlier, but:

• Custom script: call UnitRemoveAbility (GetEnumUnit(), udg_SL_ABILITYID)

Instead of GetEnumUnit(), you could use udg_SL_PickedUnit

I know.. updating for something that small is annoying, but efficiency is important :L

edit
By the way, I changed my rating to 5/5

 

[mauricio]

Hey! Grateful if you tell me how to make my own characters. Thank you.

 

[Vengeancekael]

boom updated

Hey! Grateful if you tell me how to make my own characters. Thank you.

What?

 

[mckill2009]

@mauricio
do not double post, use the edit button or better read the rules here at hive!...

 

[Maker]

Use a custom dummy, the current one gives visibility and has cast point of 0.3 for example. AoE should be real.

 

[Vengeancekael]

Will do.
edit: updated

 

[Magtheridon96]

This is my favorite spell.
The simplest, the cleanest, the shortest and hence the greatest.

Good job Kelly.
We love you <3
Now go make more spells D:<

 

[Almia]

Heroes of Newerth