- Joined
- Nov 2, 2004
- Messages
- 1,993
Submitted to Spells section: http://www.hiveworkshop.com/forums/spells-569/revivable-units-v1-0-a-275071/
Last edited:
-
Listen to a special audio message from Bill Roper to the Hive Workshop community (Bill is a former Vice President of Blizzard Entertainment, Producer, Designer, Musician, Voice Actor) 🔗Click here to hear his message!
-
Read Evilhog's interview with Gregory Alper, the original composer of the music for WarCraft: Orcs & Humans 🔗Click here to read the full interview.
[JASS] Revivable Units
- Joined
- Mar 18, 2012
- Messages
- 1,716
You produce handle leaks. A lot of handle leaks.
For initializing your stuff, you should can use the vJass keyword "initializer".
For my point of view your code looks a bit hardcoded.
Furthermore it would be nice if you attach a demo map to the script,
so we can get the ingame purpose, quickly.
Finally I think this is more fitting for the spell section than the JASS submission.
For initializing your stuff, you should can use the vJass keyword "initializer".
For my point of view your code looks a bit hardcoded.
Furthermore it would be nice if you attach a demo map to the script,
so we can get the ingame purpose, quickly.
Finally I think this is more fitting for the spell section than the JASS submission.
- Joined
- Nov 2, 2004
- Messages
- 1,993
I think I fixed all the leaks?
Implemented initializer. Also restructured a bit.
Not sure what you mean when you say it looks hard-coded?
Attached a demo map and updated code. Should I submit this to Spells instead then?
Implemented initializer. Also restructured a bit.
Not sure what you mean when you say it looks hard-coded?
Attached a demo map and updated code. Should I submit this to Spells instead then?
- Joined
- Sep 26, 2009
- Messages
- 9,534
JASS submissions need to be in
tags or linked to on Github.
JASS:
- Joined
- Nov 2, 2004
- Messages
- 1,993
Uhm this thread can be deleted =)
