Repeated sound not being played?

[Pinzu]

            ...
            if (GetLocalPlayer() == Player(i)) then
                call PlaySoundBJ(gg_snd_WAR)
            endif
            ...
            if (...) then 
                if (GetLocalPlayer() == Player(p)) then
                    call PlaySoundBJ(gg_snd_WAR)
                endif
            endif

I play this sound, but if I type the command when this is to be played fast enough it is silent I think its because the last sound isn’t finnished yet. Do I need to create a local sound to metigate this? (I want the new sound to be played over or instead of the old.) How do I do that?
Also, is there anything else related to playing sounds for 1 player or about sounds in general that is missing in my few lines of code?

Trigger 1 (sound is played)
Trigger 2 (I typed so fast that no sound is played)
Trigger 3 (sound is played again, enough time has passed)

 

[Malhorne]

You stop the previous and you play the new ^^'
Btw don't use the BJ for PlaySound

 

[Pinzu]

You stop the previous and you play the new ^^'
Btw don't use the BJ for PlaySound

I couldn't figure out the native so I used BJ.

 

[PurgeandFire]

You can stop the previous one and play the new (as Malhorne said), or you can use 3D sounds. But the sound must match particular specifications to work as 3D, and 3D sounds behave as 3D (louder in one particular area, quieter away from that point).

 

[Pinzu]

But to stop a sound I need to Store the LastCreatedSound? As you can see two players here the same sound every time. Im confused.

            ...
            if (GetLocalPlayer() == Player(i)) then
                call StopSoundBJ(gg_snd_WAR, false)
                call PlaySoundBJ(gg_snd_WAR)
            endif
            ...
            if (...) then 
                if (GetLocalPlayer() == Player(p)) then
                    call StopSoundBJ(gg_snd_WAR, false)
                    call PlaySoundBJ(gg_snd_WAR)
                endif
            endif

It just doesn't feel right using gg_snd_WAR there is no problem playing it for more then 1 player?

 

[Malhorne]

IIRC there is something called KillSound, or StopSound or something like this.
But yes you need to store the sound

Oh god too much time without hive made me rusty

 

[Pinzu]

How would I make it MPI then?

 

[Malhorne]

You want a sound for each player ?
You don't want the sound to be shared among all the players ?

 

[Pinzu]

You want a sound for each player ?
You don't want the sound to be shared among all the players ?

nope its 1 for each.

 

[Malhorne]

So use the getLocalPlayer(), but it might desync I dunno...

 

[PurgeandFire]

But to stop a sound I need to Store the LastCreatedSound? As you can see two players here the same sound every time. Im confused.

            ...
            if (GetLocalPlayer() == Player(i)) then
                call StopSoundBJ(gg_snd_WAR, false)
                call PlaySoundBJ(gg_snd_WAR)
            endif
            ...
            if (...) then 
                if (GetLocalPlayer() == Player(p)) then
                    call StopSoundBJ(gg_snd_WAR, false)
                    call PlaySoundBJ(gg_snd_WAR)
                endif
            endif

It just doesn't feel right using gg_snd_WAR there is no problem playing it for more then 1 player?

The way you did it is correct. You don't need to store the last created sound or anything like that.

In general, sounds are usually created once at the start of the map and used consistently throughout the map. Your code is MPI because it is stopping the sound locally and playing it locally. So let's say Player 1 and Player 2 both play the sound. If player 1 types in the command again, his sound will stop and start again, but nothing will happen for Player 2. As such, there is no potential for collision.

 

[Pinzu]

Ok thanks you two. And this would be the native:

                call StopSound(gg_snd_WAR, false, false) 
                call StartSound(gg_snd_WAR)

 

[Bannar]

Yes, it's even more conenient to use those natives instead of BJ relatives. Also consider that recursive calls are costly in jass.