Region System 1.0

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

19th Jul 2011
Bribe:

Game - Display to (Player group((Owner of (Triggering unit))))

- Leaks the player group

You do this multiple times

You never remove these locations:

Set Region_Point1[Region_Count] = (Position of (Triggering unit))
Set Region_Point2[Region_Count] = (Position of (Target unit of ability being cast))

This resource doesn't seem useful based on the description.

Building something just because it doesn't exist does not merit
that it's useful. You should only build something if you need it.

 

[Magtheridon96]

Don't use (Integer A)/(Integer B). It is inefficient, use a variable instead.

Actually, the reason we don't use Integer A/Integer B is because certain bugs could occur with them

 

[Zanekok]

Actually, the reason we don't use Integer A/Integer B is because certain bugs could occur with them

Never happend to me

Please post the triggers in [TRIGGER][/TRIGGER] tags.

Don't use (Integer A)/(Integer B). It is inefficient, use a variable instead.

You constantly use (Target of Ability Cast) in conditions. Set it to a variable to be more efficient.

(Owner of (Casting Unit)) -> Triggering Player
(Owner of (Triggering Unit)) -> Triggering Player

I don't see a recycling method, nor do I see a way to permanently remove the indexed locations/regions. This is likely a memory leak.

Why do i have to set it to variable? Units dont leak...

 

[Zanekok]

OK elseway do you think it could be useful for something?

 

[Magtheridon96]

Its more efficient, meaning that it will generate less lag when cast. The more efficient the spell is, the better it is.

Yeah it's more efficient, but the main reason we don't use Integer A/Integer B is so that we avoid a rare bug.
JassHelper will inline GetForLoopIndexA() anyways

 

[Adiktuz]

this is bad as you didn't add a method to remove an existing region which can lead to memory leaks...

 

[Zanekok]

this is bad as you didn't add a method to remove an existing region which can lead to memory leaks...

Are you kidding me?! What about "Break Region" or "Self Destruct"? They do this...

 

[Adiktuz]

nope, I only see you clearing/resetting/recycling the variables, but I never saw you Destroying the regions themselves...

and also, looping thru the indexes just to get the index of the caster is a pretty bad idea... why not save the index into a hashtable?

also, Player Group(Owner of blahblah) will cause a player group leak... There is a function to show text to a player only...

as for the units, its better to set them into variables for performance... as TriggeringUnit etc are function calls, which are slower than variables...

 

[Zanekok]

I am not leaking at all. When i'm recycling it the last one sets it self on NULL so its get removed. Or NULL is leaking? I havent find that to show to play only :/ But fine And Hashtables- yes i would like to but i cant work with them Come to chat you may teach me

 

[Adiktuz]

setting a variable to null does not clear a leak (aside from leaks with local vars)... because the region leak happens when you create a region and then not destroying it when you dont need it anymore, the same as with location leaks (which is why we use RemoveLocation afterwards)...

there is Display Text to Player...

 

[Zanekok]

Ok so I know about RemoveLocation, DestroyForce but about removing region? it is DestroyRegion or RemoveRegion? Also setting to NULL must "delete" it because when you "remove" it it becomes NULL

 

[Adiktuz]

Setting a variable to null, just removes the link of the variable to the object, but it leaves the object there on the game... that's the difference between destroying the object and nulling the variable...

example for unit vars

Set Temp = Unit

Set Temp = Null won't remove the unit... the unit stays there, while Temp is now unlinked meaning it don't reference anything anymore

while

RemoveUnit(Temp); assuming we do this before Set Temp = null, will remove the unit, so logically, Temp will now reference an object which does not exist anymore, which is why it automatically returns null...

 

[Zanekok]

Aha but i dont want to remove units. Only in self destruct and there i do Just come to the chat and teach me something (This template's site is becoming chat xD)

 

[Adiktuz]

That's just an example of how different setting a variable to null is with actually destroying/removing the object that it refers to, it was never meant to be specific for this spell... and for hashes, there are tuts for that...

 

[Zanekok]

i need someone to explain that i was reading it many times and i have nothing from it :/

 

[Bannar]

Go to tutorial section in GUI/triggers, there is ton of hashtable/indexing/how to MUI your spells/systems.

This is very simple peace of code, and still requires a lot work to go.
You used my import map i see =) I said, you should make sure everything is fine before uploading it, i see you did not.

For removing region use: Custom script: DestroyRect (udg_your_region).

 

[Zanekok]

I checked what i ned to and it works Dont know what is not fine. OK it is "leaking" but other things?

 

[Magtheridon96]

Variables are only pointers.
Setting them to null will set the pointer to 0 meaning that this variable does not represent any value (null)