[Trigger] Ranking buff for units gone wrong.

[Superfrycook]

When I make a custom race, a custom unit (which is a killing unit) receives a rank buff, but the buff belongs to dying unit. Feel free to ask, TY.

 

[Chaosium]

Can you show the "run sergeant rank" trigger? I suspect there is a "triggering unit" somewhere and in this case = the unit that died

 

[Superfrycook]

Here:

 

[Chaosium]

I mean the contents of the trigger

 

[Superfrycook]

 

[Uncle]

Here:

Please post your triggers instead of using screenshots

How To Post Your Trigger

TopHow To Post Your Triggers I've seen many members across the site—especially newcomers—who need help with their triggers but don't know how to properly post them in a thread. Posting your triggers clearly is very important when you're asking others for help in fixing or identifying issues...

www.hiveworkshop.com

 

[Superfrycook]

• Ranking to Sergeant
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Killing unit) belongs to an enemy of (Owner of (Dying unit)).) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Killing unit) belongs to an enemy of (Owner of (Dying unit)).) Equal to True
        • (Level of Ascension Rank for (Killing unit)) Less than 1
      • Then - Actions
        • Unit - Set level of Ascension Rank for (Killing unit) to ((Level of Ascension Rank for (Killing unit)) + 1)
      • Else - Actions
        • Trigger - Run Sergeant Rank <gen> (checking conditions)
        • Unit - Increase level of Ascension Rank for (Killing unit)

 

[Superfrycook]

And this:

• Ranking to Lieutenant
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
        • (Level of Ascension Rank for (Killing unit)) Less than 5
      • Then - Actions
        • Unit - Set level of Ascension Rank for (Killing unit) to ((Level of Ascension Rank for (Killing unit)) + 1)
      • Else - Actions
        • Special Effect - Destroy Sergeant
        • Wait 0.50 seconds
        • Unit - Increase level of Ascension Rank for (Killing unit)
        • Trigger - Run Lieutenant Rank <gen> (checking conditions)

 

[Daffa]

You need to show the other trigger, the Sergeant Rank trigger, not the Ranking to Sergeant trigger.

 

[Superfrycook]

Everytime when a player unit kills an enemy, it grants a promotion, means increasing attack damage. Here are the rest:

• Ranking to Lieutenant
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
        • (Level of Ascension Rank for (Killing unit)) Less than 5
      • Then - Actions
        • Unit - Set level of Ascension Rank for (Killing unit) to ((Level of Ascension Rank for (Killing unit)) + 1)
      • Else - Actions
        • Special Effect - Destroy Sergeant
        • Wait 0.50 seconds
        • Unit - Increase level of Ascension Rank for (Killing unit)
        • Trigger - Run Lieutenant Rank <gen> (checking conditions)

• Ranking to Captain
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
        • (Level of Ascension Rank for (Killing unit)) Less than 10
      • Then - Actions
        • Unit - Set level of Ascension Rank for (Killing unit) to ((Level of Ascension Rank for (Killing unit)) + 1)
      • Else - Actions
        • Special Effect - Destroy Lieutenant
        • Wait 0.50 seconds
        • Unit - Increase level of Ascension Rank for (Killing unit)
        • Trigger - Run Captain Rank <gen> (checking conditions)

• Ranking to Major
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
        • (Level of Ascension Rank for (Killing unit)) Less than 15
      • Then - Actions
        • Unit - Set level of Ascension Rank for (Killing unit) to ((Level of Ascension Rank for (Killing unit)) + 1)
      • Else - Actions
        • Special Effect - Destroy Captain
        • Wait 0.50 seconds
        • Unit - Increase level of Ascension Rank for (Killing unit)
        • Trigger - Run Major Rank <gen> (checking conditions)

• Ranking to General
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Triggering unit) belongs to an enemy of (Owner of (Killing unit)).) Equal to True
        • (Level of Ascension Rank for (Killing unit)) Less than 20
      • Then - Actions
        • Unit - Set level of Ascension Rank for (Killing unit) to ((Level of Ascension Rank for (Killing unit)) + 1)
      • Else - Actions
        • Special Effect - Destroy Major
        • Wait 0.50 seconds
        • Unit - Increase level of Ascension Rank for (Killing unit)
        • Trigger - Run General Rank <gen> (checking conditions)

 

[Daffa]

Trigger - Run Lieutenant Rank <gen> (checking conditions)

Show Lieutenant Rank, because you only show Ranking to Lieutenant.

The ones you share doesn't exhibit any problem, so the ones you don't share is likely the source of the problem

 

[Superfrycook]

• Lieutenant Rank
  • Events
  • Conditions
  • Actions
    • Special Effect - Create a special effect at (Position of (Killing unit)) using RankSnoutII_v2.mdx
    • Set VariableSet Lieutenant = (Last created special effect)

 

[Daffa]

This effect will bug out if there's more than one unit promoted on the same rank. Another thing is the Position of Killing Unit might be loss during the wait.

 

[Superfrycook]

So if a player unit kills an enemy, it gains a promotion buff on the overhead attachment and when a player unit dies, the attachment disappear.

 

[Superfrycook]

Or this:

• Rank to Sergeant
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Dying unit)) Not equal to (Owner of (Killing unit))
  • Actions
    • Set VariableSet SergeantKills = (SergeantKills + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • SergeantKills Less than 1
      • Then - Actions
        • Unit - Set level of Ascension Rank for (Killing unit) to 1
        • Trigger - Run Sergeant <gen> (checking conditions)
      • Else - Actions

• Rank to Lieutenant
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Dying unit)) Not equal to (Owner of (Killing unit))
  • Actions
    • Set VariableSet LieutenantKills = (LieutenantKills + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • LieutenantKills Less than 5
      • Then - Actions
        • Special Effect - Destroy Sergeant
        • Wait 0.50 seconds
        • Unit - Set level of Ascension Rank for (Killing unit) to 2
        • Trigger - Run Lieutenant <gen> (checking conditions)
      • Else - Actions

• Rank to Lieutenant
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Dying unit)) Not equal to (Owner of (Killing unit))
  • Actions
    • Set VariableSet LieutenantKills = (LieutenantKills + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • LieutenantKills Less than 5
      • Then - Actions
        • Special Effect - Destroy Sergeant
        • Wait 0.50 seconds
        • Unit - Set level of Ascension Rank for (Killing unit) to 2
        • Trigger - Run Lieutenant <gen> (checking conditions)
      • Else - Actions

• Rank to Captain
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Dying unit)) Not equal to (Owner of (Killing unit))
  • Actions
    • Set VariableSet CaptainKills = (CaptainKills + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • CaptainKills Less than 10
      • Then - Actions
        • Special Effect - Destroy Lieutenant
        • Wait 0.50 seconds
        • Unit - Set level of Ascension Rank for (Killing unit) to 3
        • Trigger - Run Captain <gen> (checking conditions)
      • Else - Actions

• Rank to Major
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Dying unit)) Not equal to (Owner of (Killing unit))
  • Actions
    • Set VariableSet MajorKills = (MajorKills + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • CaptainKills Less than 15
      • Then - Actions
        • Special Effect - Destroy Captain
        • Wait 0.50 seconds
        • Unit - Set level of Ascension Rank for (Killing unit) to 4
        • Trigger - Run Major <gen> (checking conditions)
      • Else - Actions

• Rank to General
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Dying unit)) Not equal to (Owner of (Killing unit))
  • Actions
    • Set VariableSet GeneralKills = (GeneralKills + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • GeneralKills Less than 20
      • Then - Actions
        • Special Effect - Destroy Major
        • Wait 0.50 seconds
        • Unit - Set level of Ascension Rank for (Killing unit) to 5
        • Trigger - Run General <gen> (checking conditions)
      • Else - Actions

 

[Superfrycook]

Or even this:

• Ascension Rank Kills Gain Attack Speed
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Dying unit)) Not equal to (Owner of (Killing unit))
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Level of Ascension Rank (Attack Speed) for (Killing unit)) Equal to 1
      • Then - Actions
        • Player - Enable Ascension Rank (Attack Speed) for (Owner of (Killing unit))
        • Wait 0.50 seconds
        • Unit - Set level of Ascension Rank (Attack Speed) for (Killing unit) to 1
        • Trigger - Run Sergeant <gen> (checking conditions)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Ascension Rank (Attack Speed) for (Killing unit)) Equal to 3
          • Then - Actions
            • Unit - Set level of Ascension Rank (Attack Speed) for (Killing unit) to 2
            • Trigger - Run Lieutenant <gen> (checking conditions)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Level of Ascension Rank (Attack Speed) for (Killing unit)) Equal to 5
              • Then - Actions
                • Unit - Set level of Ascension Rank (Attack Speed) for (Killing unit) to 3
                • Trigger - Run Captain <gen> (checking conditions)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Level of Ascension Rank (Attack Speed) for (Killing unit)) Equal to 7
                  • Then - Actions
                    • Unit - Set level of Ascension Rank (Attack Speed) for (Killing unit) to 4
                    • Trigger - Run Major <gen> (checking conditions)
                  • Else - Actions
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Level of Ascension Rank (Attack Speed) for (Killing unit)) Equal to 10
                      • Then - Actions
                        • Unit - Set level of Ascension Rank (Attack Speed) for (Killing unit) to 5
                        • Trigger - Run General <gen> (checking conditions)
                      • Else - Actions