Listen to a special audio message from Bill Roper to the Hive Workshop community (Bill is a former Vice President of Blizzard Entertainment, Producer, Designer, Musician, Voice Actor) 🔗Click here to hear his message!
Hey everyone, I was working on my orb craft project and I've found that only the first 3 units that enter this region get a hero. WHY!?
[hidden="trigger]
HRandom
Events
Unit - A unit enters HRandom <gen>
Conditions
(Unit-type of (Entering unit)) Equal to Sceleton
Actions
Unit - Remove (Entering unit) from the game
Unit - Create 1 (Unit-type of (Random unit from HRandom)) for (Owner of (Entering unit)) at ((Owner of (Entering unit)) start location) facing (Center of (Playable map area))
Camera - Pan camera for (Owner of (Entering unit)) to (Position of (Last created unit)) over 0.00 seconds
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
((Entering unit) is in AI) Equal to True
Then - Actions
Unit Group - Remove (Entering unit) from AI
Unit Group - Add (Last created unit) to AI
Else - Actions
Set Hero[(Player number of (Owner of (Entering unit)))] = (Last created unit)
this leaks, always put positions into variables then clean them up. Same for
(Position of (Last created unit)
Also, both the entering event and the pool of heroes is HRandom. This means that the unit may be replaced by himself (unless HRandom is both a region and a unit array?).
So try it like this:
HRandom
Events
Unit - A unit enters HRandom <gen>
Conditions
(Unit-type of (Triggering unit)) Equal to Sceleton
Actions
Set TempLoc = Position of (Triggering unit)
Unit - Remove (Triggering unit) from the game
Unit - Create 1 (Unit-type of (Random unit from RandomUnitPool)) for (Owner of (Triggering unit)) at (TempLoc) facing (Center of (Playable map area))
Camera - Pan camera for (Owner of (Triggering unit)) to (TempLoc) over 0.00 seconds
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
((Triggering unit) is in AI) Equal to True
Then - Actions
Unit Group - Remove (Entering unit) from AI
Unit Group - Add (Last created unit) to AI
Else - Actions
Set Hero[(Player number of (Owner of (Triggering unit)))] = (Last created unit)
Custom script: call RemoveLocation( udg_TempLoc )
Also, for this you obviously have to use a trigger to preload the content of RandomUnitPool when the map loads. You should use unit type array for this, but no WE installed, so I can't really create that part, so I just used a unit array. This change may also solve the entire problem, not sure.
EDIT: Entering unit -> Triggering unit
Thanks to deathismyfriend for the heads-up!
never use entering unit. use triggering unit instead. also anything u use twice or more like the entering unit store into a variable and use that instead.
I don't think that leaks.
As I understand the logic of leaks, a memory leak occurs when you create *something* that takes up a bit of your PC's memory space and you're unable to remove it.
So when I create unit at "position of (Triggering unit)", I basically create a location "position of (Triggering unit)" which takes up my space. If I don't save that location into variable firsthand, I will have no way to call that location later to remove it, hence it will cause a memory leak (i.e. as long as I will continue playing that map, that location will remain in game, taking up space in memory).
However start location is created upon map ini, it is set up by map maker, you can easily call it whenever you need it and when you use it, you don't create new (start) location. That makes me believe it does not leak.
Kanadaj may have meant either:
a) simply upon map ini create unit and remove it
or
b) make a trigger that fires upon map ini, which saves a list of your HRandom heroes. Something like
Event
Map Initialization
Actions
Set RandomHero[1] = Archmage
Set RandomHero[2] = Blood Mage
etc.
You then use the integer function Math - Random Number and create unit-type equal to RandomHero[Random number between 1 and X] where X is the highest Index in the hero list.
True... As I havent really touched WE for some tim,e I forgot about the starting locations ^^ I wonder if cleaning up starting location causes problems
And yea, I meant the second version where you create an array of heroes (unit type) at map initialization.
Theres chaos in my triggers. Trust me, no one wants to search it through
Anyways problem solved...
HRandom Copy
Events
Unit - A unit enters HRandom <gen>
Conditions
(Unit-type of (Entering unit)) Equal to Sceleton
Actions
Set Temp_Player = (Owner of (Triggering unit))
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
((Triggering unit) is in AI) Equal to True
Then - Actions
Unit Group - Remove (Entering unit) from AI
Unit - Remove (Triggering unit) from the game
Unit - Create 1 HeroType[(Random integer number between 1 and 16)] for Temp_Player at (Temp_Player start location) facing (Center of (Playable map area))
Unit Group - Add (Last created unit) to AI
Else - Actions
Unit - Remove (Triggering unit) from the game
Unit - Create 1 HeroType[(Random integer number between 1 and 16)] for Temp_Player at (Temp_Player start location) facing (Center of (Playable map area))
Set Hero[(Player number of (Owner of (Entering unit)))] = (Last created unit)
the problem must've been somewhere else then, because in the test map I attached in my previous post it worked fine (looking at the difference between your two triggers, I guess the problem was in the HRandom group itself)
Yeah I deleted the varible to see witch triggers was using it. There was only two; the one where I pick the heros in two regions and add them to HRandom and then ofcourse the one I've posted. I have no idea what happend...
I don't think that leaks.
As I understand the logic of leaks, a memory leak occurs when you create *something* that takes up a bit of your PC's memory space and you're unable to remove it.
So when I create unit at "position of (Triggering unit)", I basically create a location "position of (Triggering unit)" which takes up my space. If I don't save that location into variable firsthand, I will have no way to call that location later to remove it, hence it will cause a memory leak (i.e. as long as I will continue playing that map, that location will remain in game, taking up space in memory).
However start location is created upon map ini, it is set up by map maker, you can easily call it whenever you need it and when you use it, you don't create new (start) location. That makes me believe it does not leak.
that does leak. it basically creates a new location everytime its called. not sure y blizzard made it like this.
@TO
never use entering unit use triggering unit. also anything u use twice or more store into a variable and use that. it is a huge efficiency boost when u use the variable.
also preloading units just create them then remove them when game is started.
that does leak. it basically creates a new location everytime its called. not sure y blizzard made it like this.
@TO
never use entering unit use triggering unit. also anything u use twice or more store into a variable and use that. it is a huge efficiency boost when u use the variable.
also preloading units just create them then remove them when game is started.
This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.
HRandom
Events
Unit - A unit enters HRandom <gen>
Conditions
(Unit-type of (Entering unit)) Equal to Sceleton
Actions
Camera - Pan camera for (Owner of (Entering unit)) to (Position of (Last created unit)) over 0.00 seconds
Unit Group - Remove (Entering unit) from AI
Set Hero[(Player number of (Owner of (Entering unit)))] = (Last created unit)
