[Solved] Race setup

[sarumanthecursed]

Hi all > Hope your mothers had a good mother's day weekend. I'm trying to set up a system where if any player is human their townhall and peasants are replaced by my custom ones. Here's what i've got:

• Free Peoples Race Setup
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set Group1 = (Units owned by (Picked player) of type Peasant)
    • Set Group2 = (Units owned by (Picked player) of type Town Hall)
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Race of (Picked player)) Equal to Human
          • Then - Actions
            • Unit Group - Pick every unit in Group1 and do (Actions)
              • Loop - Actions
                • Unit - Replace (Picked unit) with a Worker - War Mode using The old unit's relative life and mana
            • Unit Group - Pick every unit in Group2 and do (Actions)
              • Loop - Actions
                • Unit - Replace (Picked unit) with a Stronghold Level 1 using The old unit's relative life and mana
          • Else - Actions
    • Custom script: call DestroyGroup (udg_Group1)
    • Custom script: call DestroyGroup (udg_Group2)

 

[Jampion]

You can use (Picked player) only inside a player group, so you want to move them inside the player group.
Other than that it should be fine.

Make sure though, that the units that are replaced exist. The action, that creates them (Melee - Create Starting units ....) must run before this trigger.

 

[sarumanthecursed]

You can use (Picked player) only inside a player group, so you want to move them inside the player group.
Other than that it should be fine.

Make sure though, that the units that are replaced exist. The action, that creates them (Melee - Create Starting units ....) must run before this trigger.

Alright so i made the player group (don't know if i need to destroy it after?) and changed the event but, I still can't get the units to be replaced

• Free Peoples Race Setup
  • Events
    • Time - Elapsed game time is 5.00 seconds
  • Conditions
  • Actions
    • Set Group1 = (Units owned by (Picked player) of type Peasant)
    • Set Group2 = (Units owned by (Picked player) of type Town Hall)
    • Set PlayerGroup = (All players)
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Race of (Picked player)) Equal to Human
          • Then - Actions
            • Unit Group - Pick every unit in Group1 and do (Actions)
              • Loop - Actions
                • Unit - Replace (Picked unit) with a Worker - War Mode using The old unit's relative life and mana
            • Unit Group - Pick every unit in Group2 and do (Actions)
              • Loop - Actions
                • Unit - Replace (Picked unit) with a Stronghold Level 1 using The old unit's relative life and mana
          • Else - Actions
    • Custom script: call DestroyGroup (udg_Group1)
    • Custom script: call DestroyGroup (udg_Group2)

///EDIT///Sorry, i forgot to put the updated code.

///EDIT 2//// Got it to work, thanks for the help! However, if there are leaks please do tell.

• Free Peoples Human Race Setup
  • Events
    • Time - Elapsed game time is 0.00 seconds
  • Conditions
  • Actions
    • Set PlayerGroup = (All players)
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Race of (Picked player)) Equal to Human
          • Then - Actions
            • Set Group1 = (Units owned by (Picked player) of type Peasant)
            • Unit Group - Pick every unit in Group1 and do (Actions)
              • Loop - Actions
                • Unit - Replace (Picked unit) with a Worker - War Mode using The old unit's relative life and mana
            • Set Group2 = (Units owned by (Picked player) of type Town Hall)
            • Unit Group - Pick every unit in Group2 and do (Actions)
              • Loop - Actions
                • Unit - Replace (Picked unit) with a Stronghold Level 1 using The old unit's relative life and mana
          • Else - Actions
    • Custom script: call DestroyGroup (udg_Group1)
    • Custom script: call DestroyGroup (udg_Group2)

 

[KILLCIDE]

1) You don't need to set (All players) to a player group variable. They are static, so they aren't considered as leaks
2) You leak two unit groups per player iteration. You should move call DestroyGroup() inside the player loop.