Purifiction

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

14:01, 16th Nov 2010
TriggerHappy:

Your spell leaks and it's too simple to be approved.

 

[Maker]

You leak a location, and a unit group.

This spell is way too simple.

You need more practise in spellmaking. Eventually you will get better

 

[GangSpear]

You leak a location, and a unit group.

This spell is way too simple.

You need more practise in spellmaking. Eventually you will get better

Oh,i forgot call DestroyGroup(udg_XXXXXX) right?
Thanks

 

[Dr. Boom]

Moin moin =)

=== My personal vote: I don't know [X/5] ===

Ok after download and testing the map: It's from omniknight isn't it? But this should be the point for now:

1) Actually you only need 1 variable ( see point 3 )

2) You should use (Triggering Unit) instead of (Casting Unit)

3) You have a unit group leak and I would make it like this: Create a Point variable like this:

• Set TempLocation = (Position of (Target unit of ability being cast))

instead of the Target variable.

Now you pick every units in range from this point and BEFORE you pick every units in.... you type this:

• Custom script: set bj_wantDestroyGroup = true

After you done all actions, clear the point variable at the end with:

• Custom script: call RemoveLocation(TempPoint)

4) This is a very easy spell, so there's no need to store caster,target,player in a variable. Only one TempPoint for the picking range.

=== So what we got now ===
As I said very simple spell, but unneeded variables you use there. It's ok if you create something like that, but this wont have a big use here. I don't know, actually it isn't a rejection nor it's an approval. So I leave my rating out and see what's coming.

Greetings and Peace
Dr. Boom

 

[Maker]

4) This is a very easy spell, so there's no need to store caster,target,player in a variable. Only one TempPoint for the picking range.

He should save caster,, target, owner of caster and the heal/damage to variables, since those are used more than once. Also the point should be stored to variable, so one can remove it.

So five variables in total.

 

[Dr. Boom]

Moin moin =)

"So five variables in total", this must be a joke. For that simple easy spell you want use 5 variables. No way, the point variable is enough here.

But I don't want open a battle now. After I saw this other new kamehameha spell here, I'm pissed anyway -_-

Greetings and Peace
Dr. Boom

 

[Maker]

There is no battle to be found here.

Save caster - you use it to get the ability level, owner and for damaging units.
Save owner - you use it potentially several times in the unit group pick condition
Save location - to be able to remove it afterwards
Save damage - makes no sense to recalculate it for every damaged unit
Save target - you use it twice in set life of unit: This one I could let you slip away without using a variable.

 

[Laserdude]

There is no battle to be found here.

Save caster - you use it to get the ability level, owner and for damaging units.
Save owner - you use it potentially several times in the unit group pick condition
Save location - to be able to remove it afterwards
Save damage - makes no sense to recalculate it for every damaged unit
Save target - you use it twice in set life of unit: This one I could let you slip away without using a variable.

6 variables, you forgot the Unit Group variable, which is required so that you can remove the unit group after it is used using the custom script:

• Custom script - call DestroyGroup ( udg_UnitGroup )

 

[Maker]

One should use

• Custom script: set bj_wantDetroyGroup = true

rather than using a variable there

 

[GangSpear]

• Custom script - set by_wantDestroyGroup = true

got what use?

 

[Adiktuz]

if you put that line before a

• Unit Group - Pick every units within blahblah

you wont need to save the group into a variable and use destroygroup since that line will make the group to automatically be destroyed after use...

 

[Laserdude]

One should use

• Custom script: set bj_wantDetroyGroup = true

rather than using a variable there

Ah, true, forgot that action, but you did not mention it in your thread either so I got a little confused.

 

[Tommerbob]

In addition to everything everyone has already pointed out, your damage is not pure, its normal attack damage. (unless I don't know what the term "pure" means.)

 

[Maker]

Well, that's kind of optional. Maybe he wants the units to be able to block some of it with armor.

 

[Laserdude]

Well, that's kind of optional. Maybe he wants the units to be able to block some of it with armor.

Only the damage type has to be normal in order to block it.
The attack type can be anyone, I would prefer Chaos because it ignores all armor types, but reduces damage if the target has loads of armor.
Using Chaos also allows the unit to deal moderate damage to divine units.
So, my point is, that isn't Normal damage type the best?
Never cared much for the others, but doesn't the ones such as "Universal" deal increased damage?

 

[Tommerbob]

Only the damage type has to be normal in order to block it.
The attack type can be anyone, I would prefer Chaos because it ignores all armor types, but reduces damage if the target has loads of armor.
Using Chaos also allows the unit to deal moderate damage to divine units.
So, my point is, that isn't Normal damage type the best?
Never cared much for the others, but doesn't the ones such as "Universal" deal increased damage?

Universal damage deals full damage, regardless of whatever. It goes through all types of armor and immunity. When I think of "pure", I think of universal. That was my point. Obviously its up to him to deal the type of damage he wants, but when he says "damage type is pure", his trigger is not.

 

[Laserdude]

Universal damage deals full damage, regardless of whatever. It goes through all types of armor and immunity. When I think of "pure", I think of universal. That was my point. Obviously its up to him to deal the type of damage he wants, but when he says "damage type is pure", his trigger is not.

Ah, ok.
To be honest, this was also helping me a bit, since I never thought of what the other damage types did, so now that you are saying this, it will actually help me in some maps.

 

[Maker]

Read this thread for good information about attack- and damage types:

http://www.wc3c.net/showthread.php?t=100752

Posts #18 and #19 especially are very informative.

 

[Marcikat]

hm it´s from dota but it´s way to easy, but i think it´s ok

 

[Catch_ya]

Ehm I know it might not be that important but isn't the name Purification?