Problem with Functions

[Joker9944]

Hey Guys

I have a problem, what’s the Function of the Event: Game - The 'Hero Abilitys' button is clicked?

• Event
  • Game - The 'Hero Abilities' button is clicked
• Conditions
  • (Unit-type of (???)) Equal to Unit1

I think it’s not possible in GUI i try it many Times and it didn’t work.

Is there a way to do this in JASS or in other ways?

 

[Dr Super Good]

There is no event to register when a UI button is clicked as far as I know.

You can however get when an ability order is issued or when an ability is cast.

 

[Maker]

Try this:

Events
Unit is issued an order with no target
Conditions
Actions
Custom script: If GetIssuedOrderId() = 852000 then
// Add your actions here
Custom script: endif

 

[Joker9944]

I didn’t work it look like this:

• Event
  • Unit - A unit Is issued an order with no target
• Conditiones
• Actions
  • Custom script: If GetIssuedOrderId() = 852000 then
  • Add Ability1 to (Ordered unit)
  • Custom script: endif

 

[Dr Super Good]

1. Is order ID 852000 the order of the dummy ability used for the button? It sounds like you do not understand the code he gave you (which generally is bad as if there is a bug in it you will not be able to fix it).
2. Is the ability no target? Targeting abilites need a different event.

 

[Maker]

1. Is order ID 852000 the order of the dummy ability used for the button?

If you issue an immediate order with that id to a unit, it will open up the skill menu.

However detecting when the button is clicked must be done with
call TriggerRegisterGameEvent(whichTrigger, EVENT_GAME_SHOW_SKILL)

So in GUI:

• Melee Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Custom script: call TriggerRegisterGameEvent(gg_trg_HeroButton, EVENT_GAME_SHOW_SKILL)

• HeroButton
  • Events
  • Conditions
  • Actions
    • Game - Display to Player Group - Player 1 (Red) the text: Clicked

 

[Pharaoh_]

Why do you use separate triggers, to enable functionality in multiplayer games as well? Can this event work in anything but single player? The editor itself mentions it can't.

 

[mckill2009]

• Untitled Trigger 002
  • Events
    • Unit - A unit Is issued an order with no target
  • Conditions
  • Actions
    • Custom script: local integer ord = OrderId("thunderclap")
    • Custom script: if GetIssuedOrderId()==ord then
    • -------- Actions here... --------
    • Custom script: call KillUnit(GetOrderedUnit()) <===testing only
    • Custom script: endif

 

[Dr Super Good]

OrderId("thunderclap") returns a constant and reliable value (the same integer number) every time it is evaluated in every session. Thus each time the trigger runs you are not only re-evaluating a statement with a constant and reliable value but also allocating it to the stack.

Instead it would be more efficient if the value was stored in a global constant (which GUI can not do... sadly.) which gets computed only once at map initialization.

Currently how it is done is probably no more efficient than just getting the issued order string and comparing it with the order string directly (saves a local allocation).

 

[mckill2009]

yeah its better like this "GetIssuedOrderId()==OrderId("thunderclap")", no need to declare it as local...

this can be used also instead of 'starts the effect on ability'...

 

[Joker9944]

I know now the problem: unit use order with no target not detect the open of the hero skill menu.

 

[Maker]

Did you try the solution I posted in post #6 of this thread?

 

[Joker9944]

Yes but i cant use it because i need the function to add abilitys.

 

[Maker]

Please explain what you're trying to accomplish.

 

[Joker9944]

I want when the Hero skill button is pressed i gives the hero an ability.

• Events
  • what ever works
• Conditions
  • what ever works
• Actions
  • Unit - Add Ability1 to (Function)

 

[Maker]

Turns out there was a GUI event for that.

• HeroButton
  • Events
    • Game - The 'Hero Abilities' button is clicked
  • Conditions
  • Actions
    • Unit - *ability* to *unit*

However like Pharaoh_ said it doesn't detect which player clicked it or what hero.