Power of Blight (1.6)

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

11:40, 17th Aug 2013
Maker: Check my reply in this thread.

 

[Whitewolf8]

It's cheap as hell, but definitely an interesting idea.
Undeads fighting on their own turf? Cower in fear. XD

 

[UndeadImmortal]

Good that you've improved!

Btw, I don't get the use of this,

For each (Integer A) from 0 to 2, do (Actions) Loop - Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions CHECK[(Integer A)] Less than 0 Then - Actions Set CHECK[(Integer A)] = 0

 

[TheWickedWitch]

its for auto-correcting. if the user happens to input a negative value, the system will set it to 0.

EDIT: btw undead, thanks alot. you and deathsmyfriend are very helpful.

 

[Maker]

-You have a unit group leak
-Remove the AND, place the conditions directly under the main If - Conditions

 

[TheWickedWitch]

ok maker, ill make the adjustments as soon as i get home.

 

[deathismyfriend]

dont use integer A/B

only use this if it is in an or condition.
And - All (Conditions) are true

 

[TheWickedWitch]

Hello there, I just got home. Also, I've done the changes required. I've also changed the spell a little. Now, the unit will only have the Unholy Aura graphics when standing on blight. I hope I didn't miss anything. I'm also expecting more suggestions. Please be kind to tell me my mistakes so I can learn. Thanks for your time.

EDIT: also i need to ask somethings. i've used alot of variable for this spell, if i use arrays will it reduce the file size. also, if i destroy the initialization trigger after initializing will my variables retain its value?.

 

[deathismyfriend]

u should store this into an integer variable. and use the integer variable.

• (Level of Power of Blight for blighted_unit)

dont use integer A/B as said above.
change this.

• For each (Integer A) from 0 to 2, do (Actions)
• Loop - Actions
• Set CTR_int = (Integer A)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • CHECK_int[CTR_int] Less than 0
    • Then - Actions
      • Set CHECK_int[CTR_int] = 0
    • Else - Actions

to this

• For each CTR_int from 0 to 2, do (Actions)
• Loop - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • CHECK_int[CTR_int] Less than 0
    • Then - Actions
      • Set CHECK_int[CTR_int] = 0
    • Else - Actions

it is better to use temp variables that aren't arrays but they will decrease file size by a very small amount. the also decrease efficiency by that small amount of space u gain

 

[TheWickedWitch]

Hello, I changed the way attribute bonus is added to unit. It is now configurable in the object editor. I hope its alright.

 

[Maker]

-You don't need blight_pg, use All Players
-0.03 seconds is too often
-Put the heroes with the ability into a unit group, don't create new groups all the time

 

[TheWickedWitch]

will update after few mins, ill make it quick

EDIT:
-removed blight_pg, used all player function
-0.3 changed to 0.1
-im not sure what you mean about this, only heroes are selected on the timer. Only those that are standing on blight gets the additional status and is stored on another unit group. Or, did you mean that my 2nd must be created and destroyed all the time? if so, ill adjust it again. thanks

 

[Maker]

Unit learns ability -> add unit into a group. Only pick units that are added into that group. Never destroy it.

 

[TheWickedWitch]

Hehe, the first group picks unit that has the ability. Then check if the units are on blight or not. Those that are on blight are given an ability and stored to a separate unit group. When units are not on blight, they are removed from the unit group. The unit learns ability event directly adds the unit to the separate unit group. I used this so that when a hero learns the ability while on blight, it will be added to the separate unit group. Also, when you level your skill while on blight it will take effect immediately. Only test_ug is created and destroyed. the other is just for adding and removing units.

 

[Maker]

-You should not create/destroy a group 10 times a second
-Use variables for the abilities and the buff, otherwise this is a nightmare to import

 

[TheWickedWitch]

oh, yes. I thought of that. create/destryo group 10 times is bad. but if i dont destroy it, wouldnt it leak?

and for the second one, sure ill do that the next update. but please answer the first question. Im really confused right now. The first release,I dont destroy the group but you said it will leak, so i inserted a line for destroying group. and now its just bad. Please advise. thanks

 

[Maker]

When a unit learns the ability, add it into a unit group. In the periodic trigger, pick units in that group. Don't destroy it.

The reply #11 was missing a "don't" word.

 

[TheWickedWitch]

Here, when unit learns the ability, it is added to the 2nd unit group. In the periodic trigger, the only group that needs to be picked is the test_ug.

-first item is fixed since it already adds the unit into the 2nd unit group
-the second unit group was never destroyed, it is only for adding units. In the periodic trigger ill just bring it back to the original setting where the unit group is not destroyed.

EDIT: ill just add abiliities into a variable in the initialization then im "ok" ?

 

[TheWickedWitch]

version 1.4 updated.

 

[deathismyfriend]

store triggering unit into a variable and use the variable. anything used twice or more should be stored in a variable.

change this

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (taint_point is blighted) Equal to True
    • (blighted_unit is in increased_ug) Equal to False
      • Then - Actions
        • Unit - Add BlightBonus_ability to blighted_unit
        • Unit - Set level of BlightBonus_ability for blighted_unit to BligjhtLevel_int
        • Unit Group - Add blighted_unit to increased_ug
        • Unit - Add Blight_Ability[1] to blighted_unit
      • Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (taint_point is blighted) Equal to False
    • (blighted_unit is in increased_ug) Equal to True
      • Then - Actions
        • Unit - Remove BlightBonus_ability from blighted_unit
        • Unit Group - Remove blighted_unit from increased_ug
        • Unit - Remove Blight_Ability[1] from blighted_unit
      • Else - Actions

to this

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (taint_point is blighted) Equal to True
    • (blighted_unit is in increased_ug) Equal to False
      • Then - Actions
        • Unit - Add BlightBonus_ability to blighted_unit
        • Unit - Set level of BlightBonus_ability for blighted_unit to BligjhtLevel_int
        • Unit Group - Add blighted_unit to increased_ug
        • Unit - Add Blight_Ability[1] to blighted_unit
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (taint_point is blighted) Equal to False
            • (blighted_unit is in increased_ug) Equal to True
              • Then - Actions
                • Unit - Remove BlightBonus_ability from blighted_unit
                • Unit Group - Remove blighted_unit from increased_ug
                • Unit - Remove Blight_Ability[1] from blighted_unit
              • Else - Actions

 

[Maker]

anything used twice or more should be stored in a variable.

I see you post this a lot. I might not be completely true. I'd rather say "thrice or more" if a clear limit would have to be set.

For example in jass, you would have to declare a local variable and then possibly null it, so the speed difference decreases.

In GUI that could result in using more variables than needed to give one example.

 

[T. D. W.]

Set test_ug = (Units in (Playable map area) matching ((((Matching unit) has buff Blight_buff) Equal to True) and (((Matching unit) is A Hero) Equal to True))) Unit Group - Pick every unit in test_ug and do (Actions)

Remove this, and replace it with:

• Unit Group - Pick every unit in increased_ug and do (Actions)

also remove the condition where you check if the unit is in the increased_ug

You use basic variable names, make them like: PB_UG (unit group of the spell)

and remove those:

Unit Group - Add blighted_unit to increased_ug

and

Unit Group - Remove blighted_unit to increased_ug

cool spell btw

 

[TheWickedWitch]

thanks guys. i havent touched this since my last comment. ill work on this as soon as i can. expect updates today or tomorrow. depends on your time zone.

EDIT: the spell has been updated. i removed the variable "test_ug"
the increased_ug cannot be removed cause i have to keep track on units that has the bonus. the 3rd trigger is for leveling the spell if the hero is stepping on blight. if you level the spell while not on blight is ok without the 3rd trigger. but if you level the spell while on blight without the 3rd trigger, the bonus will not update unless you get out of the blight

 

[deathismyfriend]

“Modified Review Inside“

REVIEW

TRIGGER FIXES	Anything used twice or more should be stored into a variable. Example: triggering unit Don’t pick every unit in the map every 0.10 seconds. You should store the units when they enter the map in an indexed array.
FINAL RATING	1/5 Needs Fix

[/TD][/tr]
If you have any questions or problems with my review please tell me. Original Review Template by Doomlord.

 

[TheWickedWitch]

ill change the "triggering unit" on the 3rd trigger later. hmm. i see, store any unit entering only when they have the ability. then use time to check if they are on blight and add bonus if they are. with this i dont have to crease unit group 10 times every second. Thanks deathismyfriend. ill implement this as soon as i get home.

 

[deathismyfriend]

ill change the "triggering unit" on the 3rd trigger later. hmm. i see, store any unit entering only when they have the ability. then use time to check if they are on blight and add bonus if they are. with this i dont have to crease unit group 10 times every second. Thanks deathismyfriend. ill implement this as soon as i get home.

No problem and good luck

 

[TheWickedWitch]

hello, sorry im a slowie. i should have done this the first time hehe. anyway everything is updated. importing instructions are wrriten along with the triggers when u download the map. its way simplier than i thought. i hope this is approvable despite its simplicity

 

[DivineLight]

i think you should also store the Ability into a variable as well
store your Triggering unit into a variable too

• Unit - Set level of PB_Ability for PB_Unit to (Level of Power of Blight for PB_Unit)

use your stored variable, "PB_level" not "Level of Power of Blight for PB_Unit"

• Unit - Remove PB_Ability from (Picked unit)

use your stored variable, "PB_Unit" not "Picked unit"

Why store a variable if you didn't use it?

• ((Position of PB_Unit) is blighted) Equal to True

use variable..
i think 0.03 is too quick

other than that good job...
suggestion: make this more configurable (i hope you know what i mean)
2/5 until this fixed
bonus +rep and keep up the good work

 

[T. D. W.]

^
0.03 is perfect, 0.04 is too slow

And add [stable][/STABLE] tags to the trigger tags

 

[DivineLight]

0.03 is perfect, 0.04 is too slow

not really, 0.04 is more realistic for missile.. but for this kind of spell i don't know

 

[T. D. W.]

The realistic comes from the missile speed, the 0.03 will be smoother than the 0.04, especially for high speed missiles

 

[Maker]

• You are not using the variable in the learn trigger
• There's a leak
• 0.03 is too often
• Does not work on pre-set units that have learned the ability in the editor

 

[TheWickedWitch]

ill update this when im free. my wc3 was corrupted atm

 

[Moises08x]

Useful