NeverMore Ability Pack [GUI] v1.3

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Already checked the ability at main condition:

• ((Learned Hero Skill) Equal to (==) ShadowRaise 1 (z)) and ...

Spell Casting 1,2 and 3 have too much code, redundant actions. Only the damage changes. Use the level of the ability to determine the array index.
Shadow Raise shouldn't add three abilities since it limits max number of abilities the hero can have.
The ability could be point targeted.
Kills a unit trigger should not check unit type. Check ability.
Consume soul trigger isn't MUI.
SetUnitAnimationIndex(unit, 7) isn't MUI. Models have different indexes for different animations.
Death Pact leaks locations.

Old review

10:17, 24th Sep 2011
Pharaoh_: Has a lot of leaks and it is not MUI. Lack of documentation and in-game screenshot.

Other trigger comments

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Level of Gather for Firelord 0000 <gen>) Equal to 1
  • Then - Actions
    • Player - Add 5 to (Owner of Firelord 0000 <gen>) Current gold
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Level of Gather for Firelord 0000 <gen>) Equal to 3
      • Then - Actions
        • Player - Add 15 to (Owner of Firelord 0000 <gen>) Current gold
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Gather for Firelord 0000 <gen>) Equal to 2
          • Then - Actions
            • Player - Add 10 to (Owner of Firelord 0000 <gen>) Current gold
          • Else - Actions

This can be sorted as "Player - Add 5 x (Level of Gather for (Picked unit)) Current gold

I use (Picked unit) for the trigger it should actually be used in. This event you're currently using affects the preset hero of the map only.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Learned Hero Skill) Equal to ShadowRaise 1 (z)) and ((Level of ShadowRaise 1 (z) for (Triggering unit)) Equal to 2)
  • Then - Actions
    • Unit - Set level of ShadowRaise 2 (x) for (Triggering unit) to 2
    • Unit - Set level of ShadowRaise 3 (c) for (Triggering unit) to 2
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Learned Hero Skill) Equal to ShadowRaise 1 (z)) and ((Level of ShadowRaise 1 (z) for (Triggering unit)) Equal to 3)
      • Then - Actions
        • Unit - Set level of ShadowRaise 2 (x) for (Triggering unit) to 3
        • Unit - Set level of ShadowRaise 3 (c) for (Triggering unit) to 3
      • Else - Actions

Just use:

• Unit - Set level of ShadowRaise 2 (x) for (Triggering unit) to (Level of Shadow Raze 1 (z))
• Unit - Set level of ShadowRaise 3 (c) for (Triggering unit) to (Level of Shadow Raze 1 (z))

 

[UnHolyDarKness]

Please tell me about anything wrong in it
and i will fix it as soon as possible

Edit: for the leaks you mean the unit place's ? it could be done
and for the leveling yup i'll do it as you said xD
Documintation : i actually ddnt have much time coz uni started so that am barely on inet but i try to be here as much as i can
and i will redo everything
just point me on my wrong things
oh and btw thank you pharoh for seeing it

 

[Pharaoh_]

Unit Groups, locations, etc.: http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

It's not MUI as well, it has to be useable by more than one units and it can be currently used by the preset Nevermore at the moment. Check hashtables/Hanky's and/or Bribe's Indexers for more info.

 

[UnHolyDarKness]

thx for the support my friend
am actually a newbie in world editor .. but i learned a lot from this site and am still learnin
that thread of things that leak .. i'll start reading it right now
and for the hashtables and that stuff do u have a good link for it too ?

Edit: after reading that thread i do really understand that i have Tons of leaks in there hehehehe
screw me
i'll start fixing the leaks today.. so tod i'll have the first changelog

 

[Pharaoh_]

Good
Just don't forget to use the "Edit" button in your posts, to avoid double posting.

 

[UnHolyDarKness]

Fixed

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Level of Gather for Firelord 0000 <gen>) Equal to 1
• Then - Actions
• Player - Add 5 to (Owner of Firelord 0000 <gen>) Current gold
• Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Level of Gather for Firelord 0000 <gen>) Equal to 3
• Then - Actions
• Player - Add 15 to (Owner of Firelord 0000 <gen>) Current gold
• Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Level of Gather for Firelord 0000 <gen>) Equal to 2
• Then - Actions
• Player - Add 10 to (Owner of Firelord 0000 <gen>) Current gold
• Else - Actions
• This can be sorted as "Player - Add 5 x (Level of Gather for (Picked unit)) Current gold
• I use (Picked unit) for the trigger it should actually be used in. This event you're currently using affects the preset hero of the map only.
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
  • ((Learned Hero Skill) Equal to ShadowRaise 1 (z)) and ((Level of ShadowRaise 1 (z) for (Triggering unit)) Equal to 2)
  • Then - Actions
  • Unit - Set level of ShadowRaise 2 (x) for (Triggering unit) to 2
  • Unit - Set level of ShadowRaise 3 (c) for (Triggering unit) to 2
  • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
  • ((Learned Hero Skill) Equal to ShadowRaise 1 (z)) and ((Level of ShadowRaise 1 (z) for (Triggering unit)) Equal to 3)
  • Then - Actions
  • Unit - Set level of ShadowRaise 2 (x) for (Triggering unit) to 3
  • Unit - Set level of ShadowRaise 3 (c) for (Triggering unit) to 3
  • Else - Actions
• Just use:
  • Unit - Set level of ShadowRaise 2 (x) for (Triggering unit) to (Level of Shadow Raze 1 (z))
  • Unit - Set level of ShadowRaise 3 (c) for (Triggering unit) to (Level of Shadow Raze 1 (z))

that all is fixed now now am going for leaks :S

for the leaks .. in the raises i added a 10 sec exparation timer for the dummies . does this leak ?
i mean the unit will be removed from game after 10 sec by itself or should i remove the leak manually by using a custome script ?

 

[Pharaoh_]

No, adding expiration timer to a unit does not leak.

 

[UnHolyDarKness]

Leaks

No, adding expiration timer to a unit does not leak.

in this case this means that the only leaks that i have is the "Unit Group" leaks ?!?!
coz all the dummies i have . i add 10 sec expiration timer to them !

 

[Pharaoh_]

Unit groups and locations for this spell.

 

[UnHolyDarKness]

Unit groups and locations for this spell.

in here u mean that even the dummy with 10 sec exp. timer
i must clear the location of it to avoid the leaks ?

this is my last question , coz am almost done with fixing the main things in the map

all the "Unit Group" leaks are fixed
all that i need now is answering the question above and the one i messeged u

 

[Pharaoh_]

Yes, every "Position of X", Target point of ability being cast, Location (x, x), Point offset by X towards Y, Center of region, etc. leak. Make sure you remove them.

 

[Magtheridon96]

Wow.
Pharaoh_'s getting tense (I can sense it)

Could you please post the triggers? ^^

 

[UnHolyDarKness]

just wait some more hours

Wow.
Pharaoh_'s getting tense (I can sense it)

Could you please post the triggers? ^^

lol ya i know i suck
i will post the triggers soon
am almost done with handeling the leaks
which means that the pack will be leakless
the only problem i face at this moment is making it MUI :S

 

[Jay the Editor]

Check the "Recommended" at my signature to learn how to make it MUI.
As well as learn the link that Pharaoh_ gave you. It's useful.
For hashtable tutorial, here goes a good tutorial. A Complete Beginners Guide to Hashtables

lol ya i know i suck

Don't look down on yourself. I was worst when I was a beginner. Ask for help here and there, causing so much troubles XD

 

[UnHolyDarKness]

Big Thanks

Check the "Recommended" at my signature to learn how to make it MUI.
As well as learn the link that Pharaoh_ gave you. It's useful.
For hashtable tutorial, here goes a good tutorial. A Complete Beginners Guide to Hashtables

thank you a lot for the help

now i wish that Pharaoh_ would take an another look at it. as i fixed all the leaks from the link he gave me
and fixed the triggers that he pointed me at.

 

[maddeem]

Read the rules before posting again. All of these crappy spells being uploaded are really pissing me off.

 

[Pharaoh_]

Still leaks. Use the created variable for reference to the respective points.

Read the rules before posting again. All of these crappy spells being uploaded are really pissing me off.

You, on the other hand, calm down.

 

[Magtheridon96]

Read the rules before posting again. All of these crappy spells being uploaded are really pissing me off.

At least give him some constructive criticism.
All that's gonna do is start a flame-war that will end like this:

 

[Jay the Editor]

Read the rules before posting again. All of these crappy spells being uploaded are really pissing me off.

Agree with Magtheridon96 Beginners need to try an error and learn from mistake in order to learn faster, just like how a baby does; persistent.

 

[baassee]

Although if they want constructive critism, it should be posted in the trigger and scripts forum. Period.

 

[Magtheridon96]

Beginners wouldn't know they did something wrong though :/
Thus, they wouldn't think that constructive criticism is needed.
It's okay for now. Beginners always do this.

 

[UnHolyDarKness]

Read the rules before posting again. All of these crappy spells being uploaded are really pissing me off.

dont like it then just leave it and get out .. its not of your concerns

 

[baassee]

I shall make a thread in site discussion about this matter!

 

[UnHolyDarKness]

reply to everyone

At least give him some constructive criticism.
All that's gonna do is start a flame-war that will end like this:

thank you .. it wont lead to a war .. am not a fighter am just a beginner

Agree with Magtheridon96 Beginners need to try an error and learn from mistake in order to learn faster, just like how a baby does; persistent.

you got that right although the baby part >>lol

Although if they want constructive critism, it should be posted in the trigger and scripts forum. Period.

sorry i ddnt know that . i'll do it next time

Beginners wouldn't know they did something wrong though :/
Thus, they wouldn't think that constructive criticism is needed.
It's okay for now. Beginners always do this.

constructive criticism is very appreciated . coz its the thing that helps out the most . as well as in life and in any other things

Still leaks. Use the created variable for reference to the respective points.

you mean use it instead of making the point again ... how stupid am i
i'll do it right away

yes he should

 

[Magtheridon96]

Tips:

In the Spell leveling, when you add an ability, it will be at level 1 by default, so you can remove these:

• Unit - Set level of ShadowRaise 2 (x) for (Triggering unit) to 1
• Unit - Set level of ShadowRaise 3 (c) for (Triggering unit) to 1

You can also create a unit variable called TempUnit and set it to (Triggering Unit), then use it instead (This will be more efficient since stuff like (Triggering Unit) and (Last Created Unit) is very slow and costly.

Note:

• Set Location = ((Position of (Triggering unit)) offset by 256.00 towards (Facing of (Triggering unit)) degrees)

This leaks
You should have 2 locations instead ^_^

• Set Location = (Position of (Triggering unit))
• Set Location2 = Location offset by 256.00 towards (Facing of (Triggering unit)) degrees

That's better

You'll remove both locations like this:

• Custom script: call RemoveLocation(udg_Location)
• Custom script: call RemoveLocation(udg_Location2)

Here's a better version of your trigger with no leaks:

• Spell Casting1
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to ShadowRaise 1 (z)
  • Actions
    • Set TempUnit = (Triggering unit)
    • Set TempPlayer = (Triggering player)
    • Set Location = (Position of TempUnit)
    • Set Location2 = Location offset by 256.00 towards (Facing of TempUnit) degrees)
    • Unit - Create 1 Coil for TempPlayer at Location2 facing Default building facing degrees
    • Set TempUnit2 = (Last created unit)
    • Unit - Add a 0.10 second Generic expiration timer to TempUnit2
    • Custom script: call RemoveLocation(udg_Location)
    • Custom script: call RemoveLocation(udg_Location2)
    • Set Location = (Position of TempUnit2)
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 300.00 of Location) and do (Actions)
      • Loop - Actions
        • Set TempUnit3 = (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((TempUnit3 is A structure) Not equal to True) and ((TempPlayer is an enemy of (Owner of TempUnit3)) Equal to True)
          • Then - Actions
            • Unit - Cause TempUnit to damage TempUnit3 dealing ShadowRaiseDamage[(Level of ShadowRaise 1 (z))] damage of attack type Spells and damage type Normal
          • Else - Actions
    • Custom script: call RemoveLocation(udg_Location)

See, whenever you use something in an action like (Position of xxx) in a line, it's a leak.

Leaks:
- Locations
- Special Effects
- Groups

See this:

• Custom script: set bj_wantDestroyGroup = true

This makes it so that the group you 'Picked' is going to be destroyed immediately after you finish using it.

You should be doing this in this case instead of setting the group in a variable, picking it and running code, then destroying it.
This is because it's more efficient.

You need a real array called ShadowRaiseDamage
In a trigger that will run on Map Initialization, you'll set the damage for each level.

• MapInit
  • Events
    • Map Initialization
  • Conditions
  • Actions
    • Set ShadowRaiseDamage[1] = 200.00
    • Set ShadowRaiseDamage[2] = 300.00
    • Set ShadowRaiseDamage[3] = 350.00

It's pretty easy

Also, here's a note:
In a trigger in GUI, never repeat stuff like (Triggering unit) or (Last created unit) or etc..
You should save them into variables and use those variables instead.
UNLESS: You're using the thing exactly once.
Pretty easy right?

You should do something similar for the other triggers too

I hope this really long post helps ^_^

 

[UnHolyDarKness]

Tips:

In the Spell leveling, when you add an ability, it will be at level 1 by default, so you can remove these:

• Unit - Set level of ShadowRaise 2 (x) for (Triggering unit) to 1
• Unit - Set level of ShadowRaise 3 (c) for (Triggering unit) to 1

You can also create a unit variable called TempUnit and set it to (Triggering Unit), then use it instead (This will be more efficient since stuff like (Triggering Unit) and (Last Created Unit) is very slow and costly.

Note:

• Set Location = ((Position of (Triggering unit)) offset by 256.00 towards (Facing of (Triggering unit)) degrees)

This leaks
You should have 2 locations instead ^_^

• Set Location = (Position of (Triggering unit))
• Set Location2 = Location offset by 256.00 towards (Facing of (Triggering unit)) degrees

That's better

You'll remove both locations like this:

• Custom script: call RemoveLocation(udg_Location)
• Custom script: call RemoveLocation(udg_Location2)

Here's a better version of your trigger with no leaks:

• Spell Casting1
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to ShadowRaise 1 (z)
  • Actions
    • Set TempUnit = (Triggering unit)
    • Set TempPlayer = (Triggering player)
    • Set Location = (Position of TempUnit)
    • Set Location2 = Location offset by 256.00 towards (Facing of TempUnit) degrees)
    • Unit - Create 1 Coil for TempPlayer at Location2 facing Default building facing degrees
    • Set TempUnit2 = (Last created unit)
    • Unit - Add a 0.10 second Generic expiration timer to TempUnit2
    • Custom script: call RemoveLocation(udg_Location)
    • Custom script: call RemoveLocation(udg_Location2)
    • Set Location = (Position of TempUnit2)
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 300.00 of Location) and do (Actions)
      • Loop - Actions
        • Set TempUnit3 = (Picked unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((TempUnit3 is A structure) Not equal to True) and ((TempPlayer is an enemy of (Owner of TempUnit3)) Equal to True)
          • Then - Actions
            • Unit - Cause TempUnit to damage TempUnit3 dealing ShadowRaiseDamage[(Level of ShadowRaise 1 (z))] damage of attack type Spells and damage type Normal
          • Else - Actions
    • Custom script: call RemoveLocation(udg_Location)

See, whenever you use something in an action like (Position of xxx) in a line, it's a leak.

Leaks:
- Locations
- Special Effects
- Groups

See this:

• Custom script: set bj_wantDestroyGroup = true

This makes it so that the group you 'Picked' is going to be destroyed immediately after you finish using it.

You should be doing this in this case instead of setting the group in a variable, picking it and running code, then destroying it.
This is because it's more efficient.

You need a real array called ShadowRaiseDamage
In a trigger that will run on Map Initialization, you'll set the damage for each level.

• MapInit
  • Events
    • Map Initialization
  • Conditions
  • Actions
    • Set ShadowRaiseDamage[1] = 200.00
    • Set ShadowRaiseDamage[2] = 300.00
    • Set ShadowRaiseDamage[3] = 350.00

It's pretty easy

Also, here's a note:
In a trigger in GUI, never repeat stuff like (Triggering unit) or (Last created unit) or etc..
You should save them into variables and use those variables instead.
UNLESS: You're using the thing exactly once.
Pretty easy right?

You should do something similar for the other triggers too

I hope this really long post helps ^_^

i love you hehehehehehe

 

[deathdoorway]

Its a nice spell to start out with. Couple of things i would suggest is
1. Add a description to your lvl 6 spell. Nobody knows what it does if they are new to triggering or dont read the spell triggers.
2. your shadowraise seems to deals damage WAY before the effect shows. So to fix this in your event

• Events
  • Unit - A unit Begins casting an ability

if you see here it would basiclly do damage before anything in the ability fires off. This could be bad for channaling spells due to people canceling the spell and still damaging the creep. So i would suggest changing it this

• Events
  • Unit - A unit Finishes casting an ability

3. Shadowraise tooltip doesnt show the range of how far each one goes. Add that in
4. Fix up the tooltips on all the spells (no one likes a sloppy tooltip)
5. You can condense all the spell casting1-3 for shadowraise bydoing another if/then/else in one trigger and just bringing all the actions up and condiction to the if.
6. Add some documentation to the trigger to allow people to understand where to mess with the trigger and where not to if your not suppose to. (also makes it easier for your spell to get scored higher)

Hope my review helped

 

[Magtheridon96]

Actually, it should be changed to

• Events
  • Unit - A unit Starts the effects of an ability

Sorry I didn't point that out earlier

 

[UnHolyDarKness]

Its a nice spell to start out with. Couple of things i would suggest is
1. Add a description to your lvl 6 spell. Nobody knows what it does if they are new to triggering or dont read the spell triggers.
2. your shadowraise seems to deals damage WAY before the effect shows. So to fix this in your event

• Events
  • Unit - A unit Begins casting an ability

if you see here it would basiclly do damage before anything in the ability fires off. This could be bad for channaling spells due to people canceling the spell and still damaging the creep. So i would suggest changing it this

• Events
  • Unit - A unit Finishes casting an ability

3. Shadowraise tooltip doesnt show the range of how far each one goes. Add that in
4. Fix up the tooltips on all the spells (no one likes a sloppy tooltip)
5. You can condense all the spell casting1-3 for shadowraise bydoing another if/then/else in one trigger and just bringing all the actions up and condiction to the if.
6. Add some documentation to the trigger to allow people to understand where to mess with the trigger and where not to if your not suppose to. (also makes it easier for your spell to get scored higher)

Hope my review helped

for the idea .. its just that i searched the internet and found the nevermore's pack on hive only 1 pack and its in Jass so i dont think that many people would like it
for the damage .. ya but i guess it should be just like Magtheridon96 said .
Unit - A unit Starts the effects of an ability
but i'll try everything .. but for the condencing i dont think it will be a good idea. because as you said later on that people need to read. and there are even worse newbies than me. who would just not get a shit unless i do so <<just my openion
for documintation and tooltips i'll do as soon as possible

Actually, it should be changed to

• Events
  • Unit - A unit Starts the effects of an ability

Sorry I didn't point that out earlier

guess you'r right.. i'll try right away

 

[Magtheridon96]

for the idea .. its just that i searched the internet and found the nevermore's pack on hive only 1 pack and its in Jass so i dont think that many people would like it

But people are moving to Jass cause GUI is lame

 

[UnHolyDarKness]

But people are moving to Jass cause GUI is lame

lol ya i understand that but for making the gui.. for somebody who is totaly a biginner
its 2 good things
1- practice and learn for me
2- the biginners just happy to find sth to copy

 

[Magtheridon96]

You will move on to Jass in the near future
Download JNGP, Convert a trigger to custom text, and you'll love playing around with it
That's how I learned Jass ^_^

 

[UnHolyDarKness]

You will move on to Jass in the near future
Download JNGP, Convert a trigger to custom text, and you'll love playing around with it
That's how I learned Jass ^_^

i wish i start it soon
but wt do u think of the pack now ?
its all fixed up but still not mui
and am tired of even thinking now ,, i have uni which DISTRACTS me from hive
looooooooooooooooooooooooooool

 

[deathdoorway]

Hey Unholy dont always believe jass is better than GUI. for example there are plenty of maps that prove Magtheridon96 plenty wrong.

Ive had a chance to help with the map "rollercoaster" and the dude stuck to the idea he could do everything in GUI and did it prove ya wrong with warcraft defining material? HELL YA. There are now code system and core system people are posting that really do a banging job of what jass could do. Yes jass has features that make it easier to use and know but its the fun to show people what you think it aint possible. I'm a GUI coder and I've seen people actually make different programs LIKE vJASS that is needed to run systems, spells, and maps better so look around. idk if eGUI is still around but never give up.

About your spell MUI isnt always needed if you do MPI. Though HIVE only cares about spells being in MUI due to their "purpose" or w.e they wanna say. Good luck and I'm not starting another war with GUI and JASS user so dont comment back please with this quote lol

 

[xIceShotx]

Dont use (Integer A) it is need to be a variable. Use this "For Eatch Integer (Variable) do bla bla bla and stuff... This place is right here

• For each (Integer A) from 1 to 15, do (Actions)
  • Loop - Actions
    • Unit - Create 1 Explosion for (Owner of (Triggering unit)) at (((Position of (Triggering unit)) offset by ((Random real number between -250.00 and 250.00), (Random real number between -500.00 and 500.00))) offset by (Random real number between -250.00 and 250.00) towards (Facing of (Triggering unit)) degrees) facing Default building facing degrees
    • Unit - Add a 0.10 second Generic expiration timer to (Last created unit)
    • Set Location = (Position of (Last created unit))
    • Custom script: call RemoveLocation(udg_Location)

Correct it like this:

• For each (Integer Variable) from 1 to 15, do (Actions) -I hope this helps a little... ~xIceShotx

 

[Chaithresh]

[http://www.hiveworkshop.com/forums/pastebin.php?id=n8mtnp] can u add thats spells for my map ur self beacause i cant understand that triggers.

 

[Bribe]

Well it's a buggy spell that has the "Needs fix" tag, we don't recommend importing it.