Nevermore's Shadowraze

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

05:37, 26th Aug 2012
Magtheridon96: You shouldn't repeat code like this.
Only use an if block to set a variable to the range you're going to use, then finally, just get the point using the range you set in the if blocks as the offset and the facing of the caster as the angle, then do the rest of the actions regularly.

Also, this spell should be configurable.
You shouldn't use constants. I shouldn't be forced to mess with spell code if I want to modify simple things like Special effects, damage and range.
You should create a configuration trigger and set variables to the constants in there. Use arrays for setting data that will change for different levels and use regular variables for things like the effects.

 

[iChaos]

Please upload the triggers @_@

 

[Almia]

1/5 for rejection
too simple
has been made for 1000+ times
im sorry

 

[Maestros]

I'll post the triggers

Triggers

• Shadowraze Learn
  • Events
    • Unit - A unit Learns a skill
  • Conditions
    • (Learned Hero Skill) Equal to Shadowraze
  • Actions
    • Set S_Integer = (Player number of (Owner of (Triggering unit)))
    • Set S_Caster[S_Integer] = (Triggering unit)
    • Set S_Level[S_Integer] = (Level of Shadowraze for S_Caster[S_Integer])
    • Set S_Ability_Level[S_Integer] = ((Level of Shadowraze for S_Caster[S_Integer]) x 75)
    • Unit - Set level of Shadowraze (C) for S_Caster[S_Integer] to S_Ability_Level[S_Integer]
    • Unit - Set level of Shadowraze (X) for S_Caster[S_Integer] to S_Ability_Level[S_Integer]
    • Unit - Set level of Shadowraze (Z) for S_Caster[S_Integer] to S_Ability_Level[S_Integer]

• Shadowraze Learn 2
  • Events
    • Unit - A unit Learns a skill
  • Conditions
    • (Learned Hero Skill) Equal to Shadowraze
  • Actions
    • Unit - Add Shadowraze (Z) to S_Caster[S_Integer]
    • Unit - Add Shadowraze (X) to S_Caster[S_Integer]
    • Unit - Add Shadowraze (C) to S_Caster[S_Integer]
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (S_Caster[S_Integer] has buff Unknown (B000)) Equal to True
      • Then - Actions
        • Unit - Remove Shadowrazer buff from S_Caster[S_Integer]
      • Else - Actions
    • Trigger - Turn off (This trigger)

I didnt understand what the

• If - Conditions
  • (S_Caster[S_Integer] has buff Unknown (B000)) Equal to True
  • Then - Actions
    • Unit - Remove Shadowrazer buff from S_Caster[S_Integer]

Does

• Shadowraze C
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shadowraze (C)
  • Actions
    • Set S_Caster[(Player number of (Owner of (Triggering unit)))] = (Triggering unit)
    • Wait 0.10 seconds
    • Unit - Create 1 Shadowraze (Special Effect) for (Owner of S_Caster[S_Integer]) at ((Position of S_Caster[S_Integer]) offset by 700.00 towards (Facing of S_Caster[S_Integer]) degrees) facing (Facing of S_Caster[S_Integer]) degrees
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit Group - Pick every unit in (Units within 300.00 of (Position of (Last created unit))) and do (Actions)
      • Loop - Actions
        • Unit - Cause S_Caster[S_Integer] to damage (Picked unit), dealing (Real(S_Ability_Level[S_Integer])) damage of attack type Spells and damage type Normal
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (S_Caster[S_Integer] has buff Shadowrazer ) Equal to True
        • (Owner of (Picked unit)) Not equal to (Random player from (All allies of (Owner of S_Caster[S_Integer])))
      • Then - Actions
        • Unit - Remove Shadowrazer buff from S_Caster[S_Integer]
      • Else - Actions

• Shadowraze X
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shadowraze (X)
  • Actions
    • Wait 0.10 seconds
    • Unit - Create 1 Shadowraze (Special Effect) for (Owner of S_Caster[S_Integer]) at ((Position of S_Caster[S_Integer]) offset by 400.00 towards (Facing of S_Caster[S_Integer]) degrees) facing (Facing of S_Caster[S_Integer]) degrees
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit Group - Pick every unit in (Units within 300.00 of (Position of (Last created unit))) and do (Actions)
      • Loop - Actions
        • Unit - Cause S_Caster[S_Integer] to damage (Picked unit), dealing (Real(S_Ability_Level[S_Integer])) damage of attack type Spells and damage type Normal
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (S_Caster[S_Integer] has buff Shadowrazer ) Equal to True
        • (Owner of (Picked unit)) Not equal to (Random player from (All allies of (Owner of S_Caster[S_Integer])))
      • Then - Actions
        • Unit - Remove Shadowrazer buff from S_Caster[S_Integer]
      • Else - Actions

• Shadowraze Z
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shadowraze (Z)
  • Actions
    • Wait 0.10 seconds
    • Unit - Create 1 Shadowraze (Special Effect) for (Owner of S_Caster[S_Integer]) at ((Position of S_Caster[S_Integer]) offset by 150.00 towards (Facing of S_Caster[S_Integer]) degrees) facing (Facing of S_Caster[S_Integer]) degrees
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit Group - Pick every unit in (Units within 300.00 of (Position of (Last created unit))) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Picked unit) Not equal to S_Caster[S_Integer]
          • Then - Actions
            • Unit - Cause S_Caster[S_Integer] to damage (Picked unit), dealing (Real(S_Ability_Level[S_Integer])) damage of attack type Spells and damage type Normal
          • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (S_Caster[S_Integer] has buff Shadowrazer ) Equal to True
        • (Owner of (Picked unit)) Not equal to (Random player from (All allies of (Owner of S_Caster[S_Integer])))
      • Then - Actions
        • Unit - Remove Shadowrazer buff from S_Caster[S_Integer]
      • Else - Actions

Avoid using

• Wait X seconds

because if you do it is not MUI, and it wont be accepted.

This,

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Picked unit) Not equal to S_Caster[S_Integer]
  • Then - Actions
    • Unit - Cause S_Caster[S_Integer] to damage (Picked unit), dealing (Real(S_Ability_Level[S_Integer])) damage of attack type Spells and damage type Normal

is going to damage your allies as well, the Condition should be,

• If - Conditions
  • ((Picked unit) Not equal to S_Caster[S_Integer]) and (((Picked unit) belongs to an ally of (Owner of S_Caster[S_Integer])) Equal to False)

So its going to select only enemies/neutrals etc

And again, what does this do?

• Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (S_Caster[S_Integer] has buff Shadowrazer ) Equal to True
      • (Owner of (Picked unit)) Not equal to (Random player from (All allies of (Owner of S_Caster[S_Integer])))
    • Then - Actions
      • Unit - Remove Shadowrazer buff from S_Caster[S_Integer]
    • Else - Actions

 

[Tank-Commander]

Wait don't make things not MUI, we have tutorials on why this is, However in this particular instance it does. Now, I've explained that we have tutorials for generating waits in an MUI manner, Felz, many many times, please actually read them, and then try making spells.

 

[edo494]

its not MUI anyways, its MPI(he uses (Player number of (Owner of (Triggering unit))) so ) and you can have MUI with waits, example:

• Actions
  • Custom script: local unit u = GetTriggerUnit()
  • Wait 5.00 seconds
  • Unit - Kill u
  • Custom script: set u = null

is completly MUI

 

[Tank-Commander]

No it doesnt, if you put a second caster on the field, he will not even learn the abilities, the abilities will only be learnt in the first unit who learns them

Read my sentence again. That's all I can say.

 

[Maestros]

Read my sentence again. That's all I can say.

Oh dear! missed a double negative there

*withdraws awkwardly*

 

[MortAr]

Trigger

• Shadowraze Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Shadowraze (200)
        • (Ability being cast) Equal to Shadowraze (450)
        • (Ability being cast) Equal to Shadowraze (700)
  • Actions
    • Set Temp_Loc = (Position of (Triggering unit))
    • Set Temp_Damage = (75.00 x (Real((Level of (Ability being cast) for (Triggering unit)))))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Ability being cast) Equal to Shadowraze (200)
      • Then - Actions
        • Set Temp_Range = 200.00
        • Set Temp_Loc2 = (Temp_Loc offset by Temp_Range towards (Facing of (Triggering unit)) degrees)
        • Set Temp_Group = (Units within 250.00 of Temp_Loc2 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True))))
        • Unit Group - Pick every unit in Temp_Group and do (Actions)
          • Loop - Actions
            • Unit - Cause (Triggering unit) to damage (Picked unit), dealing Temp_Damage damage of attack type Spells and damage type Magic
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Ability being cast) Equal to Shadowraze (450)
      • Then - Actions
        • Set Temp_Range = 450.00
        • Set Temp_Loc2 = (Temp_Loc offset by Temp_Range towards (Facing of (Triggering unit)) degrees)
        • Set Temp_Group = (Units within 250.00 of Temp_Loc2 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True))))
        • Unit Group - Pick every unit in Temp_Group and do (Actions)
          • Loop - Actions
            • Unit - Cause (Triggering unit) to damage (Picked unit), dealing Temp_Damage damage of attack type Spells and damage type Magic
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Ability being cast) Equal to Shadowraze (700)
      • Then - Actions
        • Set Temp_Range = 700.00
        • Set Temp_Loc2 = (Temp_Loc offset by Temp_Range towards (Facing of (Triggering unit)) degrees)
        • Set Temp_Group = (Units within 250.00 of Temp_Loc2 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True))))
        • Unit Group - Pick every unit in Temp_Group and do (Actions)
          • Loop - Actions
            • Unit - Cause (Triggering unit) to damage (Picked unit), dealing Temp_Damage damage of attack type Spells and damage type Magic
      • Else - Actions
    • Unit - Create 1 Projectile Dummy for Neutral Passive at Temp_Loc2 facing Default building facing degrees
    • Animation - Change (Last created unit)'s size to (150.00%, 150.00%, 150.00%) of its original size
    • Special Effect - Create a special effect attached to the origin of (Last created unit) using ShadowRaze.mdx
    • Special Effect - Destroy (Last created special effect)
    • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
    • Custom script: call RemoveLocation (udg_Temp_Loc)
    • Custom script: call RemoveLocation (udg_Temp_Loc2)
    • Custom script: call DestroyGroup (udg_Temp_Group)

Seems better, IMO.
I have the full Shadowfiend spellpack made by me (but not released) and I can give it to you, if you want to learn from it.

 

[Felz_09]

Still I'm noob

 

[defskull]

I once created Shadowraze for a request, and I don't even use Wait (it works flawlessly).
By using the unit's default Cast Backswing/Point, that acts as my "Wait".
Which makes my Shadowraze a MUI trigger, by default.

Also, Wait below 0.27 seconds does not work (0.27s is the minimum wait time).

 

[Noobsmoke]

Trigger

• Shadowraze Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Shadowraze (200)
        • (Ability being cast) Equal to Shadowraze (450)
        • (Ability being cast) Equal to Shadowraze (700)
  • Actions
    • Set Temp_Loc = (Position of (Triggering unit))
    • Set Temp_Damage = (75.00 x (Real((Level of (Ability being cast) for (Triggering unit)))))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Ability being cast) Equal to Shadowraze (200)
      • Then - Actions
        • Set Temp_Range = 200.00
        • Set Temp_Loc2 = (Temp_Loc offset by Temp_Range towards (Facing of (Triggering unit)) degrees)
        • Set Temp_Group = (Units within 250.00 of Temp_Loc2 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True))))
        • Unit Group - Pick every unit in Temp_Group and do (Actions)
          • Loop - Actions
            • Unit - Cause (Triggering unit) to damage (Picked unit), dealing Temp_Damage damage of attack type Spells and damage type Magic
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Ability being cast) Equal to Shadowraze (450)
      • Then - Actions
        • Set Temp_Range = 450.00
        • Set Temp_Loc2 = (Temp_Loc offset by Temp_Range towards (Facing of (Triggering unit)) degrees)
        • Set Temp_Group = (Units within 250.00 of Temp_Loc2 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True))))
        • Unit Group - Pick every unit in Temp_Group and do (Actions)
          • Loop - Actions
            • Unit - Cause (Triggering unit) to damage (Picked unit), dealing Temp_Damage damage of attack type Spells and damage type Magic
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Ability being cast) Equal to Shadowraze (700)
      • Then - Actions
        • Set Temp_Range = 700.00
        • Set Temp_Loc2 = (Temp_Loc offset by Temp_Range towards (Facing of (Triggering unit)) degrees)
        • Set Temp_Group = (Units within 250.00 of Temp_Loc2 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True))))
        • Unit Group - Pick every unit in Temp_Group and do (Actions)
          • Loop - Actions
            • Unit - Cause (Triggering unit) to damage (Picked unit), dealing Temp_Damage damage of attack type Spells and damage type Magic
      • Else - Actions
    • Unit - Create 1 Projectile Dummy for Neutral Passive at Temp_Loc2 facing Default building facing degrees
    • Animation - Change (Last created unit)'s size to (150.00%, 150.00%, 150.00%) of its original size
    • Special Effect - Create a special effect attached to the origin of (Last created unit) using ShadowRaze.mdx
    • Special Effect - Destroy (Last created special effect)
    • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
    • Custom script: call RemoveLocation (udg_Temp_Loc)
    • Custom script: call RemoveLocation (udg_Temp_Loc2)
    • Custom script: call DestroyGroup (udg_Temp_Group)

Seems better, IMO.
I have the full Shadowfiend spellpack made by me (but not released) and I can give it to you, if you want to learn from it.

You can still make it shorter

 

[scourge069]

just have to ask, where did you get the SF model ??it's so cool ..