Need help with a trigger

[Jacobjohn1]

So, I've been trying to create an ability that will trigger when a unit is targeted by an ability. Essentially, when so done, a dummy will throw the ability back at the caster. But, only once every 7 seconds.

But, the problem I'm having is I can't get the dummy to use the ability. I've looked through how other maps have done it, but it doesn't seem to be working. Can anyone help?

I've attached the file here, the trigger is Magic Return. Admittedly, my Jass is terrible (I've only really just started), but based on triggers in other maps not sure what the problem is.

 

[Pyrogasm]

• How To Post Your Trigger
• You're leaking a couple locations. Here's how to fix them: Things That Leak
• The "this trigger is on" check is pointless; since the trigger can't run if it's not on that condition will always evaluate to true.
• Similarly the "level of black arrow" check is also unnecessary. If the unit doesn't have it then the random int check will always fail because (random 1-100) > 0
• This spell is not MUI, but I presume that doesn't matter to you? If that's the case you don't need to use the other timer trigger and can just do:
  Turn off (This trigger)
  Wait 7.00 game-time seconds
  Turn on (this trigger)
• My presumption as to why it's not working is that the unit's current order is no longer the spellcast order. I would suggest you try printing out the different orders made when issuing the spell vs. what this trigger detects. It might be the case that you need to use a "begins casting" event to properly store the order then issue it when the spell effect is started. You could also use something like LastOrder - Wc3C.net which automatically caches orders to issue the last or secondlast order as necessary.

 

[Uncle]

I managed to get it working by removing the If Then Else from the Return Trigger and putting the conditions in the default Conditions spot. I also added some more variables (and changed some names just because I was getting confused), cleaned up some leaks, and created a new Dummy unit since your Dummy unit had a bunch of problems. Your Dummy should be a non-hero unit, have no movement type/speed, and have no cast backswing/cast point. It should also have enough mana to cast any spell in the game.

Spoiler: Triggers

• Magic Return
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Unit-type of (Casting unit)) Not equal to Dummy Uncle
  • Actions
    • Set ReturnEnemy = (Casting unit)
    • Set ReturnSource = (Target unit of ability being cast)
    • Set ReturnAbility = (Ability being cast)
    • Set ReturnPoint = (Position of ReturnSource)
    • Custom script: set udg_ReturnAbilityu = GetUnitCurrentOrder(udg_ReturnEnemy)
    • -------- - --------
    • Unit - Create 1 Dummy Uncle for (Owner of ReturnSource) at ReturnPoint facing Default building facing degrees
    • Set WildUnit = (Last created unit)
    • Unit - Add a 7.00 second Generic expiration timer to WildUnit
    • Unit - Add ReturnAbility to WildUnit
    • Unit - Set level of ReturnAbility for WildUnit to (Level of ReturnAbility for ReturnEnemy)
    • Custom script: call IssueTargetOrderById( udg_WildUnit, udg_ReturnAbilityu, udg_ReturnEnemy)
    • -------- - --------
    • -------- Remove Leaks --------
    • Custom script: call RemoveLocation (udg_ReturnPoint)
    • Countdown Timer - Start ReturnTimer as a One-shot timer that will expire in 7.00 seconds
    • Trigger - Turn off Magic Return <gen>
    • Game - Display to (All players) for 5.00 seconds the text: Magic Return - Off

• Magic Return Timer
  • Events
    • Time - ReturnTimer expires
  • Conditions
  • Actions
    • Trigger - Turn on Magic Return <gen>
    • Game - Display to (All players) for 5.00 seconds the text: Magic Return - On

 

[Jacobjohn1]

Thanks so much! Yes, got it working. And I appreciate the help cleaning up. As Pyrogasm said, was able to just reduce that if code to level of the ability percentage using moon glaive base for the ability.

On a related note, I tried making other dummy units--no matter what unit I base off, the editor makes it a hero, with 0 in all stats. Not sure why. That's why all 3 of my original dummies were hero units.Same problem when I loaded in Uncle's (new units are made into heroes, not units--luckily the dummy there was already a unit).

Again thanks guys! I really appreciate it!

 

[Pyrogasm]

On a related note, I tried making other dummy units--no matter what unit I base off, the editor makes it a hero, with 0 in all stats. Not sure why.

You’re capitalizing the first letter of the rawcode you’re giving it. Capital first == hero. Use ‘dmmy’ not ‘Dmmy’.