Nature Walk v1.8

[Moderator]

Bribe:

These recent changes you've made have really set this in as a strong-quality spell. I like how it works and is now a very efficient GUI spell.

Approved.

 

[Adiktuz]

looks good... downloading...

but I dont like the region thing... (just personal preference...)

not sure if that region creation leaks...



you can just change the AOE effect of the stomp rather than creating an sfx right?

 

[Nightmare Moon]

Well of course i can, i just didn't think of that, but anyone can do that if he wants, but i prefer to use effects in triggers.

 

[Adiktuz]

Well of course i can, i just didn't think of that, but anyone can do that if he wants, but i prefer to use effects in triggers.

I think the region leaks... not sure though... since the region's size is always (50,50) maybe you can create one global region and then just move its center (not sure if its doable in GUI)...

 

[Nightmare Moon]

So you say that i should create one region when ability is casted and then move it to the NW_EndPoint right, but i will still need to clear it and next time create another. I just think that it will be the same concept. But maybe i should just delete the region and come out with something else.

 

[Adiktuz]

So you say that i should create one region when ability is casted and then move it to the NW_EndPoint right, but i will still need to clear it and next time create another. I just think that it will be the same concept. But maybe i should just delete the region and come out with something else.

nope, you wont need to clear it... just create one region on map init with size (50,50) and then just move it during the loop... just do the move before the if-then-else...

• -------- --------------------------------------------------------- --------
• -------- We chek if ending region contains caster, if yes we stomp there --------
• -------- --------------------------------------------------------- --------
• Region - Move Region to NW_EndPoint[NW_Index3]

 

[Nightmare Moon]

Ok i'll do, ty. But a bit later i'm need to go right now, thanks.

 

[Maker]

The dummies don't need invulnerability ability because Locust already makes them invulnerable.

Leaks:

• Set NW_Point2[NW_Index3] = ((Position of NW_Caster[NW_Index3]) offset by 30.00 towards NW_Angle[NW_Index3] degrees)

^Position of unit is one point, the offset point is another.

• Special Effect - Create a special effect at (Position of NW_Caster[NW_Index3]) using Abilities\Spells\NightElf\Taunt\TauntCaster.mdl

Also picks dead units:

• Unit Group - Pick every unit in NW_UnitGroup[NW_Index] and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is A structure) Equal to False
        • ((Picked unit) belongs to an enemy of (Owner of NW_Caster[NW_Index3])) Equal to True
      • Then - Actions
        • ....

Shouldn't be inside the loop:

• Custom script: call DestroyGroup(udg_NW_UnitGroup[udg_NW_Index3])

This

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • NW_Index Equal to 0
  • Then - Actions
    • Set NW_Index2 = 0
    • Trigger - Turn off (This trigger)
  • Else - Actions

should be after this

• Set NW_Index = (NW_Index - 1)

The tooltip should say what level the spell is, like this: Natur|c0020c000e|r Walk - [|cffffcc00Level 1|r]

Maybe add some collision detection, the caster can get stuck in the middle of trees.

I do like the effect, looks good. The concept is quite simple and not very original.

You could make the spell more configurable.

Regions leak ->

• Custom script: call RemoveRect(udg_*region*)

Or you could just calculate the distance between points.

When you detect that the unit is in the region, it still gets moved once after that. Perhaps a bug.

 

[Nightmare Moon]

Ty, Maker, updating now
Edit: Updated
But now i have a problem, when i cast spell with other unit first units stops moving, its like not MUI, any solutions? It's must be something with

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • NW_Distance[NW_Index3] Less than or equal to 30.00
  • Then - Actions
    • ...
• -------- --------------------------------------------------------- --------
• -------- Subtarcting 30 range --------
• -------- --------------------------------------------------------- --------
• Set NW_Distance[NW_Index3] = (NW_Distance[NW_Index3] - 30.00)

Edit 2: updated, everything works fine. enjoy))

 

[Cihparg]

You're most likely missing a boolean, which checks if the spell has ended.
Why to add a boolean for that? Well, when one instance stops running, it will start decreasing the index until the trigger collapses, to fix this, add for examble a existance boolean inside the loop, just before the actions happen in the spell.

 

[Nightmare Moon]

OffGraphic you're to late I already fixed the problem.

Edit 2: updated, everything works fine. enjoy))

 

[xorkatoss]

wow nice spell dude 5/5 ;p
and this is acually your first MUI? :O
welcome to the MUIers xD
And always remember...
"A spell without MUI is not a good spell at all" ;p

 

[Adiktuz]

wow nice spell dude 5/5 ;p
and this is acually your first MUI? :O
welcome to the MUIers xD
And always remember...
"A spell without MUI is not a good spell at all" ;p

without MUI? shouldn't it be "A spell that is not MUI is not a good spell at all"?

 

[Nightmare Moon]

Actually spell without GUI isn't a good spell, i think so. Anyway thanks for feedback, and yeah this is my first try of MUI.

 

[Adiktuz]

Actually spell without GUI isn't a good spell, i think so. Anyway thanks for feedback, and yeah this is my first try of MUI.

but GUI is also JASS... so a spell without JASS is not a good spell... ^_^

nice spell btw...

 

[kimothan]

I'm trying to transfer this spell to a another map... but howw?????????????????? it's a;ways shows an error

 

[FrozenHellfire]

I think you should have the caster damaging an area instead of a dummy casting a spell,
So the caster gets Experience and Bounty. Also some player-made systems might not work (systems that counts kills for example). Just what I think...

 

[Adiktuz]

I think you should have the caster damaging an area instead of a dummy casting a spell,
So the caster gets Experience and Bounty. Also some player-made systems might not work (systems that counts kills for example). Just what I think...

he can get exp and bounty if dummy is owned by him... and I think most kill meters use Player rather than a unit... at least for only one hero per player maps... anyway, its possible to link the dummy caster to the unit anyways using hashtables or index...

and I think he used the ability to simplify things, because it will produce both the stun and the damage...

 

[FrozenHellfire]

he can get exp and bounty if dummy is owned by him... and I think most kill meters use Player rather than a unit... at least for only one hero per player maps... anyway, its possible to link the dummy caster to the unit anyways using hashtables or index...

and I think he used the ability to simplify things, because it will produce both the stun and the damage...

Okay thnx, I guess I was the noob here. He could have made a stun ability without damage and made the hero damage. And what's the difference with stun and pause? But I guess he took the easy way.

 

[Adiktuz]

Okay thnx, I guess I was the noob here. He could have made a stun ability without damage and made the hero damage. And what's the difference with stun and pause? But I guess he took the easy way.

well, I think its better to use the stomp for this, to reduce number of dummies created and functions called...

stun is used by buffs and just stops the unit... and pause causes a PAUSE...

example:

A unit has a timed life

if you stun him, the timed life will still be reduced, if you pause him, the timer will not get reduced...

and some damages do not immediately take effect on a paused unit, but rather after the pause...

 

[Hanexys]

I am not a spell maker at all, i find this spell and all other stuff complicated -.-

But i cannot make it work with Nature Walk, can u plz upload one without leaks

 

[Nightmare Moon]

Hanexys, could you please specify more what exactly you need?

can u plz upload one without leaks

this is leakless.
Well, if in your map this spell doesn't work then check if everything is the same as in the map. Maybe some actions or conditions use another dummy or spell, happens when you copy triggers.

 

[Bribe]

Nature walk cast

(Real(100)) should just be 100.00. It slows down performance and is silly to convert integer to real in this case.

(Position of NW_Caster[NW_Index2]) leaks x2.

Nature Walk Loop

(Position of NW_Caster[NW_Index3]) leaks

• Set NW_UnitGroup[NW_Index3] = (Units within 300.00 of NW_Point2[NW_Index3])
• Unit Group - Pick every unit in NW_UnitGroup[NW_Index] and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Picked unit) is A structure) Equal to False
        • ((Picked unit) is alive) Equal to True
        • ((Picked unit) belongs to an enemy of (Owner of NW_Caster[NW_Index3])) Equal to True
      • Then - Actions
        • Unit - Create 1 Dummy 2 for (Owner of NW_Caster[NW_Index3]) at NW_Point2[NW_Index3] facing Default building facing degrees
        • Unit - Add Entangling Roots to (Last created unit)
        • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
        • Unit - Order (Last created unit) to Night Elf Keeper Of The Grove - Entangling Roots (Picked unit)
      • Else - Actions
        • Custom script: call RemoveLocation(udg_NW_Point2[udg_NW_Index3])

Should combine that "if" with the group-setting part. Just "Units in range matching conditions:"

• Set NW_UnitGroup[NW_Index3] = (Units within 300.00 of NW_Point2[NW_Index3]) Matching ((Matching unit) is A structure) Equal to False And ((Matching unit) is alive) Equal to True And ((Matching unit) belongs to an enemy of (Owner of NW_Caster[NW_Index3])) Equal to True
• Unit Group - Pick every unit in NW_UnitGroup[NW_Index3] and do (Actions)
  • Loop - Actions
    • Unit - Create 1 Dummy 2 for (Owner of NW_Caster[NW_Index3]) at NW_Point2[NW_Index3] facing Default building facing degrees
    • Unit - Add Entangling Roots to (Last created unit)
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit - Order (Last created unit) to Night Elf Keeper Of The Grove - Entangling Roots (Picked unit)
  • Else - Actions
• Custom script: call RemoveLocation(udg_NW_Point2[udg_NW_Index3])

 

[Nightmare Moon]

Ok thanks Bribe, i'll fix it after i configure my new OS.

Edit: okay i updated the spell, fixed everything, hopefully. But i got a question for you,

Should combine that "if" with the group-setting part. Just "Units in range matching conditions:"

but is there any difference? I mean it's easier too see what conditions are used in If/Then/Else.

 

[88WaRCraFT3]

Cool spell, but a little bit OP 5/5

 

[Bribe]

The If/Then/Else is still acceptable, I'm not going to debate that as you have a good reason.

Set NW_Point4[NW_Index3]

That needs to be removed from within the group pick loop. Once that happens, this thing looks leak-free and should be approved.

 

[Nightmare Moon]

Updated. Location leak fixed.

 

[Bribe]

Your triggers are a bit hard to read, so I want to make sure I'm not missing something

Set NW_UnitGroup2[NW_Index3] = (Units within NW_AoE[2] of NW_Point3[NW_Index3])

Where do you destroy that group? I think you need to add another custom script. I see you destroy udg_NW_UnitGroup but I don't see you destroy this one.

And I think this line:

Custom script: call DestroyGroup(udg_NW_UnitGroup[udg_NW_Index3])

Should go below the group - pick right underneath it instead of above it. Also, you use udg_NW_Index instead of udg_NW_Index3 right below it... all this is making it very hard for me to keep up with your work and track down leaks.

 

[Nightmare Moon]

Oh man, i think i just remembered something, the version that was uploaded here was 1.2 in which there wasn't any knockback, and when i uploaded this one, with fixed leaks, it had a knockback, where units that get stunned in the end will be knocked. But my problem is that after reinstalling my OS (i use windows 7 Ultimate now) i cannot test the map because my WC3 wont run (need reinstalling). So Bribe, i'd be glad if you could test this new version and tell me if units are knocked in right direction (from center), at looking at code, i think all fine but double checking is always fine.
In the next version i'll update the mistakes you saw and told in last post, you didn't see them before cuz the version was older, without the knockback.
(i created this version really LONG time ago, forgot about the changes and easily replaced with new one)

 

[Bribe]

You reinstalling WarCraft III sounds like a better option. Being able to test your own work is important.

 

[Nightmare Moon]

Okay then, i'll see, for now the only option is too leave the spell as it is and reinstall my WarCraft, but as i don't have a CD, right now, i'll have to wait a bit. So let the spell status be Pending for now... As soon as i reinstall the game and update the spell without any leaks (hopefully) i'll contact you.
Thanks for help with leaks.

 

[Bribe]

battle.net/account

Put in the CD Key and download it directly.

I threw away my WC3 cd's years ago.

 

[Nightmare Moon]

Thanks, but i'm already downloading game from torrent with key
Tomorrow i'll try to update the spell, and test it.

Edit: reinstalling WC3 didn't help, i still get problems with the game, but well time passes and you just must go on, i mean that i retire from map making...
If i'll have more time, i'll try solve the problem, but i thought about quiting WarCraft III a really long time, anyway good luck everyone with their projects.
Just read the Bribe's signature and one line captured me: "No project is ever finished.", so true, cruel irony!

 

[Bribe]

I've quit WarCraft III about 10 or 15 times. And here I am. Something about the game, the way it works, the ways it can be modded, it's perfect for creative development.

 

[Nightmare Moon]

I guess you're right! I played a lot of games too, quit a lot of them and never played again, but i really don't want to quit WarCraft III, permanently.
Anyway i guess i'll solve my problem with the game soon enough, if not i can still use just an editor and make maps, my friend will test them - yeah, that would be it.

 

[Bribe]

Looks very good.

In the loop trigger, I suggest doing the bj_wantDestroyGroup custom script as opposed to setting the group, using it, then destroying it. Three lines instead of two

That's definitely not a requirement though. I will review the in-game performance of this spell later this evening and then I'll give it an approval.

 

[Marcos DAB]

SImple but maybe useful

 

[Orcnet]

What a cool spell. but it doesn't look like a nature skill to me, rather chaos, good job!

 

[Nightmare Moon]

What a cool spell. but it doesn't look like a nature skill to me, rather chaos, good job!

Thanks!

Okay i updated spell, added a note where i said what i've changed in this version.
If you have anu suggestion feel free to tell 'em.

P.S. What's with that pony thing? I started seeing a lot of people here with pony avatars or sigs... Love ponies?

 

[ShiroiSenji]

Well, i have kinda problem when i target the spell to border of the map, it starts to glitch abit.

 

[Nightmare Moon]

Emmm, can you describe more? Doesn't glitch for me.

 

[Andykiller]

This is a cool spell i can amagen grom hellscreem using this spell

5/5

 

[Dr. Boom]

Moin moin =)

Another check of mine of the approved spells and again I have to say this spell cannot be approved because it's buggy!

== Why buggy ==
When I cast the spell the first time, the rush starts slow and gets faster until the end.
Now every time I cast it the rush gets faster and faster. Also then the amount of crated effects is reduces. So your triggering is at some place wrong, but since I unlearn GUI, I can't saw where the fault is.

Also another point for not approval is, that the unit can rush over unpathable terrain and stuck there:

Screen

So you should check if the X and Y of the caster is on unpathable terrain (you can do it with a boolean so a user can choose it for his own)

2) Another thing is, that the caster plays at the end of the rush the attack animation. At the end of it if will freeze in this animation. Trigger it, that the animation is reseted after the attack animation back to normal.

3) Another tip: I saw the unit rush over the target point. Make a boolean variable if the unit should only rush to the target point or the full range.


Point 2 and 3 aren't high faults but point 1 is the reason that this spell cannot be approved - sorry!

This spell was approved at the time where I wrote this review

Greetings and Peace
Dr. Boom

 

[Nightmare Moon]

Well, thanks. Okay i'll update it right away!
And yeah i see that it's buggy too, this is ny first MUI spell anyway =)

 

[Bribe]

I tested this spell dozens of times, the effect is consistent for me: starts slow, speeds up towards the end, but I don't notice any drop in special effects.

One thing that can be improved is actually to create fewer special effects, because it lags on low-performance computers like mine about 1 second after the spell is cast and right after the spell is cast (perhaps too many dummy units).

 

[Dr. Boom]

Moin moin =)

Well, thanks. Okay i'll update it right away!
And yeah i see that it's buggy too, this is ny first MUI spell anyway =)

That's why I hope that you take my reviews as a help not as an attack^^.
Well but I tested the current map now, first I still can rush over the cliffs itself, didn't saw that I can set this.

2) Now there's another thing which didn't happen last testing or I just didn't get it, I can rush out of the map. When the caster is too far, then the game crash.

Screen

But I think you get this easily, that's why I take the "not approved" status away and this can be approved.

Greetings and Peace
Dr. Boom

 

[Nightmare Moon]

Well im' not sure if i can create less special effects... Not sure, i think they are pretty simple though, but if any ideas, come on in and tell 'em.
@Bribe, maybe it lags not because of dummies, but because of the action Move unit instantly to point. But i don't know, just a thought. Not sure what to improve... :S
Edit:

That's why I hope that you take my reviews as a help not as an attack^^.

Ofc, no problem and i'm always glad to hear more reviews!

2) Now there's another thing which didn't happen last testing or I just didn't get it, I can rush out of the map. When the caster is too far, then the game crash.

I'll fix this right away.
Edit2: should i make the check thingy same as when i check if caster not on cliff?
With this:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Terrain pathing at NW_Point3 of type Walkability is off) Equal to True
  • Then - Actions
    • Custom script: loop
    • Set NW_Real[NW_Index3] = (NW_Real[NW_Index3] + 10.00)
    • Set NW_Point1 = (NW_Point3 offset by NW_Real[NW_Index3] towards NW_Angle[NW_Index3] degrees)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Terrain pathing at NW_Point1 of type Walkability is off) Equal to True
      • Then - Actions
        • Unit - Move NW_Caster[NW_Index3] instantly to NW_Point1
      • Else - Actions
    • Custom script: call RemoveLocation(udg_NW_Point1)
    • Custom script: exitwhen udg_NW_Real[udg_NW_Index3] > 300
    • Custom script: endloop
  • Else - Actions

??
Nvm, found another way.

 

[Ketsuno Anson]

It still rushes out of map and after that if you spam it the caster will fly backwards and goes out of map again,I personally prefer a slam in the end since missiles don't suit melee heroes :/

 

[Nightmare Moon]

It rushes out of the map, because i haven't updated it yet =) haha
Edit: Updated!