Mui

[Ruke]

updated, liked the result

 

[chobibo]

The debug messages are still not translated to english, it also appears that you have ignored the suggestions others have given you.

 

[Ruke]

The debug messages are still not translated to english, it also appears that you have ignored the suggestions others have given you.

look closer

 

[chobibo]

Oh, so you did translate it, sorry about that. The latter comment still stands though. Read the code thoroughly this time, looks like the suggestions were implemented.

EDIT: I think the previous instance method should be retained.

 

[axleion]

a huge overhaul it is, almost no wrapper function,
I want to note that :
- this version has a limit of ROUNDUP(8190/udg_limit)-1 instances running at the same time.
- you're not using map header, how you can be sure that your script run before user's trigger?
- you should add how to import instructions.

 

[Ruke]

yes, i do realize of the limit.

i analize it, and i think that you won't have any problems with it.

- you're not using map header, how you can be sure that your script run before user's trigger?

i don't think that people fire this at the map-init. so it should be ok.

you should add how to import instructions.

i did ._., i have to add that you need to paste the variables.

EDIT: I think the previous instance method should be retained.

why?


i'm more concerned about recursion problems in the set_x variables. but i don't know how to check it :\.

 

[axleion]

i don't think that people fire this at the map-init. so it should be ok.

nope, what I meant is, the target of this resource is pure GUI non JNGP user. if such user would like to implement this in their 50% done map and change already made spell to conform to this resource, how will they do it? isn't this resource will be compiled at the bottom of the code, not at the top?

i did it ._., i have to add that you need to paste the variables.

rather than information to copy and paste the variable, why not make a GUI trigger using all global variable that just need to be copy-pasted? so user who has enable "Automatically create unknown variables when passing trigger data" or such can just copy that trigger into their map then delete it.

and still, I suggest to add destructable set to this.

 

[Ruke]

nope, what I meant is, the target of this resource is pure GUI non JNGP user. if such user would like to implement this in their 50% done map and change already made spell to conform to this resource, how will they do it? isn't this resource will be compiled at the bottom of the code, not at the top?

but that doesn't really matters. the important thing is that this resource should be loaded before the user fires the timer. that happends on casting spells and those don't happend on init. is that your concern?.

rather than information to copy and paste the variable, why not make a GUI trigger using all global variable that just need to be copy-pasted? so user who has enable "Automatically create unknown variables when passing trigger data" or such can just copy that trigger into their map then delete it.

uhmm, so if people have that option checked the variables will be created automatically?, didn't know that. i will update the example-map later.

 

[axleion]

but that doesn't really matters. the important thing is that this resource should be loaded before the user fires the timer. that happends on casting spells and those don't happend on init. is that your concern?.

actually after further reading, the user didn't need to call any function just set global variable, so yes it doesn't matter, sorry.

 

[chobibo]

I meant the previous instancing method, not the instance method. The reason is the array limits will greatly reduce the amount of spell instance per spell type.

but that doesn't really matters. the important thing is that this resource should be loaded before the user fires the timer. that happends on casting spells and those don't happend on init. is that your concern?.

He is talking about syntax errors, your system must be declared above the triggers that will use it, that's why he suggested to put it on the map header section.

 

[Ruke]

I meant the previous instancing method, not the instance method. The reason is the array limits will greatly reduce the amount of spell instance per spell type.

if you put a limit of 50, you will be able to have ~163 instances at a time. 163 spell in the same time, didn't see that before. i really, really think that user will not reach that number.

edit: although, now that i think... i have an entire hashtable that i can use if the user goes over the limit... uhmm c:
edit: yes i will add destructibles too .

 

[axleion]

the only kind of spells in my head which can reach the limit of 50 unit/real/integer variable is a custom Cluster Rockets with each unit variable referring to missile and real variable for its trajectory.

He is talking about syntax errors, your system must be declared above the triggers that will use it, that's why he suggested to put it on the map header section.

yeah at first I actually think the same thing, but after further reading, his script is never been called outside of his script, and the only thing user need to do is setting variable and using it. so yeah, I think this won't need to be inside map init.

 

[deathismyfriend]

You still never cleaned all of the local variable leaks.
Please use hidden tags on your first page.

 

[Ruke]

You still never cleaned all of the local variable leaks.

i checked the code, didn't find what you're saying, can you pointing me out?

Please use hidden tags on your first page.

i will update everything in a few hours.

 

[deathismyfriend]

Every local variable has to be nulled except integer / real / boolean.
Loop at your periodic function.

 

[Ruke]

Every local variable has to be nulled except integer / real / boolean.
Loop at your periodic function.

pay attention and look closer.


i did realice though that i'm not reseting the counter.

edit:

the only kind of spells in my head which can reach the limit of 50 unit/real/integer variable is a custom Cluster Rockets with each unit variable referring to missile and real variable for its trajectory.

if you need it, you can increase the limit. see 'limit' variable.

edit: damn, acording to nes this can/do have recursion problems : \, i will try to fix it.

 

[Tal'Rarity]

Another thing to add with your update would be easier importing to new maps.
Make an eventless trigger and set all your variables in it so they can be copied over easily.

Example

[trigger=]
Events
Conditions
Actions
Set boolean[0] = False
Set effect[0] = (Last created special effect)
Set effect_helper = (Last created special effect)
Set group[0] = (Random 4 units from (Units in (Playable map area)))
Set group_helper = (Random 4 units from (Units in (Playable map area)))
Set hashtable = (Last created hashtable)
Set integer[0] = 0
Set integer_helper = 0
Set player[0] = (Owner of (Triggering unit))
Set player_helper = (Owner of (Triggering unit))
Set point[0] = ((Center of (Playable map area)) offset by (0.00, 0.00))
Set point_helper = ((Center of (Playable map area)) offset by (0.00, 0.00))
Set real[0] = 0.00
Set real_helper = 0.00
Set trigger = (This trigger)
Set unit[0] = (Last created unit)
Set unit_helper = (Last created unit)
[/TRIGGER]

 

[Ruke]

updated

+ added reset on finish
+ added destructible support
+ improved map-example

i check for recursion problems... nothing happended so it should work fine .

edit: seems like there's a bug because dat-c3's spell is not working properly
edit: after thinking, the only solution that came to me is:

edit: good news, wasn't because of recursion problems, it was because of a mistake of mine c:. the time when your entire utility fails because of a division u.u

 

[Ruke]

updated, now working properly and with a hat (?

 

[Tal'Rarity]

You shouldn't be using integer A in the examples... =P

 

[axleion]

this part of code,

function MUI_CreateInstance takes nothing returns integer
    local integer instance

    if ( udg_recycle == 0 ) then
        set udg_instanceCount = udg_instanceCount + 1
        set instance = udg_instanceCount
    else
        set instance = udg_recycle
        set udg_recycle = udg_recycleNext[udg_recycle]
    endif

    // reserving space
    if ( instance > 1 ) then
        set instance = instance * udg_limit
    endif

    return instance
endfunction

without the code below the reserving space, the instance available are from start are 1,2,3,4,5,6,7,8,....
using the code below the reserving space, the instance become: 1,100,150,200,250,300,350,400,..., its not using the index of 51-100 for anything which means yours actually have a maximum instance of ROUNDUP(8190/udg_limit)-2 not ROUNDUP(8190/udg_limit)-1 (not much effect actually, only one instance less).
and on the recycleinstance, I haven't checked if integer round up or down when dealing with fractions in calculation, but considering this line

    set instance = instance / udg_limit

if instance given is 1, if the integer round up, it will do well, but if it round down to 0, it will bug off the allocation/deallocation to the point it will always create instance as udg_recycle will always 0.

 

[Ruke]

You shouldn't be using integer A in the examples... =P

why not?

if instance given is 1, if the integer round up, it will do well, but if it round down to 0, it will bug off the allocation/deallocation to the point it will always create instance as udg_recycle will always 0.

true, i will change it.

 

[Tal'Rarity]

Apparently its been proven A and B are slow and if they collide bad stuff happens.

 

[Ruke]

updated, thanks Dark_Axl .

now the instance counter begins at 0, so now the available instances are round(8190/limit)

Apparently its been proven A and B are slow

http://www.hiveworkshop.com/forums/lab-715/lets-talk-about-efficiency-while-242044/

if they collide bad stuff happens

they can't collide (if you use them well).

 

[axleion]

ehm, its still round(8190/limit) - 1 max instance, why?

function MUI_CreateInstance takes nothing returns integer
    local integer instance

    if ( udg_recycle == 0 ) then
        set udg_instanceCount = udg_instanceCount + 1
        set instance = udg_instanceCount
    else
        set instance = udg_recycle
        set udg_recycle = udg_recycleNext[udg_recycle]
    endif

    // reserving space
    if ( instance > 0 ) then
        set instance = instance * udg_limit
    endif

    return instance
endfunction

function MUI_RecycleInstance takes integer instance returns nothing
    if ( instance > 0 ) then
        set instance = instance / udg_limit
    endif

    set udg_recycleNext[instance] = udg_recycle
    set udg_recycle = instance
endfunction

your instance given before the //reserving space is still 1,2,3,...
and after the if check, it becomes 50,100,150,... which means index 0-50 is still unused. and by the way, because the instance count always start from 1 and increase, you don't need the if instance > 0 check both in createinstance and recycleinstance, you can just multiply or divide it directly, no need for an if check. like this:

function MUI_CreateInstance takes nothing returns integer
    local integer instance

    if ( udg_recycle == 0 ) then
        set udg_instanceCount = udg_instanceCount + 1
        set instance = udg_instanceCount
    else
        set instance = udg_recycle
        set udg_recycle = udg_recycleNext[udg_recycle]
    endif

    // reserving space
    set instance = instance * udg_limit

    return instance
endfunction

function MUI_RecycleInstance takes integer instance returns nothing
    set instance = instance / udg_limit

    set udg_recycleNext[instance] = udg_recycle
    set udg_recycle = instance
endfunction

 

[Ruke]

damn, i forget:

if ( udg_recycle == 0 ) then

that should be == -1

instance begins at 0.

set instance = instance * udg_limit

and

set instance = instance / udg_limit

you're right.

i'll update, thanks again .

 

[FUJI]

When this is approved then I'll check this.

 

[Magtheridon96]

The code is simply abysmal.

I'm blaming Blizzard this time. ;|

 

[Vlad727]

I like the whole Idea, it let's me focus more on the skill/ability I am creating.
It is a template (eh duh ppl it is in the template section) that takes care of the
tedious things that could annoy and bore you.

The only thing is that you have to make a list for yourself what number corresponds
with which type of saved unit.

Also What would happen if I have a channelled spell and an other spellcaster
uses an ability?
(assuming both triggers use the set(1) for casting unit)
That would cause some errors I'm sure.

so must we have a list of corresponding numbers that are each unique to prevent this?
I hope not...

It would still make for some easier spell making.
Which would be great when triggering minion spells
(no need to explain that term right?)

Looks neat and will try. Hope it works.
or get's improved and then approved.

Vlad727

 

[axleion]

just wondering, why not try to contact some Spells section moderator to make notice of this resource? I found that some latest submitted resource already moderated while this one left unmoderated for a month.

approval may not be warrant, but at least you can improve this resource through what those moderators found.

 

[Magtheridon96]

They'll get to it when they'll get to it.

A resource like this is not an easy thing to moderate because you have to consider the impact this will have on future resources.

@Ruke, have you tested how many handles this works with before the op limit kicks in? (Try something like 20 units, items, destructables, effects, etc...)

 

[Maker]

To be honest, I'm not a fan of the system. It does unnecessary work if there is nothing to loop. And it hides the spell making mechanics from the user, using this can make it harder for people to move from gui to jass/vjass. It can still be useful to some people and it think it is approvable.

 

[chobibo]

You have more control over the game when you use jass, vjass makes it easier to control that. Anyway, just to clear things up, I'm not against this system.

 

[chobibo]

vjass makes it into a different syntex.*

It doesn't, it adds functionality but does not change the syntax.

 

[Ruke]

sorry for the lack of attention here. i need to update this (there is a minor but anoying bug there).

It does unnecessary work if there is nothing to loop.

where?

@Ruke, have you tested how many handles this works with before the op limit kicks in? (Try something like 20 units, items, destructables, effects, etc...)

i did not, but shouldn't be any problem (of course, keep in mind that this sacrifices efficiency for sugar).

 

[Maker]

sorry for the lack of attention here. i need to update this (there is a minor but anoying bug there).

What is this bug and have you gotten rid of it already? The resource could be approved soon.

 

[Ruke]

done, working properly

 

[Ruke]

The system has a bit of overhead since it checks for every
type even if they are not used

this checks, are just ifs... i can not thing in another way of doing this (and again, they are just ifs), why are you pointing it out?

 

[Maker]

^Yeah, they are not that performance costly. Still, a custom tailored system would be better instead of a general system.

 

[Kanadaj]

^Yeah, they are not that performance costly. Still, a custom tailored system would be better instead of a general system.

Yea, and a custom-tailored game engine is nearly always better than using something general. But people will keep using general solutions to make things faster even if they lose some of the performance.

 

[Ruke]

chronosphere spell maded with this: http://www.hiveworkshop.com/forums/2457947-post104.html

 

[Lambdadelta]

dat preview pic

 

[Adiktuz]

And it hides the spell making mechanics from the user, using this can make it harder for people to move from gui to jass/vjass.

Yeah... it might even make it hard for them to make MUI if they ever need to make it themselves...

IMHO, it is better to teach users to know how to make MUI by themselves rather than teaching them to rely on a general resource to make MUI for them... that will serve them better in the future... and making MUI after all is not a really complex or hard thing, at least it won't be for much of the things that you can do in GUI...

especially seeing as how the GUI part of this is pretty much all just set-up... and the "hidden" jass part is what does everything...

anyway, yes, the "system" does what it was meant to do... just not fond of this kind of systems...

BTW, it was that pic that made me view this...

 

[Ruke]

Yeah... it might even make it hard for them to make MUI if they ever need to make it themselves...

IMHO, it is better to teach users to know how to make MUI by themselves rather than teaching them to rely on a general resource to make MUI for them... that will serve them better in the future... and making MUI after all is not a really complex or hard thing, at least it won't be for much of the things that you can do in GUI...

making mui with gui isn't hard, but anoying/time-consuming/repetitive and it converts our global variables in a mess. this utility fixes those problems.

 

[Adiktuz]

and makes people not learn how to do it by themselves... just my opinion though...

btw, do you have more nice pictures like that batman? I really like those...

 

[rarigate]

batman != mui

batman isn't related with mui =)

i don't know how i got here, uhm huge bump i guess.

 

[Tal'Rarity]

Batman is totally related with MUI.

Hope to see a update Ruke on any idea's how to increase the limitations of your system.

 

[rarigate]

Batman is totally related with MUI.

Hope to see a update Ruke on any idea's how to increase the limitations of your system.

batman is the boss of mui

 

[Marcos_M]

Everybody should use this shit.. out of 5