Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
18:02, 29th Aug 2011
Bribe: Your Utils library is absolutely terrible, if you need to know
why I can explain it better, but I recommend just posting in Triggers &
Scripts to get feedback on how you can improve it. You destroy a
group even though the user might not want it, you declare useless
locals, the library name is way too generic for such specific things.
• Your indentation got messed up.
• I2R is always avoidable should be (integer + 0.)
• You don't need TimerUtils for a period of 0.03, you could either use a unit group loop or use some form of manual indexing.
IcemanBo: Too long as NeedsFix. Rejected.
18:02, 29th Aug 2011
Bribe: Your Utils library is absolutely terrible, if you need to know
why I can explain it better, but I recommend just posting in Triggers &
Scripts to get feedback on how you can improve it. You destroy a
group even though the user might not want it, you declare useless
locals, the library name is way too generic for such specific things.
• Your indentation got messed up.
• I2R is always avoidable should be (integer + 0.)
• You don't need TimerUtils for a period of 0.03, you could either use a unit group loop or use some form of manual indexing.