MUI? How to make it leakless with this?

[Mitzui]

I made an attack system, is it in MUI? or just simple GUI?
I know how to make the trigger leakless but i dunno in this player number

--can someone edit this trigger? and post it here?
--known error on this:
*when i attack, the hero stops and after attacking goes away from enemy

• Attack
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Attack
  • Actions
    • Set AttackLoc[(Player number of (Triggering player))] = (Position of (Triggering unit))
    • Set AttackGroup[(Player number of (Triggering player))] = (Units within 250.00 of AttackLoc[(Player number of (Triggering player))])
    • Unit - Order (Casting unit) to Stop
    • Animation - Play (Triggering unit)'s attack animation
    • Unit Group - Pick every unit in AttackGroup[(Player number of (Triggering player))] and do (Actions)
      • Loop - Actions
        • Unit - Cause (Triggering unit) to damage (Picked unit), dealing 5.00 damage of attack type Normal and damage type Normal
    • Custom script: call RemoveLocation(what will i put here?)
    • Custom script: call RemoveGroup?(what will i put here?)

 

[The_Silent]

GUI can be MUI.
Your trigger seems to be both. Just avoid wait actions while using the standart wc3 trigger system (GUI).

 

[Mitzui]

but i need it in multiplayer so players can attack the same time.

can you do that? please? thanks.

 

[The_Silent]

But it can...
I'm confused though, isn't "Attack" a command? Or have you made an ability yourself called attack?

 

[Mitzui]

i removed each hero's attack command, and make an ability named "attack"

 

[Kala]

Here's a fixed version of your trigger.

• Attack
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Avatar
  • Actions
    • Set AttackLoc = (Position of (Triggering unit))
    • Unit - Order (Triggering unit) to Stop
    • Animation - Play (Triggering unit)'s attack animation
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 250.00 of AttackLoc) and do (Actions)
      • Loop - Actions
        • Unit - Cause (Triggering unit) to damage (Picked unit), dealing 5.00 damage of attack type Spells and damage type Normal
    • Custom script: call RemoveLocation(udg_AttackLoc)

 

[Mitzui]

is that mui?

and i tried the trigger, the unit attacks, but after attacking it goes away from the enemy plus it damage it self

 

[rysnt11]

Easy things..
Add if then else function
In the condition,add picked unit not equal to caster
Then, if you didn't want the attacker to 'flee' then, untick in the 'can flee' in object editor

 

[Mitzui]

can you post a screen with the "flee"?? i dunno that.

 

[rysnt11]

Search the oe, the unit one, i'm not in front of my pc now...
I think it should be in unit, about 'combat - can flee'

 

[mckill2009]

"Unit Group - Pick every unit in (Units within 250.00 of AttackLoc) and do (Actions)"

- 250 is big
- you have to put an offset of 128 facing the caster and matching unit is enemy so that the caster will not damage himself ...

 

[Adiktuz]

there's no need to order him to stop... actually it might the animation look bad...

 

[Mitzui]

is this system can be used by more than one player?

 

[Kala]

If you dont want it do damage self or allies, add this:

• Actions
  • Unit Group - Pick every unit in (Units within 512.00 of AttackLoc) and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • ((Picked unit) belongs to an ally of (Owner of (Triggering unit))) Equal to False
        • Then - Actions
          • Unit - Cause (Triggering unit) to damage (Picked unit), dealing 5.00 damage of attack type Spells and damage type Normal
        • Else - Actions

And yes, its MUI, so it works on all units.