Mind Tolerance v1.0

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

04:32, 7th Jan 2015
IcemanBo:
http://www.hiveworkshop.com/forums/spells-569/mind-tolerance-v1-0-a-259474/#post2636910

 

[defskull]

Reserved~
There are some hidden mechanics for this spell, but it doesn't show in the tooltips (because no more space).
The mechanic is that, if you take a fatal damage, it would set your HP to a certain fixed amount, right ?
But if your currentHP > fatalHeal, the set life won't occur.

Example 1:
You take fatal damage, and it will set your HP to 400, but your current HP right now is 500, therefore, no setLife action occurs.

Example 2:
You take fatal damage, and it will set your HP to 400, but your current HP right now is 200, therefore, setLife action occurs which results in your HP to become 400.

Comments and Feedback are much appreciated, because I'm a long-time spell/system maker, maybe there are obsolete technique in the making of these triggers, please do tell

 

[IcemanBo]

Hey there! The concept seems interesting!

Maybe you could change the floatings as optional in a further update. As their amount is limited, I can imagine a user could have want to have it disabled.

As optimization you could use one global dummy, and just always change the ownership. This way you can reduce heavy unit creation operations.

Following line is pretty long and quite unreadable:

Too long line

• Unit Group - Pick every unit in (Units within MT_AOE[MT_Key] of TempLoc matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is Mechanical) Equal to False) and ((((Matching unit) is alive) Equal to True) a and do (Actions)

Using an If/Then/Else to check all the conditions would better, and then you can use the variable instead of refering to "MatchingUnit" each time.

The check, to turn off the periodic trigger should be done when the effect of an instance ends.
Also using an own integer as counter would be more efficient than checking if a group is empty.

Could be configurable:
- Attack-, and Damagtype
- Attachmentpoints

What condition exactly has to match for fatal damage?

 

[Almia]

and also that line leaks

 

[defskull]

Hey there! The concept seems interesting!

Maybe you could change the floatings as optional in a further update. As their amount is limited, I can imagine a user could have want to have it disabled.

As optimization you could use one global dummy, and just always change the ownership. This way you can reduce heavy unit creation operations.

Following line is pretty long and quite unreadable:

too long line Unit Group - Pick every unit in (Units within MT_AOE[MT_Key] of TempLoc matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is Mechanical) Equal to False) and ((((Matching unit) is alive) Equal to True) a and do (Actions)

Using an If/Then/Else to check all the conditions would better, and then you can use the variable instead of refering to "MatchingUnit" each time.

The check, to turn off the periodic trigger should be done when the effect of an instance ends.
Also using an own integer as counter would be more efficient than checking if a group is empty.

Could be configurable:
- Attack-, and Damagtype
- Attachmentpoints

What condition exactly has to match for fatal damage?

1. The Floating Text configurable would be in the next update
2. I was thinking about using Dummy Caster system, but was too lazy at the moment to import it, maybe I'll do it later on
3. I agree with the unreadable part for the (Matching unit) comparison, will do line by line
4. I was thinking of using custom integer to keep track of instances, but this is a Hashtable-method, not Indexing, so... I kinda need to perform extra if operation, because it doesn't allow "Stacking", whenever same unit cast the ability within intended duration, it will refresh the timer, but won't "add" to the IntegerCount. Perhaps I would do this in the next update.
5. DmgType and AttachmentPoint for configurable would be in the next update.
6. The condition for "fatal" is that, fatalDamage > currentHealth.

and also that line leaks

Which part is the leak ?
Can you tell me so that I can fix it in the next update.

Thanks for comments so far.

 

[Vinz]

bjwantDestroyGroup is present so I doubt it's that line. Anyways, I agree about using ITE inside the periodic loop to filter units while avoiding extra FCs.

However, it doesn't seem to be filtering enemies?

 

[defskull]

while avoiding extra FCs.

What is FCs ?

However, it doesn't seem to be filtering enemies?

Filter from what ?
Not clear.

 

[Vinz]

FC = Function Calls

I meant it doesn't check if the Matching Unit is an enemy.

 

[defskull]

I meant it doesn't check if the Matching Unit is an enemy.

You mean for the Dispersion Damage ?
It does check, but the condition is too long, that's what Iceman suggested, to do the conditions by line, it would make it more readable.

 

[deathismyfriend]

The unit group line should be taken and made into an ITE. to sort out the picked units. This will be much easier to edit and much more efficient than using all of those Matching unit cases.

 

[GywGod133]

• Trigger - Turn on MT Loop <gen>

You need to put this on ITE

For my suggestion, call DestroyGroup() is better than set bj_wantDestroyGroup = true

Unit Group

• Unit Group - Pick every unit in (Units within MT_AOE[MT_Key] of TempLoc matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is Mechanical) Equal to False) and ((((Matching unit) is alive) Equal to True) a and do (Actions)

put it in ITE

 

[defskull]

You guys don't need to remind same point over and over again lol.
Find new points, come on... be original @@"

For my suggestion, call DestroyGroup() is better than set bj_wantDestroyGroup = true

For DestroyGroup(), first you need a group variable, later an operation to be called to save all unit inside the Unit Group.
See ?
That has already takes time.
Also, this group is meant to be temporary, doesn't even need to waste a variable just for a temporary group (Temporary Variables like Real, Int, is different, because this requires reference/calculations to multiple other results)

The way I see it, it serves the same purpose with same efficiency.

Like I said, only to pick unit within range, that's it.
Doesn't even need a variable to waste the storage.

 

[deathismyfriend]

For my suggestion, call DestroyGroup() is better than set bj_wantDestroyGroup = true

This is not true. All GUI unit group actions check to see if the unit group should be destroyed. Thus the boolean value bj_wantDestroyGroup. If bj_wantDestroyGroup is true it then calls DestroyGroup(). So it can't be better.

 

[Almia]

The on with Pick every unit block

 

[IcemanBo]

• Please add import instructions.
• It's not really the system's job to display the damage/healings via floatings. Please seperate it.
• Use one global dummy.
• You could use a counter to check if the loop has to be turned on/off.
• You could think of a limit for the amount damage absorbtion. It could be set seperatly for each level.
• Damage- and Attack type should be configurable. Just as attachment points.
• The learning tooltip is too long. Shorten it, because it's not fully shown in game.
• Add short and useful comments. Especially needed for the user.

Needs Fix

 

[Almia]

actually the texttags are not necessary.