Memory Leaks Checker v1.6

[Moderator]

12:03, 6th Dec 2013
Maker: This system can be useful but I still recommend learning
to check leaks yourself

 

[Rheiko]

whoa,
you use my spell as a sample?? nice onee-chan
you no longer use your template?

 

[nhocklanhox6]

Forgot update system code , no i use your spell forever ^^

 

[Geshishouhu]

Nice idea, hope it can be approved. +Rep

 

[Rheiko]

i guess it will, it's really useful!

 

[Manasurge]

If it can't check

bj_wantDestroyGroup = true

does that also mean it can't check

call RemoveLocation(udg_Point)

and the likes either or just that single line?

EDIT: I couldn't get it to work when importing it gave me a bunch of errors, this could be my issue only though since I've never imported a jass trigger before. I'm using standard Wc3 World Editor if Jass requires something specific.

 

[Rheiko]

maybe jass and scripts only

 

[nhocklanhox6]

bj_wantDestroyGroup is not native function and i just noticed that because some people use it to destroy group though custom script

 

[deathismyfriend]

This is not JASS
This is vJass

Please name the systems correctly.

In your how to import please note that they need JNGP as this is vJass.

You are naming your variables wrong.
ThisIsForFunctionNames
thisIsForMethodNames
ThisIsForStructNames
thisIsForGlobalVariables
thisIsForLocalVariables
THIS_IS_FOR_CONSTANT_VARIABLES

 

[nhocklanhox6]

Okay, thank death , i know that (Naming), but i'm lazy to fix again ="=, i'll try to fix it later.

 

[chobibo]

Cool, counts leaks. Will you include a garbage collector for GUI next update? that would be great. Sorry that was a stupid suggestion lol.

 

[axleion]

I'm wondering about one thing,

this requires JNGP while most GUI user aren't using JNGP after all and those who use JNGP probably using vJASS or at least JASS. aside from that, this thing is good for GUI user, but can you tell me what does yours do that different with this, both are designed for GUI users, require JNGP, and working with leaks.

btw, from your screenshot, mind if you explain what is the meaning of "result", "remaining", "cleaned", "improper"?

how come total leak result = 66, leak cleaned = 131, and remaining leak = -65? there are 66 leak and you clean 131, probably your system interfere with other used variables.

also, I suggest you to only display those message during debug mode.

    private function ForGroupBJDetector takes group g,code c returns nothing
        set GROUP_TOTAL_LEAKS = GROUP_TOTAL_LEAKS + 1
        set GROUP_LEAKS_REMAINING = GROUP_LEAKS_REMAINING + 1
    endfunction
    //
    hook ForGroupBJ ForGroupBJDetector
    //
    private function ForGroupDetector takes group g,code c returns nothing
        set GROUP_TOTAL_LEAKS = GROUP_TOTAL_LEAKS + 1
        set GROUP_LEAKS_REMAINING = GROUP_LEAKS_REMAINING + 1
    endfunction
    //
    hook ForGroup ForGroupBJDetector
    //

function ForGroupDetector is not used

 

[T. D. W.]

Personal Words

Review

Suggestions

Rating

Judgement

Note

COOL

You need to specify that it's vJASS and not JASS
You should do like this for example:
Total Effect Leaks = effects remaining - cleaned
Anyway, my KB3D System is leakless lol xD

You should do like this for example:
Total Effect Leaks = effects remaining - cleaned

If You want me to review an Update of This Spell, Please Notifiy me this by VM or PM

 

[msongyboi]

this is absolutely ballin

if it works 100% accurately then dayum...

edit: doesn't work for jass lulz, still gud i guess

 

[Daffa]

The best usage of this VS Leak Destroyer is that this one trains user knowledge and make them learn more about leaks, which I really supports.

 

[deathismyfriend]

The best usage of this VS Leak Destroyer is that this one trains user knowledge and make them learn more about leaks, which I really supports.

Yes that is the good part.
Don't make this so it cleans the leak. Just so it's a leak detector. It is nice.
You should hook some functions for jassers though.
Jassers shouldn't need it but i guess it is good to have it for them also.

 

[nhocklanhox6]

Dark

I'm wondering about one thing,

this requires JNGP while most GUI user aren't using JNGP after all and those who use JNGP probably using vJASS or at least JASS. aside from that, this thing is good for GUI user, but can you tell me what does yours do that different with this, both are designed for GUI users, require JNGP, and working with leaks.

btw, from your screenshot, mind if you explain what is the meaning of "result", "remaining", "cleaned", "improper"?

how come total leak result = 66, leak cleaned = 131, and remaining leak = -65? there are 66 leak and you clean 131, probably your system interfere with other used variables.

also, I suggest you to only display those message during debug mode.

    private function ForGroupBJDetector takes group g,code c returns nothing
        set GROUP_TOTAL_LEAKS = GROUP_TOTAL_LEAKS + 1
        set GROUP_LEAKS_REMAINING = GROUP_LEAKS_REMAINING + 1
    endfunction
    //
    hook ForGroupBJ ForGroupBJDetector
    //
    private function ForGroupDetector takes group g,code c returns nothing
        set GROUP_TOTAL_LEAKS = GROUP_TOTAL_LEAKS + 1
        set GROUP_LEAKS_REMAINING = GROUP_LEAKS_REMAINING + 1
    endfunction
    //
    hook ForGroup ForGroupBJDetector
    //

function ForGroupDetector is not used

Only display text when you type -lc, i think it's good for some reason.
Let's take a look here:
result: 1 + 1 = 2, the result is: 2
"there are 66 leak and you clean 131", Yup, Rheiko destroy/remove leak too much, remove it > set it, haha
remaining: If you have two candy, you eat one, candy remaining is: one
cleaned: Well, when you RemoveLocation/DestroyGroup/DestroyForce/DestroyEffect, leak(s) clean + 1, it's just a total those function is called.
improper: When you destroy a null varriable.
--
I don't think Automatic Leak Destroyer is good, if the author use hook for capture, well, it okay but if use it for destroy the leak, i think it impossible.

There are functions that are outside of our control most of the times, like natives and those in blizzard.j. The hook keyword allows us to detect them.

Use hook, the name of the native/bj function and the name of a function or static method and you will be able to detect when that native is called and also capture the arguments given to it.

The arguments hook just same with arguments of that function.

It's just a first version, system running not good as well, but i'll update it as soon as possible.

@Death: Yup, i'll update it

 

[nhocklanhox6]

System updated, new result, hmm..

 

[Rheiko]

is it bad if i destroy/remove leak too much?

 

[axleion]

"there are 66 leak and you clean 131", Yup, Rheiko destroy/remove leak too much, remove it > set it, haha
remaining: If you have two candy, you eat one, candy remaining is: one
cleaned: Well, when you RemoveLocation/DestroyGroup/DestroyForce/DestroyEffect, leak(s) clean + 1, it's just a total those function is called.
improper: When you destroy a null varriable.

so this can be summarized into: count how many times handle created through each function hook, then count how many times the destroy & remove handle is called, wouldn't it report the wrong value if the user is put destroy on wrong handle or in case of double-destroy?

look at this post of yours and compare it with the trigger itself, I do find the result is different from the expected result. it has at least 33 group leak per second yet yours record 0 group leak.

 

[Daffa]

Yes, In some cases.
Why? Because unnecessary operation for destroying those leaks might cause lags on weaker PC.

 

[deathismyfriend]

It will also report wrong results if those locations are used throughout the whole map.
Example: I create a location array for spawn locations for each player called spawnLoc[Players 1 to 12]
If i use them throughout the whole game they do not leak but the leak detector will show them as leaking.

 

[nhocklanhox6]

@Dark: Let's take a look on Capture list , it does not support Pick Group but i will add it as soon as possible, thanks a lot , and also this system now supporting Wrong/Double clean leak.

 

[chobibo]

Maybe you should change the label leaking to using so as to not confuse the potential users.

 

[Manasurge]

What are the requirements to use vJass in your map? If there's something specific requirement you should put that in the description.

 

[Ofel]

bj_wantDestroyGroup = true is still can be used, right?
When it's 'true' and we pick a unit group using ForGroupBJ that contain:

function ForGroupBJ takes group whichGroup, code callback returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    call ForGroup(whichGroup, callback)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
endfunction

 

[nhocklanhox6]

It will also report wrong results if those locations are used throughout the whole map.
Example: I create a location array for spawn locations for each player called spawnLoc[Players 1 to 12]
If i use them throughout the whole game they do not leak but the leak detector will show them as leaking.

I don't think so, when you use location/group or force, your map/my system show them as leaking because it's leak even you use it thoughout the game

@mana: just requires JNGP and i add it already .

@Ofe: Yup but my system can't check bj_wantDestroyGroup even it = true or false but that group still destroyed if = true

 

[chobibo]

I don't think so, when you use location/group or force, your map/my system show them as leaking because it's leak even you use it throughout the game

It's not a leak since it can be manipulated and is still useful. Leaks are data occupying memory that cannot be returned to the system. If the object is to be used throughout the game then it's not a leak.

The more appropriate term is memory usage.

EDIT: clarified my last sentence on the first paragraph.

 

[nhocklanhox6]

It's not a leak since it can be manipulated and is still useful. Leaks are data occupying memory that cannot be returned to the system, if it's used throughout the game then it's not a leak.

The more appropriate term is memory usage.

Hmm, but it was created and it still occupies ram, more like that still lag the game, right?

 

[chobibo]

Yes, but that doesn't mean it's leaking memory. It needs to be placed in memory to be used.

Your analogy is wrong, if we follow your analysis, then everything in memory is a leak, we might as well not use memory (since programs needs to use memory), or the computer.

 

[nhocklanhox6]

Yes, but that doesn't mean it's leaking memory. It needs to be placed in memory to be used.

Your analogy is wrong, if we follow your analysis, then everything in memory is a leak, we might as well not use memory (since programs needs to use memory), or the computer.

Okay, i get it, i'll try to fix it, thanks a lot.

 

[deathismyfriend]

I don't think so, when you use location/group or force, your map/my system show them as leaking because it's leak even you use it thoughout the game
@Ofe: Yup but my system can't check bj_wantDestroyGroup even it = true or false but that group still destroyed if = true

That was my point for the first one.

For the second it should detect it since bj_wantDestroyGroup is a boolean used for an ITE. In that ITE DestroyGroup is called. As long as your system detects DestroyGroup it will detect that also.

Yes, but that doesn't mean it's leaking memory. It needs to be placed in memory to be used.

Your analogy is wrong, if we follow your analysis, then everything in memory is a leak, we might as well not use memory (since programs needs to use memory), or the computer.

It is not his analogy it is just the capabilities of the system can't catch that

 

[chobibo]

I was talking about his analogy, not the script itself.

 

[nhocklanhox6]

For the second it should detect it since bj_wantDestroyGroup is a boolean used for an ITE. In that ITE DestroyGroup is called. As long as your system detects DestroyGroup it will detect that also

No, it doesn't, after tested it, i can't catch bj_wantDestroyGroup

 

[deathismyfriend]

No, it doesn't, after tested it, i can't catch bj_wantDestroyGroup

It calls DestroyGroup. You can't hook a boolean check but if DestroyGroup is hooked then it should catch them.

Can you post a test map so i can see ?

 

[iAyanami]

No, it doesn't, after tested it, i can't catch bj_wantDestroyGroup

bj_wantDestroyGroup is simply a boolean which determines whether DestroyGroup should be ran or not. I'll just post the ForGroupBJ code as an example.

function ForGroupBJ takes group whichGroup, code callback returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    call ForGroup(whichGroup, callback)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
endfunction

 

[deathismyfriend]

bj_wantDestroyGroup is simply a boolean which determines whether DestroyGroup should be ran or not. I'll just post the ForGroupBJ code as an example.

function ForGroupBJ takes group whichGroup, code callback returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    call ForGroup(whichGroup, callback)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
endfunction

That is exactly what i have said lol. The trigger should be able to catch the call DestroyGroup() in the ForGroupBJ.

The thing that may give bad results is that ForgGoupBJ and ForGroup run when using ForGroupBJ. Which will show it as 2 leaks instead of 1 if both are hooked.

@TO
You should only hook ForGroup. Do not hook ForGroupBJ. It will give unwanted results because of the explanation above.
You should only hook the native functions not the GUI functions for everything.

 

[nhocklanhox6]

GUI func didn't add a weird code like hooked func, so why not ? ,
Yeah i missing something here, i'll check and fix it . Thank both of you ^^
----------
bj_wantDestroyGroup is not a native function, so i can't hook it also my system can't catch it too, just catch when destroygroup func is called, you can test whatever i say is true, i can show test map about this thing right now because i'm using mobile.

 

[iAyanami]

GUI func didn't add a weird code like hooked func, so why not ? ,
Yeah i missing something here, i'll check and fix it . Thank both of you ^^
----------
bj_wantDestroyGroup is not a native function, so i can't hook it also my system can't catch it too, just catch when destroygroup func is called, you can test whatever i say is true, i can show test map about this thing right now because i'm using mobile.

If you did hook DestroyGroup, then your system should detect it perfectly fine.

 

[nhocklanhox6]

@Yana: You must test it before say that , i test this thing >20 times but my system still catch wrong, and after test ForGroupbJ, nothing wrong with it, your ForGroupBj are Bj -> Native, is not a real ForGroupBj of blizzard, in my test map on attachment, i use ForGroupBj in GUI 600 times and my system catch it 600 times instead of 1200 times

 

[deathismyfriend]

That doesn't make sense and as we have said a ton of times already we know bj_wantDestroyGroup is not native. It isn't even a function it is a boolean. You can't hook it.....

If your DestroyGroup function is hooked then it should work. You should only hook native function calls not BJs that call natives.

Please supply test maps so we can better help test this to make it better.

 

[nhocklanhox6]

Okay, a ton of times, a heavy word to me , my heart is broken........, i'm just try to tell: i can't catch it, anyway, the test very simple:

• Melee Initialization
  • Events
    • Time - Elapsed game time is 0.00 seconds
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Set g = (Units in (Playable map area))
    • Unit Group - Pick every unit in g and do (Actions)
      • Loop - Actions

Here the results:
Total leaks group results: 1
Total leaks group remaining: 1
Total leaks group cleaned (Destroyed): 0

That it's , if my system catch bj_wantDestroyGroup = true. Total leaks group cleaned (Destroyed) must = 1, != 0 ....Correct me if i show a wrong test code.

 

[Rheiko]

Okay, a ton of times, a heavy word to me , my heart is broken........, i'm just try to tell: i can't catch it

be strong onee-chan, You can go through all this!

 

[iAyanami]

Ah yes, just remembered that BJ functions do not call the hook functions (even if the actual hooked native is called within the BJ).

And IIRC, hooks compiles into bunch of ugly trigger evaluations instead of function calls. But I guess it isn't relevant here, since efficiency isn't a problem at all.

 

[chobibo]

Won't this work? I don't know how hooks are implemented internally, but as I understand, it replaces the hooked function.

    private function ForGroupBJDetector takes group g,code c returns nothing
        if (not bj_wantDestroyGroup) then
        set GROUP_TOTAL_LEAKS = GROUP_TOTAL_LEAKS + 1
        set GROUP_LEAKS_REMAINING = GROUP_LEAKS_REMAINING + 1
        endif
    endfunction

 

[iAyanami]

Won't this work? I don't know how hooks are implemented internally, but as I understand, it replaces the hooked function.

    private function ForGroupBJDetector takes group g,code c returns nothing
        if (not bj_wantDestroyGroup) then
        set GROUP_TOTAL_LEAKS = GROUP_TOTAL_LEAKS + 1
        set GROUP_LEAKS_REMAINING = GROUP_LEAKS_REMAINING + 1
        endif
    endfunction

Just tested this and it works. So yeah, could use this to detect bj_wantDestroyGroup.

 

[Almia]

We already have a Leak Checker. Created years ago.
Also, hooks.

 

[Rheiko]

errr, where?
i could only found one with needs fix mark

 

[bowser499]

My friend, this system can be drastically optimized! ^_^