Mana Controller Spellpack 1.2

[Moderator]

10:25 14th Nov 2015
BPower: Rejecting due to the status of this resource being "needs fix" for years.

15:43, 27th May 2010
TriggerHappy:

Nothings Configurable.
Uses waits.
Use some indentation please.

These are also really simple spells. I'm not sure if they should be approved regardless of code quality.

 

[hell gate]

befor rating
use [ jass] (without space)
and [ hiden]

 

[Axarion]

Bleh

Use coordinates instead of locations do what said above and make your code look better it sucks to read it right now Also in your screenie its made not maded >.<
Also your using bjs and PolledWait avoid these!

 

[Just Fear]

Bleh

Use coordinates instead of locations do what said above and make your code look better it sucks to read it right now Also in your screenie its made not maded >.<
Also your using bjs and PolledWait avoid these!

Bleh

Thx u for ur reply u helped me alot +rep
and about gramar errors, i am from Russia and don't really speak English

 

[hell gate]

too much BJ
you can replace them with natives

GetHeroStatBJ(bj_HEROSTAT_INT, GetTriggerUnit(), true) => GetHeroInt(whichHero, includeBonuses)
GetUnitStateSwap => GetUnitState(whichUnit, whichState)
UnitDamageTargetBJ => UnitDamageTarget(whichUnit, target, amount, true, false, whichAttack, whichDamage, WEAPON_TYPE_WHOKNOWS)
__________________________________________________________________________
GetAttackedUnitBJ => GetTriggerUnit()

this is easy to replace

 

[baassee]

dont remake the locations, create at ini and use the "MoveLocation" native.

btw you only need one location to check the Z else you can get the x's and y's from GetUnitX/Y instead, less work

fix the BJs as said above

no need for the effect local just do

call DestroyEffect(AddSpecialEffectTarget( "Abilities\\Weapons\\DragonHawkMissile\\DragonHawkMissile.mdl", GetSpellTargetUnit(),"overhead" )

 

[ChaosKnight]

You could use Damage, for damage detecting.

 

[baassee]

or This and this and this

EDIT: ops sorry

 

[hell gate]

or This and this and this

last link....
URL="this" -_-

 

[baassee]

edited

 

[PurgeandFire]

Eh, don't use polled wait. It will get pretty bad efficiency. The only good thing about it is that it is slightly less random than direct TriggerSleepAction(). PolledWait doesn't null the timer, so you generally shouldn't use it. Timers are also much better. But if you insist on a less-random-TSA, then you should use this instead:

function PolledWait2 takes real duration returns nothing
    local timer t
    local real  timeRemaining

    if (duration > 0) then
        set t = CreateTimer()
        call TimerStart(t, duration, false, null)
        loop
            set timeRemaining = TimerGetRemaining(t)
            exitwhen timeRemaining <= 0

            // If we have a bit of time left, skip past 10% of the remaining
            // duration instead of checking every interval, to minimize the
            // polling on long waits.
            if (timeRemaining > bj_POLLED_WAIT_SKIP_THRESHOLD) then
                call TriggerSleepAction(0.1 * timeRemaining)
            else
                call TriggerSleepAction(bj_POLLED_WAIT_INTERVAL)
            endif
        endloop
        call DestroyTimer(t)
        set t = null  //simply added this to allow the timer's index to be recycled
    endif
endfunction

 

[Just Fear]

Eh, don't use polled wait. It will get pretty bad efficiency. The only good thing about it is that it is slightly less random than direct TriggerSleepAction(). PolledWait doesn't null the timer, so you generally shouldn't use it. Timers are also much better. But if you insist on a less-random-TSA, then you should use this instead:

function PolledWait2 takes real duration returns nothing
    local timer t
    local real  timeRemaining

    if (duration > 0) then
        set t = CreateTimer()
        call TimerStart(t, duration, false, null)
        loop
            set timeRemaining = TimerGetRemaining(t)
            exitwhen timeRemaining <= 0

            // If we have a bit of time left, skip past 10% of the remaining
            // duration instead of checking every interval, to minimize the
            // polling on long waits.
            if (timeRemaining > bj_POLLED_WAIT_SKIP_THRESHOLD) then
                call TriggerSleepAction(0.1 * timeRemaining)
            else
                call TriggerSleepAction(bj_POLLED_WAIT_INTERVAL)
            endif
        endloop
        call DestroyTimer(t)
        set t = null  //simply added this to allow the timer's index to be recycled
    endif
endfunction

ok will add it to Custom Code of the map and use as polled wait

 

[hell gate]

or you use TimerUtils
but this needs vJass knowledge

 

[Just Fear]

or you use TimerUtils
but this needs vJass knowledge

If i understanded u right then when i will create timer (by newtimer func) i need to give him value (index) and then i will just delete something[gettimervalue].
Do i understand u right?

 

[hell gate]

yea something like that ^^