Lightning Wave v1.4

[Moderator]

Bribe:

For the revive trigger:

Avoid ((Owner of (Dying unit)) in favor of (Triggering player)

Avoid (Dying unit) in favor of (Triggering unit)

- Though these have nothing to do with the import of the spell so I don't count them.

"-------- Converted into JASS, cuz Magtheridon96 said: "They're pretty efficient in JASS " No problem then. --------"

Actually the custom scripts you chose would have been exactly the same as the GUI equivelant, so this grievance could have been avoided.

The special effects are very heavy in this spell and cause my computer to lag when cast. If you created half as many it would be approvable I think, because the effect does look neat.

Maker, v1.4, 14.07.2011
Approved. However you could create less thunder claps and the tooltip could be a bit more standard.

 

[Magtheridon96]

• Set LW_Distance[LW_Index2] = (Distance between LW_Point1 and LW_Point2)
  • Set LW_Angle1[LW_Index2] = (Angle from LW_Point1 to LW_Point2)

This is highly optional: If you want to make your code look better, you could do these
in custom script They're pretty efficient in JASS
----

Also, you leak Point1 (You're only destroying one of it's instances in the loop trigger)

 

[Nightmare Moon]

Also, you leak Point1 (You're only destroying one of it's instances in the loop trigger)

Emm, what you mean by that? Should i create in loop trigger again or...?
And with the first thing, if it doesn't really matters then i'll update later.

Edit: well maybe i should make the point an array then?

 

[Magtheridon96]

Edit: well maybe i should make the point an array then?

Exactly ^^
Everything in GUI should be arrayed in an indexing system unless it's constant

 

[Nightmare Moon]

Okay then, but i'm sure that Adiktuz, Bribe, baassee (as always ) will tell me that using arrays is bad since they need more memory...
Updating...

Edit: update canceled, going to bed, I'll update in about 10 hours, for now you have a chance to reveal more surprises (leaks, bugs...).

 

[Magtheridon96]

Using arrays is actually needed when using an indexing system

When you're using arrays like this:

Set loc[1] = bla
Set loc[2] = blabla

It's bad.

You should only use arrays in 2 cases:
-When you need about 10-8000 instances of something (Especially in most recipe systems in which about 80-120 instances are required)
-When you have an indexing system.

 

[Marcos DAB]

Need some improves, but maybe very useful.

 

[Nightmare Moon]

Need some improves, but maybe very useful.

Tell me what improves, some improves isn't answer... I asked in description that it does but it's you duty to find out right? Maybe you do have ideas? I'd be glad to hear 'em

Updated

 

[Maker]

Make the learn tooltip more like in standard Blizz abilities.
Make learned tooltip list the stats of the current level, not for other levels.
Chance the learn position of the tooltip to (0,0).
You don't need I2R here:

• Custom script: set udg_LW_Angle2 = udg_LW_Multiplier * udg_LW_Count //maximum angle of wave

Why are LW_Damage variables integers? They should be reals.
The spell destroys bridges also for example.
You're doing the actions for instances that are already over. You could use a boolean to prevent that.
Is there no follow through time on purpose?
I think you should set disable other abilities to false.

In my opinion you don't need to write GUI lines in JASS. Ofcourse the can be better since BJ's can be skipped. But this is a GUI spell so using GUI is ok. You should've kept the two lines in GUI.

The spell is MUI and doesn't leak. Triggering is good.

 

[Nightmare Moon]

Make the learn tooltip more like in standard Blizz abilities.
Make learned tooltip list the stats of the current level, not for other levels.
Chance the learn position of the tooltip to (0,0).

maker you know how i feel about that! I don't really care because everyone needs their tooltips in another ways, so what's the point?

You don't need I2R here:

• Custom script: set udg_LW_Angle2 = udg_LW_Multiplier * udg_LW_Count //maximum angle of wave

Well i added this because LW_Angle2 is real so real * real looks better) but i'll remove conversion.

Why are LW_Damage variables integers? They should be reals.

Changing!

The spell destroys bridges also for example.

Well need help on this one, since their's no boolean to check whether the destructible is tree or not...

You're doing the actions for instances that are already over. You could use a boolean to prevent that.

What actions exactly?

Is there no follow through time on purpose?

Could you tell where's a difference? I mean why it should be 180?

I think you should set disable other abilities to false.

Right, forgot about that.

In my opinion you don't need to write GUI lines in JASS. Ofcourse the can be better since BJ's can be skipped. But this is a GUI spell so using GUI is ok. You should've kept the two lines in GUI.

Well i guess if it doesn't matters all is okay.

The spell is MUI and doesn't leak. Triggering is good.

Thank you!

Edit: Updated, but not all.

 

[Nightmare Moon]

For the revive trigger:

Avoid ((Owner of (Dying unit)) in favor of (Triggering player)

Avoid (Dying unit) in favor of (Triggering unit)

- Though these have nothing to do with the import of the spell so I don't count them.

Oh i can't believe you fell for this I can't put sarcasm tags in comments man, right? hahaha, i just had a funny day that night, still do...

Actually the custom scripts you chose would have been exactly the same as the GUI equivelant, so this grievance could have been avoided.

Okay will convert back.

The special effects are very heavy in this spell and cause my computer to lag when cast. If you created half as many it would be approvable I think, because the effect does look neat.

Could you suggest me something here? Maybe remove the monsoon target effect?

 

[InfernalTater]

This is basically just an overuse of special effects in a simple and repetitive trigger... It really isn't usable.

 

[Nightmare Moon]

You can control the number of effects if you think there're to much
Edit: updated
Edit: @TLI-Inferno, make me a better one, that would represent a fully controllable wave spell!!! Show me what you got! Than troll!

 

[InfernalTater]

You really need to learn how to accept negative criticism. I am not "trolling", I am simply telling you what the problems are with your spell. By responding to my constructive criticism by challenging me, you are yourself being very foolish.

 

[Nightmare Moon]

nothing to say, you're trolling because you told me nothing what to improve with the spell! You told me nothing knew since i told in description the spell really need something else, but what... So read the description of spell before posting, and btw Bribe and Maker already said that. Relax i'm not challenging you... uhm... And don't be so self confident. Emm this is getting off topic!

 

[InfernalTater]

Stanley, no offense, but you sound like you are either 12 years old or way too sensitive for your age.
Telling you what is wrong with something is to help it. You can't fix something without being told what is wrong with it.
You don't know what trolling is, so don't accuse me of trolling. If you prefer to act like a child, then go ahead and pretend in your la-la-land that everything you make is perfect, while everyone else improves their work because they pay attention when someone points out a fault, and they fix it.

 

[Nightmare Moon]

[off topic]But you didn't tell anything what is wrong man, or i missed it... And i'm not sensitive, i'm a party guy =) And surely i do know what is trolling, believe i've seen enough trolls here on hive... Well i don't act like a child but i'm always laughing! Laughter is life! Try it and your gf will love it =) And i'm kinda sorry for my first post to you that day i was a little angry since i had to fly abroad and my flight was delayed... (da*n!)
[on topic]So tell me what could i improve, but within acceptable, since this is just fully controllable wave spell, not some fancy spell.

 

[InfernalTater]

If I didn't say anything that was wrong, with it, what are you upset about? You are making up excuses left and right. I pointed out exactly what the issue was.
And if you call this trolling, you are just too damn sensitive, because this isn't trolling.
As I said before, the problem with your spell is that it is simply an overdose of special effects. It doesn't actually look like a wave, because all of the lightning effects are a ground shock (the lightning originates from the ground and moves upward, not outward, resulting in it really not looking like a wave, especially when the shocks are distinctly seperate)
If you want it to look like a wave of lightning, you're going to have to completely remake the entire spell using a different special effect and spreading it in a different way. Sorry, but that's what needs to be done to improve this spell.
If you take offense to me telling you how to improve your spell, simply because you want to believe it is perfect, then that's just too bad. Your spell will rot away if you don't improve it simply from a bit of pride... You need to remember, almost EVERYONE's uploads aren't perfect at first, they are usually fixed after upload when the creator reads the comments about what is wrong with whatever he made.

 

[Nightmare Moon]

[off topic]I never said that my spell is perfect and i actually asked for help in description, if i didn't ask then it would be perfect. And actually i said sorry, what else you want to hear? (if you weren't sensitive you'd stop posting ages ago.) ... And you're the one who's been sensitive, not me, i'm not that kind of person, i don
t get upset by something that doesn't matters. So deal with it - you cannot upset me. Okay then i'll be changing the spell now... Topic closed already? Hopefully yeah.
[on topic] Updating... But not uploading, since i fully remaking wave formula and kinda got few issues=) Well, i'll solve them soon enough, guess. So for this one in here is, mmm, lets say beta version.

 

[InfernalTater]

Stanley, you really need to learn to simply accept the criticism, because this entire conversation was because you insisted my first post was trolling, and then you continued to call me a troll. Let's look back at the first post by me, and see "is that trolling".
And then you pull the 5-year-old stunt: "i know you are but what am i"
As for the lightning, if you want it to appear as a blast, I suggest having multiple chain lightning effects originate from the caster and spread outward, occasionally bouncing from unit-to-unit but not changing it's angle of movement more than 15 degrees to hit a unit, to maintain the outward movement.

 

[Nightmare Moon]

Now this is the answer i've been waiting for, for the spell i mean.
And i repeat for the last time that i've said SORRY. Please do not post in this thread anymore.

 

[baassee]

This is basically just an overuse of special effects in a simple and repetitive trigger... It really isn't usable.

I don't see the constructive critisism in this comment. Sorry.

Okay then, but i'm sure that Adiktuz, Bribe, baassee (as always ) will tell me that using arrays is bad since they need more memory...

Damn straight that I do.

Using arrays is actually needed when using an indexing system

When you're using arrays like this:

Set loc[1] = bla
Set loc[2] = blabla

It's bad.

You should only use arrays in 2 cases:
-When you need about 10-8000 instances of something (Especially in most recipe systems in which about 80-120 instances are required)
-When you have an indexing system.

No it's not as it's only two locations and besides your cases arent relevant, recipe system? And I have never seen anyone used ten locations with arrays (that would be pretty overkill).

Indexing system? What are you refering to?

The only thing that you should use arrayed locations to is for storing a point that is going to be used the next period (or a period ahead) and never for temporary locations. And that is what Stanley is doing here.

Sorry if anything of the things I wrote offended anyone above... Or if you have changed things, I just read the comments.

Despite this, the spell.

The level should be stored into a temporary integer variable to get rid of two calls (I2R and GetUnitAbilityLevelSwap(Swap is a BJ btw which contains 1 more call so it's actually 3 calls saved))

Shouldn't LW_Count be an arrayed variable that should increase along with the spell's level? Seems cooler to me. (No need to change though)

Why is

• set udg_LW_Z2 = 50

in custom script? It's the equal in GUI.

Picked Unit should really be stored into a temporary Unit variable.

WTF?! Overpowered? Make an option to make it possible to not allow Heroes into this explosion thingie

• Unit - Cause LW_Caster[LW_Index3] to damage (Picked unit), dealing 100000000.00 damage of attack type Chaos and damage type Universal

And btw 150.00 hp should be changeable and stored into an arrayed variable.

I'm not sure why you are creating and destroying lightnings 33 times a second? Seems stupid to me or? You can always create them at the start and use the native call MoveLightningEx (I think it got the same parameters as well) (Btw this is why Bribe is experiencing lagg)

Also despite destroying and creating, you aren't taking in the height of the ground so correct me if I'm wrong but does it look stupid if the lightning is created between two different terrain points? Can easily be solved with a GetLocationZ(thelocation) + yourheightvariable.

Anyway I like your ideas and the execution.

 

[Nightmare Moon]

Why is
set udg_LW_Z2 = 50
in custom script? It's the equal in GUI.

That's because i wrote this "-------- Copy ^^ this into a line under this to add more realistic effect of height --------
" and for some users it will be easier just to replace the text in custom script, for newbie ones

The level should be stored into a temporary integer variable to get rid of two calls (I2R and GetUnitAbilityLevelSwap(Swap is a BJ btw which contains 1 more call so it's actually 3 calls saved))

will do!

Picked Unit should really be stored into a temporary Unit variable.

Could you tell me why?

Yeah, i think destroying is kinda stupid, so okay i'll create few on the start and then just will move.
Will update later, going outside, now...
Thanks for the review!

 

[baassee]

Tell me if you need any help!

Because each of those "Picked Unit" in the group loops are each one a call of "GetEnumUnit()", setting it into a global will remove all these extra calls. (And don't refer to my old spells, they suck I know )

 

[Nightmare Moon]

Okay will do this too) thanks man. And okay i will tell if i'll need some help.
thanks again
P.S. when i'll have the rep power more then 1 ? cuz i wanna give you more then 1

 

[baassee]

The more rep you have, the more you will give. I think 4 is max.

 

[The General]

Cool vote for approve 5/5