Leap 2.0 - v0.09

[Moderator]

You still have a lot of location leaks. Fix them.
I also added more issues to my last comment.

Leap 2.0 - v0.08 | Reviewed by Maker | 5th Aug 2013

NEEDS FIX

Use a variable for the ability Use a proper way to give the unit the ability to fly The ability can't have mana cost Leap 2 should be initially off and it is not ever turned off Number of units in group == 0 should be checkd only when removing a unit from the group Set up is too generic trigger name You don't flush child hashtable You have location leaks OrderPoint runs for every unit There is not point in set point = some point store point in hashtable move unit instantly to load point Skip the hashtable there Spell Submission Rules url=http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/how-give-unit-ability-fly-201936/[/url]

[tr]

 

[deathismyfriend]

plz place the triggers in hidden tags.

u have a ton of leaks in ur triggers.
anything used twice or more should be stored into a variable and the variable should be used to increase speed and efficiency

all the comments in the triggers make the code harder to read.

 

[doomhammer99]

perfect .
Can someone send me a WC3: Frozen Throne. I REALLY WANT TO CODE RIGHT NOw. >

 

[gorillabull]

no go buy it

 

[Maker]

• Leaks locations, they way you use the hashtable with the positions is not good
• Don't submit v0.01 stuff
• The unit can bounce back from hills created with apply height tool
• You can get stuck on cliffs when jumping from hills created with apply heigh tool
• Get rid of the BJ functions in the custom scripts
• The looping trigger should not be on all the time

 

[wi3122]

• Leaks locations, they way you use the hashtable with the positions is not good
• Don't submit v0.01 stuff
  [*]The unit can bounce back from hills created with apply height tool
  [*]You can get stuck on cliffs when jumping from hills created with apply heigh tool
• Get rid of the BJ functions in the custom scripts
• The looping trigger should not be on all the time

I'll fix everything else but those two things are intended.

 

[deathismyfriend]

if they are intended u should mention that in the explanation on ur spell

 

[Maker]

So you are saying that getting stuck in a place that is not walkable (pathing wise) is intended?

 

[wi3122]

So you are saying that getting stuck in a place that is not walkable (pathing wise) is intended?

Well, you said height tool, as far as i know height tool means height tool, and cliff tool means cliff tool.

 

[Maker]

Sorry, I meant the cliff tool. I copy pasted the line and forgot to change the tool's name. You can get stuck on one tile wide cliffs.

 

[wi3122]

Yeah, i'm working on that, i know you know how tricky to detect them properly it is.


But i think the code is just ok now. I mean, i fixed up all location leaks, the BJ functions on custom scripts and the looping thing.

 

[Maker]

There are location leaks. Position unit offset by x and point conversions.

 

[wi3122]

I didn't know those things leak. Thanks for the tip.

 

[deathismyfriend]

anything that creates a location leaks. so position / center / offset

 

[wi3122]

anything that creates a location leaks. so position / center / offset

I used

A

Set LeapPoint = (Position of (Picked unit) offset by (Load (Key speed) of LeapHandle from Hash) towards (Load (Key angle) of LeapHandle from Hash) degrees)

But now i use

B

Set LeapPoint1 = (Position of (Picked unit))
Set LeapPoint = (LeapPoint1 offset by (Load (Key speed) of LeapHandle from Hash) towards (Load (Key angle) of LeapHandle from Hash) degrees)

I think the last one doesn't leak

 

[deathismyfriend]

as long as u clean the leaks at the end of the trigger they wont leak

also anything u use twice or more store into a varaible and use the variable instead. example: picked unit

 

[wi3122]

also anything u use twice or more store into a varaible and use the variable instead. example: picked unit

Done.

 

[deathismyfriend]

set it right after this.

• Unit Group - Pick every unit in LeapGP and do (Actions)
• Loop - Actions

 

[wi3122]

set it right after this.

• Unit Group - Pick every unit in LeapGP and do (Actions)
• Loop - Actions

I thought that it wouldn't work if a had more than 1 unit in the group. But it does. Thanks



EDIT:

• Leaks locations, they way you use the hashtable with the positions is not good
• Don't submit v0.01 stuff
• The unit can bounce back from hills created with apply height tool
• You can get stuck on cliffs when jumping from hills created with apply heigh tool
• Get rid of the BJ functions in the custom scripts
• The looping trigger should not be on all the time

Now it's done, i've fixed everything.

 

[deathismyfriend]

anything u use twice or more should be stored. so u should store this.

• Key distance

and a few of the other keys u use.

 

[BPower]

You still have location leaks i.e in the cast trigger.
Cast trigger is always getting enabled, not matter if already on.

SetUnitAnimationByIndex may only work for one model type.
Why not run the animation via ability string + follow throught time in the object editor?

You turn off unit collision every 0.03 seconds. Why not just once on spell cast?

Effects should not be hardcoded.

You leak locations in the loop.

CountUnitInGroup enum is a heavy bj, which should not be used to check if a group is empty ...
Dynamic indexing be come handy here.

 

[wi3122]

Thanks! I'll work on those things when i get some more free time.