[Trigger] Leaks?

[Zypher]

• Fade Away
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Set temp_group = (Units in (Playable map area))
    • Unit Group - Pick every unit in temp_group and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Custom value of (Picked unit)) Greater than or equal to (Integer(0.50))
          • Then - Actions
            • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) - (Integer(0.50)))
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • ((Picked unit) has buff Fade Away Aura 1) Equal to True
                • ((Picked unit) has buff Fade Away Aura 2) Equal to True
                • ((Picked unit) has buff Fade Away Aura 3) Equal to True
          • Then - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) has buff Fade Away Aura 1) Equal to True
              • Then - Actions
                • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) + (Integer(1.50)))
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) has buff Fade Away Aura 2) Equal to True
              • Then - Actions
                • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) + (Integer(2.50)))
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) has buff Fade Away Aura 3) Equal to True
              • Then - Actions
                • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) + (Integer(3.50)))
              • Else - Actions
            • Set Coloring = (Real((Custom value of (Picked unit))))
            • Animation - Change (Picked unit)'s vertex coloring to (100.00%, 100.00%, 100.00%) with Coloring% transparency
            • Animation - Change (Picked unit)'s size to ((Coloring + 100.00)%, (Coloring + 100.00)%, (Coloring + 100.00)%) of its original size
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Custom value of (Picked unit)) Greater than or equal to 80
              • Then - Actions
                • Set temp_point = (Position of (Picked unit))
                • Set temp_unittype = Flash
                • Unit - Create 1 temp_unittype for Neutral Passive at temp_point facing Default building facing degrees
                • Set temp_unit = (Last created unit)
                • Unit - Add a 2.50 second Generic expiration timer to temp_unit
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Custom value of (Picked unit)) Greater than or equal to 100
              • Then - Actions
                • Unit - Explode (Picked unit)
                • Set temp_point = (Position of (Picked unit))
                • Set temp_unittype = Dispel
                • Unit - Create 1 temp_unittype for Neutral Passive at temp_point facing 270.00 degrees
                • Set temp_unit = (Last created unit)
                • Unit - Add a 2.50 second Generic expiration timer to temp_unit
              • Else - Actions
          • Else - Actions
    • Custom script: call RemoveLocation (udg_temp_point)
    • Custom script: call DestroyGroup (udg_temp_group)

Any Leaks?

 

[neavea]

You should seriously consider using the "If Then Else" instead of the "If Then Else - Multiple actions". It makes reading triggers a lot easier for yourself included...

Whats the purpose of the trigger? Knowing that could help (at least me) when I am trying to find a problem in triggers.

 

[GhostWolf]

You should seriously consider using the "If Then Else" instead of the "If Then Else - Multiple actions". It makes reading triggers a lot easier for yourself included...

Yes, and having 50 if/then/else's with lots of useless Do Nothing's sure will help.
Besides, believe me it will be x10 harder to read it.


Anyhow, you set temp_point twice and remove it only once.
Remove it right after you create the unit instead.

Also, that bj_wantDestroyGroup is useless since you destroy the group at the end of the trigger.

 

[neavea]

• Example
  • Then - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• ((Picked unit) has buff Fade Away Aura 1) Equal to True
• Then - Actions
• Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) + (Integer(1.50)))
• Else - Actions

These are what I am talking about... I think that these could be converted into 1 code making it easy to read and when your looking for mistakes, you don't have 2 scroll all the way down to the bottom of the trigger to look for it. =D

 

[Zypher]

Thanks sounds like i didn't mess up to bad

The trigger is a aura spell that makes enemy units grow bigger and fade away until they explode in a flash of light. Its cool to say the least.

Thread solved posts after this are ignored

 

[Eleandor]

You must EITHER do this:

• Custom script: set bj_wantDestroyGroup = true
• Pick every unit in group

OR

• Set Temp_Group = bunch of units
• Pick every unit in Temp_Group ...
• Custom script: call DestroyGroup(udg_Temp_Group)

There's no point in doing both at the same time.

 

[PurplePoot]

neava, RoC 'If's (no Multiple Conditions) are more horribly unreadable than the rest of GUI, by far...

 

[neavea]

neava, RoC 'If's (no Multiple Conditions) are more horribly unreadable than the rest of GUI, by far...

Its just my opinion...

 

[PurplePoot]

Fair enough. I personally am a little biased against anything that requires more clicking (Heck, can you blame me? ).

While Multiple Actions ifs may be longer, they don't attmept to scrunch everything on to one line, which is often horrible.