Leak Expertise Needed

[Couchking]

*sigh* How bad does this leak...?

• Actions
  • Set RandomItem = (Random integer number between 1 and 4)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • RandomItem Equal to 1
    • Then - Actions
      • If ((Random integer number between 1 and 5) Equal to 2) then do (Item - Create Worn Sword at (Position of (Triggering unit))) else do (Do nothing)
    • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • RandomItem Equal to 2
    • Then - Actions
      • If ((Random integer number between 1 and 5) Equal to 4) then do (Item - Create Burnished Shield at (Position of (Triggering unit))) else do (Do nothing)
    • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • RandomItem Equal to 3
    • Then - Actions
      • If ((Random integer number between 1 and 5) Equal to 1) then do (Item - Create Bearskin Headpiece at (Position of (Triggering unit))) else do (Do nothing)
    • Else - Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • RandomItem Equal to 4
    • Then - Actions
      • If ((Random integer number between 1 and 5) Equal to 3) then do (Item - Create Mark of Veruse at (Position of (Triggering unit))) else do (Do nothing)
    • Else - Actions
  • Set RandomItem = 0

 

[zandose]

1 for "(Position of (Triggering unit))"

At the start set some variable (point) to "(Position of (Triggering unit))" and replace "(Position of (Triggering unit))" with the variable. And add this to the end (remove the < and >):

• Actions
  • Custom script: call RemoveLocation(udg_<Your variable name>)
  • Custom script: set udg_<Your variable name> = null

Sleep...

 

[Couchking]

Will nullifying a variable still allow me to reset the variable again later?

 

[Marcelo Hossomi]

Yes, but still you don't need to null these variables, once they're globals.
I mean, whenever you use that variable, it will be the same one. So when you null it, you will set it again later. Result: useless.

But you need to remove the location created.

 

[Rmx]

Try out leak cheker V 3.1 at tools it will also give you suggested fixex

BTW you major leak try call RmoveLocation(udg_X) search for it in things that leak

 

[Eleandor]

Also nest those if/then/else actions, it'll make your trigger slightly more efficient. You see, now it checks the value of RandomItem 4 times, while if you would nest them, it would only have to check the value of RandomItem one time if it's equal to 1, two times if it's equal to 2, etc.

 

[Serbianbeast]

What eleandor is trying to say is: If it's 1 then do this; else: check if it's 2 and do that; else check if it's 3 and do that and etc