Launch Nuclear v1.1

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

19:04, 19th Oct 2011
Bribe: You do not need I2R calls unless you are using division.

"== false" is a useless comparison. Just use the "not" keyword.

You do not need to create a local boolean in the DamageGroup method.

Why are you (ab)using the .execute behavior? It is completely useless where you have it compared to a normal function call, and it adds a lot of junk code when compiled. Get rid of it.

FirstOfGroup loops are better than your current setup, because you are not storing any units for the long-term.

TimerUtils is overkill for a timeout of 0.03. Use a lighter timer system for this like T32 for example.

This line is useless, delete it: call SaveInteger(nuc,0,GetHandleId(u),0)

Your conditions and actions should be merged into one.

This could use the new RegisterPlayerUnitEvent library.

 

[Magtheridon96]

I wouldn't recommend using GTrigger. SpellEffectEvent (By Bribe in the Jass section) is extremely efficient unlike Shit-GTrigger

edit
call GT_RegisterBeginsCastingEvent(t,ABILITY_ID)
> lol Nevermind then

 

[jim7777]

you're stalking me , i'll try it next time or maybe tomorrow

 

[Bribe]

Truefilt

Did you know that since at least 2 years filters don't leak?

globalCaseConventionIsLikeThis NotLikeThis.

GetWidgetLife has problems what if the unit's life is set after death?
Better to use IsUnitType, UNIT_TYPE_DEAD.

You can use "null" instead of WEAPON_TYPE_WHOKNOWS

Why are you quickly creating and destroying a group instead of just
using one single global group that never gets destroyed?

Use a single timer that iterates through a stack of units for a timeout
like 0.03 you should not be using dynamic timers for such an easy
timeout.

The timeouts should also be configurable.

Why are you using GetUnitId in parts of the trigger but using a seperate
hashtable in others? Just use one or the other, not both.

 

[Magtheridon96]

Just noticed these:

private function GetDamage takes unit u, integer level returns real
        //set the base damage here (smallest amount)
        local real dmg = level*50
        return dmg
    endfunction
    
    private function DamageIncrement takes unit u, integer level returns real
        //set the increment damage here (damage added in each distance) every INCREMENT_INC second
        local real dmg = level*2
        return dmg
    endfunction
    
    private function MaxMissiles takes unit u, integer level returns integer
        //set the maximum number of missiles in every recharge
        local integer max = 1*level
        return max
    endfunction

My reaction: :[____]

Those aren't inline friendly at all >.<

edit

Use this instead of GTrigger.

 

[Deuterium]

the problem isn't the inlining here Magtheridon96... it's just the 2byte (if i remember right) leak by creating each of these 3 locals which could be avoided easily

 

[maddeem]

You need da bigger boom.

 

[jim7777]

updated

but i can't get this part

Use a single timer that iterates through a stack of units for a timeout
like 0.03 you should not be using dynamic timers for such an easy
timeout.

and @magtheridon96
hmm if it is fixed already D:

 

[Adiktuz]

Instead of using I2R(level)*2, just use level*2.00, etc...

and maybe its better if you specified which unit is u and f, just for those who don't have time to read that much...

 

[jim7777]

ok i got the report
gonna fix this as soon as possible as i can (if i have time)

but i can't remove I2R .. i don't know but my jasshelper requires me to have it there(unfortunately)

 

[Adiktuz]

even if you used 2.00 instead of 2?

 

[Bribe]

Are you using JassHelper 0.A.2.B? It doesn't throw compile errors for me.