Kamehameha v4.0 [GUI] [Fixed]

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

12:20, 1st Jan 2015
Maker: Using pause unit action is not allowed.
It has side affects like pausing the duration of buffs.

 

[ILH]

Post triggers plz.
Btw i saw a thread like this before, did u multi-upload?

 

[GywGod133]

i saw a thread like this before, did u multi-upload?

he delete and reupload again this resource

 

[Ajijang2013]

Alright, Guys. So aren't you guys noticed the unit group problem? When you cast the spell for one more time, the path doesn't appear anymore.

 

[Tank-Commander]

This'll be the second time I make this post (since the previous upload of this was deleted, and yeah use the update button, don't delete and reupload) with a fresh list of issues (and some repeated ones hence the use of the word "still")

• Unit Group - Remove (Last created unit) from Ka_UG

Removes the wrong unit from the unit group, should remove the picked unit.

• Unit - Move Ka_Dummy[Ka_Index[3]] instantly to Ka_Loc[4]

Still should be done with SetUnitX/SetUnitY custom script lines (see previous post I made on this spell on that old thread for explanation of why)

• Ka_Boolean[Ka_Index[3]] Equal to True

This is never set to false so

• Else - Actions
  • Set Ka_Index[1] = (Ka_Index[1] - 1)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • Ka_Index[1] Equal to 0
    • Then - Actions
      • Set Ka_Index[2] = 0
      • Trigger - Turn off (This trigger)
    • Else - Actions

Will never run

• Unit - Kill (Picked unit)

Dummy units still need to be removed after they have been killed to prevent memory leaks

• Unit Group - Pick every unit in Ka_UG and do (Actions)
  • Loop - Actions
    • Unit - Kill (Picked unit)

This will run and effect ALL units in association with this spell, thus if you cast two at once, the paths will be removed early, I believe I also pointed this out before.

You still lack a configuration trigger or general configuration, as I've already said this is against the rules of submissions, as it must support multiple levels by default.

• Set Ka_Index[2] = 0

This is indexed incorrectly, it should be in line with other indexing

• Set Ka_Index[1] = (Ka_Index[1] + 1)

Why have this if it's not used for anything? literally it's used for nothing other than turning off and on the other trigger, and that could be a function fulfilled by what you're using Ka_Index[2] for

The reason your path stops working is because you don't de-index properly, thus your unit group removal keeps being used, preventing the path from being created as it's constantly being removed (and trying to remove units that aren't part of the group, from the group) on top of your removal method via group selection being wrong in itself, you should use a unique ID value which connects all parts of the spell so that they can all be removed at once via scanning through the array looking for units with this same ID value

This should be taken to the trigger & scripts section (second time I've said this) the spell resource section is no place for unfinished works, please read the rules you agree to when uploading resources.

Also it /still/ doesn't even deal any damage what so ever, so it's just some "pretty lights" that serve no purpose

 

[Ajijang2013]

Alright guys so I guess I've fixed all what I need to fix. I think all I need to do is to post the triggers but I don't know how, I guess I just send a screenshot of my triggers.

 

[IcemanBo]

Alright guys so I guess I've fixed all what I need to fix. I think all I need to do is to post the triggers but I don't know how, I guess I just send a screenshot of my triggers.

http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[Ajijang2013]

Alright I have posted my triggers.

 

[Tank-Commander]

• Destructible - Kill (Picked destructible)

If you're going to destroy destructibles, you need to filter out just he trees otherwise you'll destroy the bridges (and other key destructibles) an example of how you do this can be found http://www.hiveworkshop.com/forums/...ui-1-1-a-228385/?prev=search=tree&d=list&r=20 or in various other people's spells/systems

• Ka_Boolean[Ka_IndexLoop] Equal to True

Is now redudant, remove it

• Unit - Cause Ka_Dummy[Ka_IndexLoop] to damage Ka_DMGPU, dealing 300.00 damage of attack type Spells and damage type Universal

The damage source should be from the caster of the spell, not the dummy, this is to make the spell damage behave in a way like the normal spells in WC3.

Also again this spell must be able to be levelled, instead of having 1 fixed level

Configuration trigger still needed
Movement still done inefficiently
The dummy itself is killed but not removed even though the path is

• Set Ka_DMGPU = No unit

This line is repeated, also it should be set to null instead (custom script line)

Eitherway looking much better, good progress

 

[IcemanBo]

Additional to what was mentioned in other reviews:

• Custom script: if udg_Ka_UG[udg_Ka_Index] == null then
• Custom script: set udg_Ka_UG[udg_Ka_Index] = CreateGroup()
• Custom script: endif

No need to check if it's null, it is always.

(Owner of Ka_Dummy[Ka_IndexLoop]) should be replaced by Set Ka_Owner[Ka_IndexLoop]

• Set Ka_PickedUD = (Picked unit)

^Is not needed if you would use "PickedUnit" only once.

Point[array] is not really needed here. You just could use 2 normal point variables.

• Set Ka_DMGUG = (Units within 200.00 of Ka_Loc[3] matching (((Matching unit) belongs to an enemy of (Owner of Ka_Dummy[Ka_IndexLoop])) Equal to True))
• Unit Group - Pick every unit in Ka_DMGUG and do (Actions)
• Loop - Actions
• Set Ka_DMGPU = (Picked unit)
• Unit - Cause Ka_Dummy[Ka_IndexLoop] to damage Ka_DMGPU, dealing 70.00 damage of attack type Spells and damage type Universal

^Leak

In your deindex part:

• Unit Group - Pick every unit in Ka_UG[Ka_IndexLoop] and do (Actions)

^Here you should store PickedUnit into a variable.

Why this line: (?)

• Custom script: call DestroyGroup (udg_Ka_DMGUG)

No need to remove units from a group you are going to destroy.

• Set Ka_DMGPU = No unit

This line is repeated, also it should be set to null instead (custom script line)

I don't think there's a difference to null it via custom script.

 

[Tal'Rarity]

Tank-Commander try a quick convert to JASS and that should show you that it should not be set to null instead with CS because it is already being set to Null, good job so far on the spell Ajijang.



Set Ka_DMGPU = No unit is literally equal to Set udg_Ka_DMGPU = Null

 

[Ajijang2013]

Alright, Guys. All you wish for my spell is done.

 

[GywGod133]

use 0.03125 instead using 0.03

 

[BPower]

What's the benefit of this kamehameha spell towards the one we just approved?

 

[Ajijang2013]

@BPower, you had a point. Sorry for this, just tell me what should I do.

 

[IcemanBo]

You should improve the description. Explain in short statements what the spell exactly does, so it can be differed easily with an other kamehameha.

An ingame screenshot would also be very useful, that the user immediatly can analyse the visuals.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
  • (Ability being cast) Equal to Ka_Spell
• Then - Actions
  • Trigger - Turn on Kamehameha Loop <gen>
• Else - Actions

^Replace the trigger condition by the condition you use in code shown above.
Check if index == 1 before you turn on the trigger.

• Set Ka_DummyPos = (Position of Ka_Dummy[Ka_IndexLoop])

I don't see you remove the location.

• Unit Group - Pick every unit in Ka_DGroup1 and do (Actions)
  • Loop - Actions
    • Set Ka_DGroup1picked = (Picked unit)
    • Unit - Cause Ka_Dummy[Ka_IndexLoop] to damage Ka_DGroup1picked, dealing Ka_Damage[1] damage of attack type Spells and damage type Universal
    • Custom script: call DestroyGroup (udg_Ka_DGroup1)

Why you destroy the group after first iteration?

• -------- ------------------- --------
• Visibility - Disable fog of war
• Visibility - Disable black mask

^Should be moved outside the spell trigger.

 

[Ajijang2013]

Dude, for ya' information. I removed it you just don't see it because it was on the low part of the Loop

Hidden

• Custom script: call RemoveLocation (udg_Ka_DummyPos)

 

[GywGod133]

Destroying destructible
must be void the Bridge, barrel, etc except trees

so use dummy to destroy the tree or
just use this system
http://www.hiveworkshop.com/forums/spells-569/gui-jass-isdesttree-v1-3-a-240149/ (GUI Friendly)

 

[IcemanBo]

Dude, for ya' information. I removed it you just don't see it because it was on the low part of the Loop

Hidden

• Custom script: call RemoveLocation (udg_Ka_DummyPos)

It only exists in the deindex part, which is wrong.

 

[GywGod133]

@Ajijang2013
Tree Destroyer has been made... Good

 

[Ajijang2013]

@Ajijang2013
Tree Destroyer has been made... Good

Ye ye ! .. Well, I gonna declare my spell as the easy-way kamehameha as Haley's the insane one been made on all kamehameha spell.

- By the way, I'd just learned the tree destroyer in about 1 minute. lol

 

[Ajijang2013]

What's the benefit of this kamehameha spell towards the one we just approved?

Well, I just gonna consider mine as the "easy-way" Kamehameha or something like that.

 

[GywGod133]

@Ajijang2013
This Unit - Create 1 Missle Path for Ka_Owner[Ka_IndexLoop] at Ka_DummyCP facing Ka_Angle[Ka_IndexLoop] degrees in your Loop, you must change the Ka_Owner[Ka_IndexLoop] into Neutral Passive
so become like this
Unit - Create 1 Missle Path for Neutral Passive at Ka_DummyCP facing Ka_Angle[Ka_IndexLoop] degrees

Question: Why you need to change?
Answer: In every 0.03125 sec, you create a huge of amount of units that owner by (Owner of Caster)
If you look in Score Screen, you will get a overwhelming score cuz (One Cast only? lol), so set it in Neutral Passive.

======================================
change this

• Unit Group - Pick every unit in Ka_DGroup1 and do (Actions)
  • Loop - Actions
    • Set Ka_DGroup1picked = (Picked unit)
    • Unit - Cause Ka_Dummy[Ka_IndexLoop] to damage Ka_DGroup1picked, dealing Ka_Damage[1] damage of attack type Spells and damage type Universal
    • Custom script: call DestroyGroup (udg_Ka_DGroup1)

into this...........

• Unit Group - Pick every unit in Ka_DGroup1 and do (Actions)
  • Loop - Actions
    • Set Ka_DGroup1picked = (Picked unit)
    • Unit - Cause Ka_Dummy[Ka_IndexLoop] to damage Ka_DGroup1picked, dealing Ka_Damage[1] damage of attack type Spells and damage type Universal
• Custom script: call DestroyGroup (udg_Ka_DGroup1)

 

[Daffa]

Your IsDestTree will break if user remove harvest ability from Peasant.
Why? because the IsDestTree don't add an additional harvest ability for safety. BPower state this before.

I hope you check the Init in GUI part of the linked IsDestTree carefully, this line :

• Custom script: call UnitAddAbility(udg_DestChecker, 'Ahrl')

is the safety fail in my IsDestTree, add the line below the :

• Custom script: call UnitAddAbility(udg_DestChecker, 'Aloc')

and it should be safe.

I think the rest are fine. Don't notice anything too weird in my check, maybe I missed something but hopefully not.

Note : There are based on Posted Codes and may not reflect on the actual map.

 

[Maker]

Don't use Pause unit action for the caster.

 

[Maker]

Please do not use Pause unit action.

Needs Fix

• Custom script: if udg_Ka_UG[udg_Ka_Index] == null then
• Custom script: set udg_Ka_UG[udg_Ka_Index] = CreateGroup()
• Custom script: endif

No need to check if it's null, it is always.

Groups for indexes 0 and 1 are created automatically at map initialization.

 

[Ajijang2013]

I didn't pause the casting unit anymore, I removed the checking of unit group.

 

[Maker]

You still pause the unit. There is very little attention given to object editor data such as tooltips and icon position. The ability makes no sound and the caster's animations could be utilized better.

Needs Fix

 

[Ajijang3434]

New Account

Hey, Maker. This is my new account. I'm gonna ask you about my KAMEHAMEHA SPELL. Are the rest of the triggers are all right or acceptable?