[JASS] JASS sliding triggers

[onix_noob]

Those are mine current sliding triggers i am trying to make them work for now after this i will try to make the sliding thing

function MasterSlideTimer takes nothing returns nothing
    local timer t = CreateTimer()
    call TimerStart(t,0.25,false,function MasterSlide)
    set t = null
endfunction

function MasterSlide takes nothing returns nothing
    local unit udg_kittys
    local unit u 
    local timer t = GetExpiredTimer()
    local real lx 
    local real ly 
    local location tempPoint
    local integer i = 1
    local unit group = udg_kittys
    loop
        exitwhen i > 12
        set u = (udg_kittys[i])
        set lx = GetUnitX(u)
        set i = i+1
        set ly = GetUnitY(u)        
        set tempPoint = GetUnitLoc(u)
        if (GetTerrainType (lx, ly) == 'Nice' ) and (IsUnitInGroup (udg_kittys[i])),( SlidingAlive == true) then
            call DisplayTextToForce( GetPlayersAll(), "This is a message" )
    endloop
        //null all
        set u = null
        call DestroyTimer(t)
        set t = null
        call RemoveLocation (tempPoint)
endfunction

how to fix my current code
Edited:1

 

[SerraAvenger]

if (GetTerrainType (lx, ly) == 'Nice' ) And (IsUnitInGroup (udg_kittys[GetForLoopIndexA()]), SlidingAlive = true) then
            call DisplayTextToForce( GetPlayersAll(), "This is a message" )

where's the endif?

"And" -> and

if you're allready using JASS; why are you still using bj_forLoopAIndex?

  local integer i = 1
  loop
        exitwhen i > 12

then replace all GetForLoopIndexA() with i.

 

[onix_noob]

now looks like this

function MasterSlide takes nothing returns nothing
    local unit udg_kittys
    local unit u 
    local timer t = GetExpiredTimer()
    local real lx 
    local real ly 
    local location tempPoint
    local integer i = 1
    local unit group = udg_kittys
    loop
        exitwhen i > 12
        set u = (udg_kittys[i])
        set lx = GetUnitX(u)
        set i = i+1
        set ly = GetUnitY(u)        
        set tempPoint = GetUnitLoc(u)
        if (GetTerrainType (lx, ly) == 'Nice' ) and (IsUnitInGroup (udg_kittys[i])),( SlidingAlive == true) then
            call DisplayTextToForce( GetPlayersAll(), "This is a message" )
    endloop
        //null all
        set u = null
        call DestroyTimer(t)
        set t = null
        call RemoveLocation (tempPoint)
endfunction

but still give me error at this line

if (GetTerrainType (lx, ly) == 'Nice' ) and (IsUnitInGroup (udg_kittys[i])),( SlidingAlive == true) then

and where to put this endif

 

[QueloR]

The endif is supposed to put an end to the if so to speak.

if(Argument)
Stuff to happend goes here
endif

So, it works like the loop / endloop

 

[onix_noob]

The endif is supposed to put an end to the if so to speak.

if(Argument)
Stuff to happend goes here
endif

So, it works like the loop / endloop

i get that end if is like endloop but where to put it if some one don't help me learn JASS i will never learn it (i need to watch how the things are working not to find out how they are working. You know it's easy to work when u how the things are done than to try to done them for first time without watching how others done them)

Edit: there i go and

function MasterSlide takes nothing returns nothing
    local unit udg_kittys
    local unit u 
    local timer t = GetExpiredTimer()
    local real lx 
    local real ly 
    local location tempPoint
    local integer i = 1
    local group SlidingAlive
    loop
        exitwhen i > 12
        set u = udg_kittys[i]
        set lx = GetUnitX(u)
        set i = i+1
        set ly = GetUnitY(u)        
        set tempPoint = GetUnitLoc(u)
        if (GetTerrainType (lx, ly) == 'Nice') "and" (IsUnitInGroup ((udg_kittys[i]), SlidingAlive), == true) then
            call DisplayTextToForce( GetPlayersAll(), "This is a message" )
            exitwhen false
    endloop
    //null all
    set u = null
    call DestroyTimer(t)
    set t = null
    call RemoveLocation (tempPoint)
endfunction

i am stuck with "syntax error" at this line

if (GetTerrainType (lx, ly) == 'Nice') "and" (IsUnitInGroup ((udg_kittys[i]), SlidingAlive), == true) then

 

[Darkyvm]

if (GetTerrainType (lx, ly) == 'Nice') "and" (IsUnitInGroup ((udg_kittys[i]), SlidingAlive), == true) then
     call DisplayTextToForce( GetPlayersAll(), "This is a message" )
endif

That's all, every time you make an "if" statement (don't know if this is the correct word to use), you have to write "endif" at the end of it or it will bug.

Also, remove the "exitwhen", I'm not sure, but I think it only works for loops, not ifs.

 

[onix_noob]

the jass craft say that the problem is here

if (GetTerrainType (lx, ly) == 'Nice') and (IsUnitInGroup ((udg_kittys[i]), SlidingAlive)), == true) then

don't say nothing about missing endif or other things the whole script look like this if some one can fix it ok if you think i have to put "exitwhen, endif" just chek for your self

 

[Ranger21]

(IsUnitInGroup ((udg_kittys), SlidingAlive)) == true) - right

(IsUnitInGroup ((udg_kittys), SlidingAlive)), == true) - error xD

 

[Wraith]

You don't need to use exitwhen because its just for looping not inside if, you need endif. i don't really sure what is 'nice'?

 

[GhostWolf]

Why do people like using so many parentheses even when unneeded. The only thing they do is make the code less readable.

 

[Cokemonkey11]

Is your problem resolved? I can't really tell. If not, please post 1 continuous jass block with an explanation of what isn't working and we will fix it for you.

 

[onix_noob]

I will try to give all the info i can if somthing is not clear please tell me

function MasterSlideTimer takes nothing returns nothing
    local timer t = CreateTimer()
//i am not familiar with timer but the problem here is with function
//i dunno how to define functions 
    call TimerStart(t,0.25,false,function MasterSlide)
    set t = null
endfunction

//This will be trigger that activate the sliding triggers (they will run every 0.02 seconds)
function MasterSlide takes nothing returns nothing
    local unit array udg_kittys //are the units that will slide set with GUI in map initialization
    local unit u //the first selected unit in the loop
    local timer t = GetExpiredTimer() //the timer from function 1
    local real lx //unit x for GetTerrainType 
    local real ly //unit y for GetTerrainType
    local location tempPoint //current position of the unit that i will chek
    local integer i = 1 //the loop
    local group SlidingAlive //if the unit is alive is in this group declared in another GUI trigger but u dudes may give me JASS line for if unit is alive
    loop
        exitwhen i > 12
        set u = udg_kittys[i]
        set lx = GetUnitX(u)
        set i = i+1
        set ly = GetUnitY(u)        
        set tempPoint = GetUnitLoc(u)
        //down lines chek if terrain type is ice and if the unit is in unit group sliding alive (if the unit is alive)
        //u can help me to make the second part somthing like if unit is alive or somthing
        if (GetTerrainType (lx, ly) == 'Nice') and (IsUnitInGroup ((udg_kittys[i]), SlidingAlive)), == true) then //here it give me syntax error dunno why
            //here i am cheking if this work at all
            call DisplayTextToForce( GetPlayersAll(), "This is a message" )
            exitwhen false
    endloop
    //null all
    set u = null
    call DestroyTimer(t) //destroyng the timer from first function
    set t = null //null the timer from first function
    call RemoveLocation (tempPoint)
endfunction

I dunno if i can and how to merge those both triggers into one and to make the timer trigger to activate the second trigger

 

[Cokemonkey11]

Put an initilization in your first trigger to make an event (call TriggerRegsterAnyUnitEventBJ, etc)

Put MasterSlide ABOVE MasterSlideTimer since you have to declare functions which are later called.

Change .25 to .03 to increase FPS from 4 frames/s to 33 frames/s.

 

[onix_noob]

My trigger look like this now, don't give any errors and don't type any messages (don't start at all in the game i think)

//This will be trigger that activate the sliding triggers (they will run every 0.02 seconds)
function MasterSlide takes nothing returns nothing
    local unit array udg_kittys //are the units that will slide, set with GUI in map initialization
    local unit u //the first selected unit in the loop
    local timer t = GetExpiredTimer() //the timer from function 1
    local real lx //unit x for GetTerrainType
    local real ly //unit y for GetTerrainType
    local location tempPoint //current position of the unit that i will chek
    local integer i = 1 //the loop
    local group SlidingAlive //if the unit is alive is in this group declared in another GUI trigger but u dudes may give me JASS line for if unit is alive
    loop
        exitwhen i > 12
        set u = udg_kittys[i]
        set lx = GetUnitX(u)
        set i = i+1
        set ly = GetUnitY(u)
        set tempPoint = GetUnitLoc(u)
        //down lines chek if terrain type is ice and if the unit is in unit group sliding alive (if the unit is alive)
        //u can help me to make the second part somthing like if unit is alive or somthing
        if (GetTerrainType (lx, ly) == 'Nice') then //here it give me syntax error dunno why
            //here i am cheking if this work at all
            call DisplayTextToForce( GetPlayersAll(), "This is a message" )
        endif
    endloop
    //null all
    set u = null
    call DestroyTimer(t) //destroyng the timer from first function
    set t = null //null the timer from first function
    call RemoveLocation (tempPoint)
endfunction

function MasterSlideTimer takes nothing returns nothing
    local timer t = CreateTimer()
//i am not familiar with timer but the problem here is with function
//i dunno how to define functions
    call TimerStart(t,0.03,false, function MasterSlide)
    set t = null
endfunction

how to start my trigger in game i chek the box where it say run at map initialization

Edit: the trigger look like this now and it work. Now the sliding part remain i will try to make it tommorow

//This will be trigger that activate the sliding triggers (they will run every 0.02 seconds)
globals
//    unit array udg_kittys //are the units that will slide, set with GUI in map initialization
    unit u //the first selected unit in the loop
    timer t = GetExpiredTimer() //the timer from function 1
    real lx //unit x for GetTerrainType
    real ly //unit y for GetTerrainType
    location tempPoint //current position of the unit that i will chek
    integer i = 1 //the loop
    group SlidingAlive //if the unit is alive is in this group declared in another GUI trigger but u dudes may give me JASS line for if unit is alive
endglobals

function Trig_MasterSlide_Actions takes nothing returns nothing
    set i = 1    
    loop
        exitwhen i > 12
        set u = udg_kittys[i]
        set lx = GetUnitX(u)
        set i = i+1
        set ly = GetUnitY(u)
        set tempPoint = GetUnitLoc(u)
        //down lines chek if terrain type is ice and if the unit is in unit group sliding alive (if the unit is alive)
        //u can help me to make the second part somthing like if unit is alive or somthing
        if (GetTerrainType (lx, ly) == 'Nice') then //here it give me syntax error dunno why
            //here i am cheking if this work at all
            call DisplayTextToForce( GetPlayersAll(), "It work" )
        else
            call DisplayTextToForce( GetPlayersAll(), "No work" )
        endif
    endloop
    //null all
    set u = null
    call DestroyTimer(t) //destroyng the timer from first function
    set t = null //null the timer from first function
    call RemoveLocation (tempPoint)
endfunction

function InitTrig_MasterSlide takes nothing returns nothing
local timer t = CreateTimer()
    set gg_trg_MasterSlide = CreateTrigger( )
    call TimerStart(t,0.03,true, function Trig_MasterSlide_Actions)
    set t = null
endfunction

any ideas how to make my unit slide forward with it's current speed. I search for such a function but there are few that are "call UnitMoveToAsProjectileGen(m, arc,x2,y2,null,z2)" and i don't get nothing from these is there another MoveUnit functions

 

[onix_noob]

Ok i solve the problem but i use BJ function to calculate where is the next sliding point. If any one wonna help me to make it non BJ function pm me.

Thread solved tnx for the help ...

 

[TriggerHappy]

None of this would have happened if you used JassNewGen Pack.

It has more accurate syntax error details in the syntax checker.