Is this weather trigger leaking?

[Valenvai]

• Weather Effects
  • Events
    • Time - Every 120.00 seconds of game time
  • Conditions
  • Actions
    • Set Weather = (Random percentage)
    • Wait 0.10 seconds
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Weather Greater than or equal to 80.00
      • Then - Actions
        • Environment - Create at (Playable map area) the weather effect Ashenvale Rain (Light)
        • Environment - Turn (Last created weather effect) On
        • Set WeatherVar = (Last created weather effect)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Weather Greater than or equal to 60.00
            • Weather Less than or equal to 79.00
          • Then - Actions
            • Environment - Create at (Playable map area) the weather effect Lordaeron Rain (Heavy)
            • Environment - Turn (Last created weather effect) On
            • Set WeatherVar = (Last created weather effect)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Weather Less than or equal to 59.00
              • Then - Actions
                • Environment - Turn WeatherVar Off
                • Environment - Remove WeatherVar
              • Else - Actions

If yes, changing to this below, will save the problem?

• Weather Effects
  • Events
    • Time - Every 120.00 seconds of game time
  • Conditions
  • Actions
    • Set Weather = (Random percentage)
    • Wait 0.10 seconds
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Weather Greater than or equal to 80.00
      • Then - Actions
        • Environment - Turn WeatherVar Off
        • Environment - Remove WeatherVar
        • Wait 0.10 seconds
        • Environment - Create at (Playable map area) the weather effect Ashenvale Rain (Light)
        • Environment - Turn (Last created weather effect) On
        • Set WeatherVar = (Last created weather effect)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Weather Greater than or equal to 60.00
            • Weather Less than or equal to 79.00
          • Then - Actions
            • Environment - Turn WeatherVar Off
            • Environment - Remove WeatherVar
            • Wait 0.10 seconds
            • Environment - Create at (Playable map area) the weather effect Lordaeron Rain (Heavy)
            • Environment - Turn (Last created weather effect) On
            • Set WeatherVar = (Last created weather effect)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Weather Less than or equal to 59.00
              • Then - Actions
                • Environment - Turn WeatherVar Off
                • Environment - Remove WeatherVar
              • Else - Actions

 

[Chaosy]

I don't see any leaks.

 

[Valenvai]

Ok thnx a lot.

 

[Maker]

A bit off topic but the if/then/else could be optimized

If a > 80 then
--do x
elseif a > 60 then
--do y
else
--do z
endif

 

[Valenvai]

Oh... I thought that if the number fits both "IFs" then it runs both actions.