Inventory v1.0.8

[Bribe]

Did you have to convert Tasyen's Lua script to Wurst manually? Or is there an existing transcompiler for that?

 

[Nikita17]

Map??

 

[Nikita17]

???

 

[Elprede]

Did you have to convert Tasyen's Lua script to Wurst manually? Or is there an existing transcompiler for that?

I had to convert the script manually. However, the Wurst compiler does run JASSHelper beforehand, so you could actually use functions from compiled vJASS code in the same map. The compiler doesn't work with maps that have Lua as the main scripting language.

???

Fixed

 

[Nikita17]

No code

 

[Elprede]

No code

All the code has been compiled into that one war3map.lua file. You can grab the original code from the map description. To use this system, however, you will need to set up a Wurst project. I am planning to make a GUI-Friendly version with Lua/vJASS.

 

[Izzetin]

Thats a really nice Inventory i was looking for something like that.
I hope you upload a vJASS version at anytime that would be awesome !

 

[Elprede]

vJASS version has been released and is currently ahead of the Wurst version.

Some differences between versions:

• (MUI) Each unit has their own custom inventory in vJASS
  • Select another unit to see its unique inventory
  • Switch to another unit in a group selection to see its unique inventory
• All units of a player share a custom inventory in Wurst (This might change later or be kept as an addition)
• The vJASS version does not require any imports other than code for now.
• API exists for designing the inventory in vJASS

To do list:

• Consider item charges (Display charges on slot button and adapt to splits and stacks)
• (Option) Display another unit's inventory at the same time as your own unit
  • Drag and drop items from one custom inventory to another
• Give the ability to add and remove items to inventory via code
• Experimental Move the inventory on the screen via a button in game.

 

[Izzetin]

I think theres a bug in the 1.0.7 JASS version. if you try to place an Item from 1 free Bag slot to another (With Button Effect) the Item-Icon isnt moveable anymore and is stuck on the screen (I can provide screenshots if needed)

 

[Elprede]

I think theres a bug in the 1.0.7 JASS version. if you try to place an Item from 1 free Bag slot to another (With Button Effect) the Item-Icon isnt moveable anymore and is stuck on the screen (I can provide screenshots if needed)

This has been fixed as well as another bug with closing the inventory. Thank you for testing the system and spotting this bug!

 

[Izzetin]

The Icon on Screen bug is fixed but the Items put into the Inventory are not moveable anymore. (JASSv)

 

[Elprede]

I just downloaded the version from this thread and tested it just now.
This is what I am seeing on my end. After swapping item positions, I can still move the items to another slot.

@Izzetin Is this not what is happening for you? Or did you meant something else?

 

[Spacebuns]

Does the big inventory window act as active inventory slots (allowing heroes to receive bonus/abilities from more than 6 items allowed) or as a backpack (items put there do not provide any bonus/abilities, only the default 6 slots are active)

 

[Elprede]

At the moment, the inventory is just a storage device. However, such is not off the table. I might abuse the inventory ability to do so or figure out something else. Perhaps, I would provide custom events for when an item is stored in or removed from the inventory. From there, you can add any abilities you like given the item concerned.

 

[Spacebuns]

At the moment, the inventory is just a storage device. However, such is not off the table. I might abuse the inventory ability to do so or figure out something else. Perhaps, I would provide custom events for when an item is stored in or removed from the inventory. From there, you can add any abilities you like given the item concerned.

That's OK. This inventory is player-owned and not unit-owned, right?

 

[Elprede]

The Wurst version is player-owned, but the vJASS version is unit-owned. I am going to introduce a lock mechanism, so you can lock the inventory to a unit. From there, you can lock the inventory to a dummy unit. Then all units of a player can share an inventory. Or I might just make another version that is player based. It will definitely be easier to code than the unit-based one.

 

[Spacebuns]

If the system is capable of holding tens of slots, it would make sense for the inventory to be player-owned, as a common stash for units owned by a player.

 

[Izzetin]

You can have 6 Active Items. With this Inventory you can ''Click'' 1 Item in the Custom Inventory and the Unit gets the Ability/Stats of the clicked item. so you can have 7 Active Items at once if you leave the Inventory open. is this intended ?

 

[Elprede]

If the system is capable of holding tens of slots, it would make sense for the inventory to be player-owned, as a common stash for units owned by a player.

With the way I coded the system, the number of slots you can have all together in one map is the array limit in theory. You are also limited by the operation limit. So, if you have one inventory instance, that one inventory could have 32768 slots. Each inventory instance will divide up the number of slots. I will soon change this.

Some users may want the system to be player-based, while others may want it to be unit-based. I am going to cater to both sides since that would give the system greater potential for branching. I just haven't decided yet how to approach it. A two in one system or two separate systems?

You can have 6 Active Items. With this Inventory you can ''Click'' 1 Item in the Custom Inventory and the Unit gets the Ability/Stats of the clicked item. so you can have 7 Active Items at once if you leave the Inventory open. is this intended ?

It wasn't intended but it is a consequence of the method that I used to enable drag and drop. To remedy this, I could use dummy items or disable abilities. I will look into this. Besides, this is only when an item is selected. Other times, all is well.

 

[3xKataratos]

That system is exactly what i was looking for !!! Thnx !!!
Allthought i have no knowledge of vJASS or Wrust and in the how to import tab about vJASS you say just copy the folder ...

I did but i get like 2228 compile errors , can you please help me to fix this .

 

[Elprede]

@3xKataratos In the trigger editor, under the JassHelper submenu, make sure Enable vJASS and Enable JassHelper are both checked.

I just added this tidbit to the thread description to prevent confusion in the future

 

[Produtor]

The system is very good, but I tested it in multiplayer and it doesn't work correctly, when two players try to open the bag at the same time it crashes. I did the test in the jass version.

 

[Wrda]

While I'm not qualified to review the Wurst version, since I don't really know it, I still can say this is a pretty good system. Perhaps you could add the clicking sound when one clicks on the button to open the inventory, and highlighting, to show it's interactable and not simply a frame with no events for decoration. I only took a glimpse on the VJASS version. I'm not sure if it's actually possible for one reviewer to review part of a resource, and another one review the other part. The only current Wurst reviewer I know is Cokemonkey11.

 

[Izzetin]

Is there a way to put the item directly into the Bag from the ground ? that would be awesome.

-Edit: Items stacks and Item Charges are not showing.
Would be good to know how many Potions Items are left.

 

[hnkm080596]

Can you make a version for 1.3.1 ? This inventory system is awesome

 

[emperor_d3st]

The vJass system crashed when I was putting an item to the inventory AND I had tens of thousands of destructibles / doodads. I spent a day to troubleshoot it :')
I selected a bunch of doodads and clicked Edit / Select All Special then delete.
Turns out that the root cause of the issue was Blizzard's Volcano doodad.
I don't know why, but it crashed the game.

 

[emperor_d3st]

Another issue to report:
System crashes map when loading saves.
The root cause is Blizzard's bug with the frames being tripped by the vJass HoverOriginButton library
To reproduce:

(I'm using the latest version of Warcraft III.)

Take a completely empty map.
Inject vJass HoverOriginButton system into the triggers of the map.
Start the map.
Do a save.
Load the save.
After it loads and you press the ANY key, Warcraft III will crash.

Here is the relevant info.

To fix:

Copy/paste this library by Taysen:

library FrameLoader initializer init_function
// in 1.31 and upto 1.32.9 PTR (when I wrote this). Frames are not correctly saved and loaded, breaking the game.
// This library runs all functions added to it with a 0s delay after the game was loaded.
// function FrameLoaderAdd takes code func returns nothing
// func runs when the game is loaded.
globals
private trigger eventTrigger = CreateTrigger()
private trigger actionTrigger = CreateTrigger()
private timer t = CreateTimer()
endglobals
function FrameLoaderAdd takes code func returns nothing
call TriggerAddAction(actionTrigger, func)
endfunction
private function timerAction takes nothing returns nothing
call TriggerExecute(actionTrigger)
endfunction
private function eventAction takes nothing returns nothing
call TimerStart(t, 0, false, function timerAction)
endfunction
private function init_function takes nothing returns nothing
call TriggerRegisterGameEvent(eventTrigger, EVENT_GAME_LOADED)
call TriggerAddAction(eventTrigger, function eventAction)
endfunction
endlibrary

And then find all the code in the Inventory library and some rewrite it to work around the bug :')

 

[Produtor]

Is this system still being updated? There is a way to combine this system with Codeless Save and Load?

 

[Uncle]

Is this system still being updated? There is a way to combine this system with Codeless Save and Load?

Codeless Save and Load allows you to save Integers. Integers can represent anything and everything. So you can save anything you want.

However, glancing at the Jass API, this system doesn't seem to have a simple AddItemToInventorySlot() function. Instead, everything seems to be hardcoded based on Mouse events (dragging and dropping). You'll have to request that the Author adds some kind of functionality to build an Inventory with an array of predetermined items. Or add it yourself if you understand the code.

 

[Produtor]

Codeless Save and Load allows you to save Integers. Integers can represent anything and everything. So you can save anything you want.

However, glancing at the Jass API, this system doesn't seem to have a simple AddItemToInventorySlot() function. Instead, everything seems to be hardcoded based on Mouse events (dragging and dropping). You'll have to request that the Author adds some kind of functionality to build an Inventory with an array of predetermined items. Or add it yourself if you understand the code.

Thanks for the explanation, it would be amazing if you could combine these systems.

 

[Cokemonkey11]

Hi @Elprede is this something you're still working on so that the wurst version has parity with the vjass version?

I see some reported bugs, are you still tracking any remaining issues or shall I review the code?

 

[Elprede]

Hi @Elprede is this something you're still working on so that the wurst version has parity with the vjass version?

I see some reported bugs, are you still tracking any remaining issues or shall I review the code?

Hello Cokemonkey, please hold off on the review because I will be updating this resource.

 

[SgtSMOrc]

I don't have any experience with vJASS. What do I need to do to get the Inventory Button to show up in my map?
Furthermore do I need to keep the following code in order to make it work?

    private function Test takes nothing returns nothing
        local Inventory inv = Inventory.create()/*
        */.setTitle("|cffffcc00Inventory|r")    /*
        */.setTitleSize(0.015)      /*
        */.setBorderSize(0.029)     /*
        */.setButtonSize(0.03)      /*
        */.setSlotCount(12)         /*
        */.setColumnCount(4)        /*
        */.setPosition(0.45, 0.35)  /*
        */.setButtonSpaceGap(0.01)  /*
        */.setSlotIndicatorModel("UI\\Feedback\\Autocast\\UI-ModalButtonOn.mdx")    /*
        */.setSlotEmptyTexture("ui\\widgets\\escmenu\\human\\quest-completed-background.blp")  /*
        */.setOpenButtonTexture("ReplaceableTextures/CommandButtons/BTNDustOfAppearance")

 

[Uncle]

I don't have any experience with vJASS. What do I need to do to get the Inventory Button to show up in my map?
Furthermore do I need to keep the following code in order to make it work?

That Test function creates a new inventory and shows it to Player 1. I'm not sure if each Player needs to create their own inventory but I'd assume so.

Anyway, here's some code that you can put in your map that will automatically create an Inventory for each Player and position the Inventory Button to a convenient location near the standard Inventory:

scope SetupInventories initializer Init

    private function CreateInv takes player p returns nothing
        local Inventory inv = Inventory.create()/*
        */.setTitle("|cffffcc00Inventory|r")    /*
        */.setTitleSize(0.015)      /*
        */.setBorderSize(0.029)     /*
        */.setButtonSize(0.03)      /*
        */.setSlotCount(12)         /*
        */.setColumnCount(4)        /*
        */.setPosition(0.45, 0.35)  /*
        */.setButtonSpaceGap(0.01)  /*
        */.setSlotIndicatorModel("UI\\Feedback\\Autocast\\UI-ModalButtonOn.mdx")    /*
        */.setSlotEmptyTexture("ui\\widgets\\escmenu\\human\\quest-completed-background.blp")  /*
        */.setOpenButtonTexture("ReplaceableTextures/CommandButtons/BTNDustOfAppearance")
 
        call inv.build()
        call inv.showEx(p, true)
        call BlzFrameSetAbsPoint(inv.openButton, FRAMEPOINT_CENTER, 0.6, 0.15)
        //call BlzFrameSetPoint(inv.openButton, FRAMEPOINT_TOPLEFT, BlzGetFrameByName("TipsTextArea", 0), FRAMEPOINT_TOPRIGHT, 0, 0)
    endfunction

    private function SetupInv takes nothing returns nothing
        local integer i = 0
        local player p

        loop
            set p = Player(i)
            if GetPlayerController(p) == MAP_CONTROL_USER and GetPlayerSlotState(p) == PLAYER_SLOT_STATE_PLAYING then
                call CreateInv(p)
            endif

            set i = i + 1
            exitwhen i > 23
        endloop
 
        call DestroyTimer(GetExpiredTimer())
        set p = null
    endfunction

    private function Init takes nothing returns nothing
        call TimerStart(CreateTimer(), 0.01, false, function SetupInv)
    endfunction

endscope

You can adjust the position of the Inventory Button here:

        call BlzFrameSetAbsPoint(inv.openButton, FRAMEPOINT_CENTER, 0.6, 0.15)

0.6 = X position (left and right).
0.15 = Y position (up and down).

To put these values into perspective, that Inventory Button is about X: 0.03, Y: 0.03 units in size. So adjusting the x/y values by increments of 0.01 should be good for precise positioning. Increasing 0.6 to 0.63 for example would move the Button "one button" over to the right.

 

[Produtor]

That Test function creates a new inventory and shows it to Player 1. I'm not sure if each Player needs to create their own inventory but I'd assume so.

Anyway, here's some code that you can put in your map that will automatically create an Inventory for each Player and position the Inventory Button to a convenient location near the standard Inventory:

scope SetupInventories initializer Init

    private function CreateInv takes player p returns nothing
        local Inventory inv = Inventory.create()/*
        */.setTitle("|cffffcc00Inventory|r")    /*
        */.setTitleSize(0.015)      /*
        */.setBorderSize(0.029)     /*
        */.setButtonSize(0.03)      /*
        */.setSlotCount(12)         /*
        */.setColumnCount(4)        /*
        */.setPosition(0.45, 0.35)  /*
        */.setButtonSpaceGap(0.01)  /*
        */.setSlotIndicatorModel("UI\\Feedback\\Autocast\\UI-ModalButtonOn.mdx")    /*
        */.setSlotEmptyTexture("ui\\widgets\\escmenu\\human\\quest-completed-background.blp")  /*
        */.setOpenButtonTexture("ReplaceableTextures/CommandButtons/BTNDustOfAppearance")
 
        call inv.build()
        call inv.showEx(p, true)
        call BlzFrameSetAbsPoint(inv.openButton, FRAMEPOINT_CENTER, 0.6, 0.15)
        //call BlzFrameSetPoint(inv.openButton, FRAMEPOINT_TOPLEFT, BlzGetFrameByName("TipsTextArea", 0), FRAMEPOINT_TOPRIGHT, 0, 0)
    endfunction

    private function SetupInv takes nothing returns nothing
        local integer i = 0
        local player p

        loop
            set p = Player(i)
            if GetPlayerController(p) == MAP_CONTROL_USER and GetPlayerSlotState(p) == PLAYER_SLOT_STATE_PLAYING then
                call CreateInv(p)
            endif

            set i = i + 1
            exitwhen i > 23
        endloop
 
        call DestroyTimer(GetExpiredTimer())
        set p = null
    endfunction

    private function Init takes nothing returns nothing
        call TimerStart(CreateTimer(), 0.01, false, function SetupInv)
    endfunction

endscope

You can adjust the position of the Inventory Button here:

        call BlzFrameSetAbsPoint(inv.openButton, FRAMEPOINT_CENTER, 0.6, 0.15)

0.6 = X position (left and right).
0.15 = Y position (up and down).

To put these values into perspective, that Inventory Button is about X: 0.03, Y: 0.03 units in size. So adjusting the x/y values by increments of 0.01 should be good for precise positioning. Increasing 0.6 to 0.63 for example would move the Button "one button" over to the right.

Hello my friend!

Does this system already work in Multiplayer?

And is there a way to save items with "Codeless Save and Load"?

 

[SgtSMOrc]

That Test function creates a new inventory and shows it to Player 1. I'm not sure if each Player needs to create their own inventory but I'd assume so.

Anyway, here's some code that you can put in your map that will automatically create an Inventory for each Player and position the Inventory Button to a convenient location near the standard Inventory:

scope SetupInventories initializer Init

    private function CreateInv takes player p returns nothing
        local Inventory inv = Inventory.create()/*
        */.setTitle("|cffffcc00Inventory|r")    /*
        */.setTitleSize(0.015)      /*
        */.setBorderSize(0.029)     /*
        */.setButtonSize(0.03)      /*
        */.setSlotCount(12)         /*
        */.setColumnCount(4)        /*
        */.setPosition(0.45, 0.35)  /*
        */.setButtonSpaceGap(0.01)  /*
        */.setSlotIndicatorModel("UI\\Feedback\\Autocast\\UI-ModalButtonOn.mdx")    /*
        */.setSlotEmptyTexture("ui\\widgets\\escmenu\\human\\quest-completed-background.blp")  /*
        */.setOpenButtonTexture("ReplaceableTextures/CommandButtons/BTNDustOfAppearance")
 
        call inv.build()
        call inv.showEx(p, true)
        call BlzFrameSetAbsPoint(inv.openButton, FRAMEPOINT_CENTER, 0.6, 0.15)
        //call BlzFrameSetPoint(inv.openButton, FRAMEPOINT_TOPLEFT, BlzGetFrameByName("TipsTextArea", 0), FRAMEPOINT_TOPRIGHT, 0, 0)
    endfunction

    private function SetupInv takes nothing returns nothing
        local integer i = 0
        local player p

        loop
            set p = Player(i)
            if GetPlayerController(p) == MAP_CONTROL_USER and GetPlayerSlotState(p) == PLAYER_SLOT_STATE_PLAYING then
                call CreateInv(p)
            endif

            set i = i + 1
            exitwhen i > 23
        endloop
 
        call DestroyTimer(GetExpiredTimer())
        set p = null
    endfunction

    private function Init takes nothing returns nothing
        call TimerStart(CreateTimer(), 0.01, false, function SetupInv)
    endfunction

endscope

You can adjust the position of the Inventory Button here:

        call BlzFrameSetAbsPoint(inv.openButton, FRAMEPOINT_CENTER, 0.6, 0.15)

0.6 = X position (left and right).
0.15 = Y position (up and down).

To put these values into perspective, that Inventory Button is about X: 0.03, Y: 0.03 units in size. So adjusting the x/y values by increments of 0.01 should be good for precise positioning. Increasing 0.6 to 0.63 for example would move the Button "one button" over to the right.

Thanks for the quick reply! I tested it and it works until I tried to put an item into the inventory. Then the game crashed, same thing that happened to

emperor_d3st before. It was indeed the Volcano doodad that caused the crash after testing it a second time.​

Edit: I want to open the Inventory with the ESC button

• Show Inventory
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • Custom script: call BlzFrameSetVisible(BlzGetFrameByName("Name", 0), true)

How do I find the name from the inventory frame?

 

[Produtor]

I would like to know if there is a way that when an Item is moved to the Inventory system, a copy of it can be created in one or more dummy units or if this is already done?

Because then I can save this unit in variables and I can save its inventory in "Codeless Save and Load System"

 

[Uncle]

I would like to know if there is a way that when an Item is moved to the Inventory system, a copy of it can be created in one or more dummy units or if this is already done?

Because then I can save this unit in variables and I can save its inventory in "Codeless Save and Load System"

You can use a Hashtable to store the Items when they're acquired/lost. Then load these Items when it comes time to Save your data using a For Loop.

The basic idea when acquiring an item:

• Events
  • Unit - A unit Acquires an item
• Conditions
• Actions
  • Set Variable CV = (Custom value of (Triggering unit))
  • Set Variable Hero_Item_Count[CV] = (Hero_Item_Count[CV] + 1)
  • -------- Get Item_Index using a For Loop or some other method --------
  • Hashtable - Save Item_Type[Item_Index] as Hero_Item_Count[CV] of CV in Item_Hashtable

Then when losing an item:

• Events
  • Unit - A unit Loses an item
• Conditions
  • ((Item being manipulated) is Hidden) Equal to False
• Actions
  • Set Variable CV = (Custom value of (Triggering unit))
  • Set Variable Hero_Item_Count[CV] = (Hero_Item_Count[CV] - 1)
  • -------- Manage the Hashtable data to remove the now lost item (you could sort everything down an index) --------

Remember that this Inventory system will fire the "A unit Loses an item" Event when you transfer an Item into the custom Inventory UI. This is because the Item is moved out of the hero's standard inventory and made Hidden. That's why we check to see if it's Hidden in the Conditions as to not count it as "lost" when this transfer occurs. Note that the CV (custom value) stuff will only work if your units have a unique custom value.

I can't say for certain that this will work, but I don't see why it wouldn't.

 

[Produtor]

You can use a Hashtable to store the Items when they're acquired/lost. Then load these Items when it comes time to Save your data using a For Loop.

The basic idea when acquiring an item:

• Events
  • Unit - A unit Acquires an item
• Conditions
• Actions
  • Set Variable CV = (Custom value of (Triggering unit))
  • Set Variable Hero_Item_Count[CV] = (Hero_Item_Count[CV] + 1)
  • -------- Get Item_Index using a For Loop or some other method --------
  • Hashtable - Save Item_Type[Item_Index] as Hero_Item_Count[CV] of CV in Item_Hashtable

Then when losing an item:

• Events
  • Unit - A unit Loses an item
• Conditions
  • ((Item being manipulated) is Hidden) Equal to False
• Actions
  • Set Variable CV = (Custom value of (Triggering unit))
  • Set Variable Hero_Item_Count[CV] = (Hero_Item_Count[CV] - 1)
  • -------- Manage the Hashtable data to remove the now lost item (you could sort everything down an index) --------

Remember that this Inventory system will fire the "A unit Loses an item" Event when you transfer an Item into the custom Inventory UI. This is because the Item is moved out of the hero's standard inventory and made Hidden. That's why we check to see if it's Hidden in the Conditions as to not count it as "lost" when this transfer occurs. Note that the CV (custom value) stuff will only work if your units have a unique custom value.

I can't say for certain that this will work, but I don't see why it wouldn't.

I'm even trying this, but it's too advanced for me. I'm not very advanced.

I wanted a way to transfer items to a fictional unit and save the unit's inventory.

 

[KenArok]

I'm even trying this, but it's too advanced for me. I'm not very advanced.

I wanted a way to transfer items to a fictional unit and save the unit's inventory.

Save is easy part.. harder part is how you load, the hardest part is how you put all the items into the inventory at once after load.. my stomach is hurt just think about it..

 

[Produtor]

Save is easy part.. harder part is how you load, the hardest part is how you put all the items into the inventory at once after load.. my stomach is hurt just think about it..

How did you save the items in this inventory?

If I can load it I'll help you.

 

[Cokemonkey11]

Is the wurstlang code on github? That would be a better way for me to review the code

 

[emperor_d3st]

Apologies for breaking etiquette by posting a competing system.

I'm working on my own Inventory and Equipment system, mainly because this one in its current form is singleplayer only. Check it out here:

A modern Inventory and Equipment system prototype

Hey folks, I've been working on this for a few weeks now in my scarce insomniac free time. Currently the code is a mess (had to rewrite everything a couple of times as I learned about new bugs and shortcomings of Warcraft). There are probably leaks. There are probably possibilities for desync...

www.hiveworkshop.com

 

[Produtor]

Is there a way to save the items in this inventory?

Where are these items, on the heroes or on dummy unit?

If it's a dummy unit, can I store it in a variable and save its inventory with Codeless Save and Load?